Simple React component to view cached data and test result from API The 2019 Stack Overflow Developer Survey Results Are InRemoving popup notification, the dirty wayCreate one function instead of two bootstrap modalSimple React calculator - child/parent component communicationReact component to list TV shows from a JSON resultComponent that reacts on data changed from the storeDynamic List Application as first Vue.js AppReact Exercise: Build a dynamic list applicationSimple JavaScript front-end framework for building web componentsAdding Youtube iframe API at runtime - React ComponentSearch Result with infinite scroll React component

Realistic Alternatives to Dust: What Else Could Feed a Plankton Bloom?

Deadlock Graph and Interpretation, solution to avoid

What could be the right powersource for 15 seconds lifespan disposable giant chainsaw?

Adding labels to a table: columns and rows

What does "rabbited" mean/imply in this sentence?

Is domain driven design an anti-SQL pattern?

What is the use of option -o in the useradd command?

Why isn't airport relocation done gradually?

Limit to 0 ambiguity

CiviEvent: Public link for events of a specific type

Spanish for "widget"

Inline version of a function returns different value than non-inline version

Why is the maximum length of OpenWrt’s root password 8 characters?

Why do UK politicians seemingly ignore opinion polls on Brexit?

Potential by Assembling Charges

I see my dog run

Does duplicating a spell with Wish count as casting that spell?

Access elements in std::string where positon of string is greater than its size

Patience, young "Padovan"

Inversion Puzzle

When to use the root test. Is this not a good situation to use it?

In microwave frequencies, do you use a circulator when you need a (near) perfect diode?

Time travel alters history but people keep saying nothing's changed

How long do I have to send my income tax payment to the IRS?



Simple React component to view cached data and test result from API



The 2019 Stack Overflow Developer Survey Results Are InRemoving popup notification, the dirty wayCreate one function instead of two bootstrap modalSimple React calculator - child/parent component communicationReact component to list TV shows from a JSON resultComponent that reacts on data changed from the storeDynamic List Application as first Vue.js AppReact Exercise: Build a dynamic list applicationSimple JavaScript front-end framework for building web componentsAdding Youtube iframe API at runtime - React ComponentSearch Result with infinite scroll React component



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


This is only the front end side of things which I have at the moment, as the back end is still being worked on. But as this is my first attempt at a react component, I'd like to know if there is anything I can improve on it.



The component has a text area for viewing the current data stored in the cache within our application, another text area for viewing the result when we send that data off to our API and get a transformed version of the data back, as well as two buttons: one for loading the cached data into one of the text areas and one for calling the API with the cached data. This component is used in development/UAT environment for testing purposes.



class DataRevealer extends React.Component 
constructor(props)
super(props);
this.state = input: '', result: '';

this.getCachedDataHandler = this.getCachedDataHandler.bind(this);
this.transformDataHandler = this.transformDataHandler.bind(this);
this.inputDataChanged = this.inputDataChanged.bind(this);


getCachedDataHandler()
let cachedData = DataRevealActions.getCachedData();
this.setState(input: cachedData);


transformDataHandler()
if (this.state.input)
let transformedData = DataRevealActions.transformData(this.state.input);
this.setState(result: transformedData);
else
alert('No data to transform');



inputDataChanged(event)
this.setState(input: event.target.value);


get getCachedDataButtonText()
//TODO: localise string
return 'Get Cached Data';


get transformDataButtonText()
//TODO: localise string
return 'Transform Data';


render()
return (
<div className='data-revealer-container'>
<textarea value= this.state.input
className='data-revealer-textarea centred-control'
onChange= this.inputDataChanged
/>
<div className='action-buttons centred-control'>
<Button onClick= this.getCachedDataHandler
className='data-revealer-button centred-control'>
<span> this.getCachedDataButtonText </span>
</Button>
<Button onClick= this.transformDataHandler
className='data-revealer-button centred-control' >
<span> this.transformDataButtonText </span>
</Button>
</div>
<textarea value= this.state.result
className='data-revealer-textarea centred-control'
/>
</div>
);



export default DataRevealer;


Couple of things to note:



  • The Button is one of our custom controls, it acts as a normal button but with pre-implemented styling tweaks.

  • The TODO may not actually be needed, as the strings may not need to be localised.


  • DataRevealActions are where the back-end code will go, once that work is done.









share|improve this question









$endgroup$




bumped to the homepage by Community 15 mins ago


This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.





















    0












    $begingroup$


    This is only the front end side of things which I have at the moment, as the back end is still being worked on. But as this is my first attempt at a react component, I'd like to know if there is anything I can improve on it.



    The component has a text area for viewing the current data stored in the cache within our application, another text area for viewing the result when we send that data off to our API and get a transformed version of the data back, as well as two buttons: one for loading the cached data into one of the text areas and one for calling the API with the cached data. This component is used in development/UAT environment for testing purposes.



    class DataRevealer extends React.Component 
    constructor(props)
    super(props);
    this.state = input: '', result: '';

    this.getCachedDataHandler = this.getCachedDataHandler.bind(this);
    this.transformDataHandler = this.transformDataHandler.bind(this);
    this.inputDataChanged = this.inputDataChanged.bind(this);


    getCachedDataHandler()
    let cachedData = DataRevealActions.getCachedData();
    this.setState(input: cachedData);


    transformDataHandler()
    if (this.state.input)
    let transformedData = DataRevealActions.transformData(this.state.input);
    this.setState(result: transformedData);
    else
    alert('No data to transform');



    inputDataChanged(event)
    this.setState(input: event.target.value);


    get getCachedDataButtonText()
    //TODO: localise string
    return 'Get Cached Data';


    get transformDataButtonText()
    //TODO: localise string
    return 'Transform Data';


    render()
    return (
    <div className='data-revealer-container'>
    <textarea value= this.state.input
    className='data-revealer-textarea centred-control'
    onChange= this.inputDataChanged
    />
    <div className='action-buttons centred-control'>
    <Button onClick= this.getCachedDataHandler
    className='data-revealer-button centred-control'>
    <span> this.getCachedDataButtonText </span>
    </Button>
    <Button onClick= this.transformDataHandler
    className='data-revealer-button centred-control' >
    <span> this.transformDataButtonText </span>
    </Button>
    </div>
    <textarea value= this.state.result
    className='data-revealer-textarea centred-control'
    />
    </div>
    );



    export default DataRevealer;


    Couple of things to note:



    • The Button is one of our custom controls, it acts as a normal button but with pre-implemented styling tweaks.

    • The TODO may not actually be needed, as the strings may not need to be localised.


    • DataRevealActions are where the back-end code will go, once that work is done.









    share|improve this question









    $endgroup$




    bumped to the homepage by Community 15 mins ago


    This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.

















      0












      0








      0





      $begingroup$


      This is only the front end side of things which I have at the moment, as the back end is still being worked on. But as this is my first attempt at a react component, I'd like to know if there is anything I can improve on it.



      The component has a text area for viewing the current data stored in the cache within our application, another text area for viewing the result when we send that data off to our API and get a transformed version of the data back, as well as two buttons: one for loading the cached data into one of the text areas and one for calling the API with the cached data. This component is used in development/UAT environment for testing purposes.



      class DataRevealer extends React.Component 
      constructor(props)
      super(props);
      this.state = input: '', result: '';

      this.getCachedDataHandler = this.getCachedDataHandler.bind(this);
      this.transformDataHandler = this.transformDataHandler.bind(this);
      this.inputDataChanged = this.inputDataChanged.bind(this);


      getCachedDataHandler()
      let cachedData = DataRevealActions.getCachedData();
      this.setState(input: cachedData);


      transformDataHandler()
      if (this.state.input)
      let transformedData = DataRevealActions.transformData(this.state.input);
      this.setState(result: transformedData);
      else
      alert('No data to transform');



      inputDataChanged(event)
      this.setState(input: event.target.value);


      get getCachedDataButtonText()
      //TODO: localise string
      return 'Get Cached Data';


      get transformDataButtonText()
      //TODO: localise string
      return 'Transform Data';


      render()
      return (
      <div className='data-revealer-container'>
      <textarea value= this.state.input
      className='data-revealer-textarea centred-control'
      onChange= this.inputDataChanged
      />
      <div className='action-buttons centred-control'>
      <Button onClick= this.getCachedDataHandler
      className='data-revealer-button centred-control'>
      <span> this.getCachedDataButtonText </span>
      </Button>
      <Button onClick= this.transformDataHandler
      className='data-revealer-button centred-control' >
      <span> this.transformDataButtonText </span>
      </Button>
      </div>
      <textarea value= this.state.result
      className='data-revealer-textarea centred-control'
      />
      </div>
      );



      export default DataRevealer;


      Couple of things to note:



      • The Button is one of our custom controls, it acts as a normal button but with pre-implemented styling tweaks.

      • The TODO may not actually be needed, as the strings may not need to be localised.


      • DataRevealActions are where the back-end code will go, once that work is done.









      share|improve this question









      $endgroup$




      This is only the front end side of things which I have at the moment, as the back end is still being worked on. But as this is my first attempt at a react component, I'd like to know if there is anything I can improve on it.



      The component has a text area for viewing the current data stored in the cache within our application, another text area for viewing the result when we send that data off to our API and get a transformed version of the data back, as well as two buttons: one for loading the cached data into one of the text areas and one for calling the API with the cached data. This component is used in development/UAT environment for testing purposes.



      class DataRevealer extends React.Component 
      constructor(props)
      super(props);
      this.state = input: '', result: '';

      this.getCachedDataHandler = this.getCachedDataHandler.bind(this);
      this.transformDataHandler = this.transformDataHandler.bind(this);
      this.inputDataChanged = this.inputDataChanged.bind(this);


      getCachedDataHandler()
      let cachedData = DataRevealActions.getCachedData();
      this.setState(input: cachedData);


      transformDataHandler()
      if (this.state.input)
      let transformedData = DataRevealActions.transformData(this.state.input);
      this.setState(result: transformedData);
      else
      alert('No data to transform');



      inputDataChanged(event)
      this.setState(input: event.target.value);


      get getCachedDataButtonText()
      //TODO: localise string
      return 'Get Cached Data';


      get transformDataButtonText()
      //TODO: localise string
      return 'Transform Data';


      render()
      return (
      <div className='data-revealer-container'>
      <textarea value= this.state.input
      className='data-revealer-textarea centred-control'
      onChange= this.inputDataChanged
      />
      <div className='action-buttons centred-control'>
      <Button onClick= this.getCachedDataHandler
      className='data-revealer-button centred-control'>
      <span> this.getCachedDataButtonText </span>
      </Button>
      <Button onClick= this.transformDataHandler
      className='data-revealer-button centred-control' >
      <span> this.transformDataButtonText </span>
      </Button>
      </div>
      <textarea value= this.state.result
      className='data-revealer-textarea centred-control'
      />
      </div>
      );



      export default DataRevealer;


      Couple of things to note:



      • The Button is one of our custom controls, it acts as a normal button but with pre-implemented styling tweaks.

      • The TODO may not actually be needed, as the strings may not need to be localised.


      • DataRevealActions are where the back-end code will go, once that work is done.






      javascript react.js user-interface






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Aug 8 '18 at 7:52









      Danny GoodallDanny Goodall

      12510




      12510





      bumped to the homepage by Community 15 mins ago


      This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.







      bumped to the homepage by Community 15 mins ago


      This question has answers that may be good or bad; the system has marked it active so that they can be reviewed.






















          1 Answer
          1






          active

          oldest

          votes


















          0












          $begingroup$

          • You can just remove the TODO until it's needed. The code will be easier to follow and if someone needs to localize later, they can figure it out themselves. It's clutter.


          • DataRevealActions would probably be nice to pass in as properties, so the component is configurable. You could pass it in as now, or just have two different properties, getCachedData and transformData.


          Otherwise, looks great!






          share|improve this answer









          $endgroup$













            Your Answer





            StackExchange.ifUsing("editor", function ()
            return StackExchange.using("mathjaxEditing", function ()
            StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
            StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
            );
            );
            , "mathjax-editing");

            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f201187%2fsimple-react-component-to-view-cached-data-and-test-result-from-api%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0












            $begingroup$

            • You can just remove the TODO until it's needed. The code will be easier to follow and if someone needs to localize later, they can figure it out themselves. It's clutter.


            • DataRevealActions would probably be nice to pass in as properties, so the component is configurable. You could pass it in as now, or just have two different properties, getCachedData and transformData.


            Otherwise, looks great!






            share|improve this answer









            $endgroup$

















              0












              $begingroup$

              • You can just remove the TODO until it's needed. The code will be easier to follow and if someone needs to localize later, they can figure it out themselves. It's clutter.


              • DataRevealActions would probably be nice to pass in as properties, so the component is configurable. You could pass it in as now, or just have two different properties, getCachedData and transformData.


              Otherwise, looks great!






              share|improve this answer









              $endgroup$















                0












                0








                0





                $begingroup$

                • You can just remove the TODO until it's needed. The code will be easier to follow and if someone needs to localize later, they can figure it out themselves. It's clutter.


                • DataRevealActions would probably be nice to pass in as properties, so the component is configurable. You could pass it in as now, or just have two different properties, getCachedData and transformData.


                Otherwise, looks great!






                share|improve this answer









                $endgroup$



                • You can just remove the TODO until it's needed. The code will be easier to follow and if someone needs to localize later, they can figure it out themselves. It's clutter.


                • DataRevealActions would probably be nice to pass in as properties, so the component is configurable. You could pass it in as now, or just have two different properties, getCachedData and transformData.


                Otherwise, looks great!







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Aug 13 '18 at 3:14









                ndpndp

                1,21686




                1,21686



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f201187%2fsimple-react-component-to-view-cached-data-and-test-result-from-api%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

                    Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

                    Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar