Ttykuu

Pre-Employment Background Check With Consent For Future Checks

What is the meaning of "You've never met a graph you didn't like?"

How to make money from a browser who sees 5 seconds into the future of any web page?

ContourPlot — How do I color by contour curvature?

How to understand "he realized a split second too late was also a mistake"

How do you justify more code being written by following clean code practices?

Would a primitive species be able to learn English from reading books alone?

Do you waste sorcery points if you try to apply metamagic to a spell from a scroll but fail to cast it?

Why is participating in the European Parliamentary elections used as a threat?

What should be the ideal length of sentences in a blog post for ease of reading?

Can I cause damage to electrical appliances by unplugging them when they are turned on?

Anime with legendary swords made from talismans and a man who could change them with a shattered body

Would this string work as string?

Should I assume I have passed probation?

Why does a 97 / 92 key piano exist by Bösendorfer?

Did I make a mistake by ccing email to boss to others?

Given this phrasing in the lease, when should I pay my rent?

Is there a distance limit for minecart tracks?

If Captain Marvel (MCU) were to have a child with a human male, would the child be human or Kree?

Isometric embedding of a genus g surface

Confusion over Hunter with Crossbow Expert and Giant Killer

Storage of electrolytic capacitors - how long?

Is there anyway, I can have two passwords for my wi-fi

What does the word 'upstream' mean in the context?

Powershell script for zipping up old files

Regular backup/snapshotsService class for Archiving and Mirroring Files and DirectoriesCopying files in HaskellBacking up single-user PC dataRenaming PDF files based on given rules in a text fileZip the contents of subfolders, conditionallyIdentify files within folder structure that have common file sizesUsing build event to run Powershell script to run built DLLXignCode Bypasser installer for Blade & SoulBash on Synology - Delete recycle bin entries over X days old

0

$begingroup$

I have a script for zipping up old files. I know using Windows Compression isn't ideal, so I will make the script run using 7-Zip later on. For now though, I just want see how I can make my current script better. By better I mean, how could I make this code cleaner or neater? How could I make the script more effective?
Here is the code:

Write-Output("Beginning script....")

#File path of file to be cleaned
$File_Path = "C:UsersAdministratorDownloadsTesting*"

#Location of ZIP file
$Send_To = "C:UsersAdministratorDocumentsARCHIVE2"

#Location of old files before being zipped
$Old_Files = "C:UsersAdministratorDocumentsOLD_FILES"

#Time frame for files
$Days = "-65"
$now = Get-Date
$last_Write = $now.AddDays($Days)

#Filtering files according to time parameters
$Filter = Get-ChildItem -Path $File_Path | Where-Object $_.LastWriteTime -lt $last_Write 

#Moving old files to destination folder
if (!$Filter)
 Write-Host "Variable is null"

else
 Move-Item $Filter -Destination $Old_Files
 Write-Output("Moving files....")




#Compressing destination folder if there is folders in $Old_Files folder
if (!(Test-Path $Old_Files)) 
 Write-Output("No old files found")

else
 Compress-Archive -Path $Old_Files -DestinationPath $Send_To -Update
 Write-Output("Old files zipped!")
 Remove-Item -Path $Old_Files -Force


Write-Output("Script is finished")

file-system powershell

share

asked 7 mins ago

techguy1029techguy1029

11

New contributor

techguy1029 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

add a comment | 

0

$begingroup$

I have a script for zipping up old files. I know using Windows Compression isn't ideal, so I will make the script run using 7-Zip later on. For now though, I just want see how I can make my current script better. By better I mean, how could I make this code cleaner or neater? How could I make the script more effective?
Here is the code:

Write-Output("Beginning script....")

#File path of file to be cleaned
$File_Path = "C:UsersAdministratorDownloadsTesting*"

#Location of ZIP file
$Send_To = "C:UsersAdministratorDocumentsARCHIVE2"

#Location of old files before being zipped
$Old_Files = "C:UsersAdministratorDocumentsOLD_FILES"

#Time frame for files
$Days = "-65"
$now = Get-Date
$last_Write = $now.AddDays($Days)

#Filtering files according to time parameters
$Filter = Get-ChildItem -Path $File_Path | Where-Object $_.LastWriteTime -lt $last_Write 

#Moving old files to destination folder
if (!$Filter)
 Write-Host "Variable is null"

else
 Move-Item $Filter -Destination $Old_Files
 Write-Output("Moving files....")




#Compressing destination folder if there is folders in $Old_Files folder
if (!(Test-Path $Old_Files)) 
 Write-Output("No old files found")

else
 Compress-Archive -Path $Old_Files -DestinationPath $Send_To -Update
 Write-Output("Old files zipped!")
 Remove-Item -Path $Old_Files -Force


Write-Output("Script is finished")

file-system powershell

share

asked 7 mins ago

techguy1029techguy1029

11

New contributor

techguy1029 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

add a comment | 

$begingroup$

I have a script for zipping up old files. I know using Windows Compression isn't ideal, so I will make the script run using 7-Zip later on. For now though, I just want see how I can make my current script better. By better I mean, how could I make this code cleaner or neater? How could I make the script more effective?
Here is the code:

Write-Output("Beginning script....")

#File path of file to be cleaned
$File_Path = "C:UsersAdministratorDownloadsTesting*"

#Location of ZIP file
$Send_To = "C:UsersAdministratorDocumentsARCHIVE2"

#Location of old files before being zipped
$Old_Files = "C:UsersAdministratorDocumentsOLD_FILES"

#Time frame for files
$Days = "-65"
$now = Get-Date
$last_Write = $now.AddDays($Days)

#Filtering files according to time parameters
$Filter = Get-ChildItem -Path $File_Path | Where-Object $_.LastWriteTime -lt $last_Write 

#Moving old files to destination folder
if (!$Filter)
 Write-Host "Variable is null"

else
 Move-Item $Filter -Destination $Old_Files
 Write-Output("Moving files....")




#Compressing destination folder if there is folders in $Old_Files folder
if (!(Test-Path $Old_Files)) 
 Write-Output("No old files found")

else
 Compress-Archive -Path $Old_Files -DestinationPath $Send_To -Update
 Write-Output("Old files zipped!")
 Remove-Item -Path $Old_Files -Force


Write-Output("Script is finished")

file-system powershell

share

asked 7 mins ago

techguy1029techguy1029

11

New contributor

techguy1029 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

Write-Output("Beginning script....")

#File path of file to be cleaned
$File_Path = "C:UsersAdministratorDownloadsTesting*"

#Location of ZIP file
$Send_To = "C:UsersAdministratorDocumentsARCHIVE2"

#Location of old files before being zipped
$Old_Files = "C:UsersAdministratorDocumentsOLD_FILES"

#Time frame for files
$Days = "-65"
$now = Get-Date
$last_Write = $now.AddDays($Days)

#Filtering files according to time parameters
$Filter = Get-ChildItem -Path $File_Path | Where-Object $_.LastWriteTime -lt $last_Write 

#Moving old files to destination folder
if (!$Filter)
 Write-Host "Variable is null"

else
 Move-Item $Filter -Destination $Old_Files
 Write-Output("Moving files....")




#Compressing destination folder if there is folders in $Old_Files folder
if (!(Test-Path $Old_Files)) 
 Write-Output("No old files found")

else
 Compress-Archive -Path $Old_Files -DestinationPath $Send_To -Update
 Write-Output("Old files zipped!")
 Remove-Item -Path $Old_Files -Force


Write-Output("Script is finished")

share

asked 7 mins ago

techguy1029techguy1029

11

New contributor

techguy1029 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share

asked 7 mins ago

techguy1029techguy1029

11

New contributor

techguy1029 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 7 mins ago

techguy1029techguy1029

11

New contributor

techguy1029 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 7 mins ago

techguy1029techguy1029

11