Verify two numbers from a list will add up to a number in the same list using Python The Next CEO of Stack OverflowPrime factorization of a numberGenerator to Tuple to List?Calculating parsimonies using Python; performance is lackingDynamic Programming for printing additive numbers up to digits nProject Euler: #36 Binary and Base 10 PalindromesFinding all divisors of an integerGenerate set of random numbers and remove lowestFind two distinct subsets of a list that add up to the same valueFirstDuplicate FinderSearch father (x) of the number D(x) and measure time and memory consumed

How dangerous is XSS

Why do we say “un seul M” and not “une seule M” even though M is a “consonne”?

Could a dragon use its wings to swim?

Identify and count spells (Distinctive events within each group)

Another proof that dividing by 0 does not exist -- is it right?

Shortening a title without changing its meaning

Is it possible to make a 9x9 table fit within the default margins?

Read/write a pipe-delimited file line by line with some simple text manipulation

Find the majority element, which appears more than half the time

My ex-girlfriend uses my Apple ID to login to her iPad, do I have to give her my Apple ID password to reset it?

Do I need to write [sic] when including a quotation with a number less than 10 that isn't written out?

Why was Sir Cadogan fired?

Why does the freezing point matter when picking cooler ice packs?

What is the difference between 'contrib' and 'non-free' packages repositories?

Is it okay to majorly distort historical facts while writing a fiction story?

How did scripture get the name bible?

Are British MPs missing the point, with these 'Indicative Votes'?

Is it a bad idea to plug the other end of ESD strap to wall ground?

logical reads on global temp table, but not on session-level temp table

Traveling with my 5 year old daughter (as the father) without the mother from Germany to Mexico

MT "will strike" & LXX "will watch carefully" (Gen 3:15)?

Oldie but Goldie

What is a typical Mizrachi Seder like?

How can I prove that a state of equilibrium is unstable?



Verify two numbers from a list will add up to a number in the same list using Python



The Next CEO of Stack OverflowPrime factorization of a numberGenerator to Tuple to List?Calculating parsimonies using Python; performance is lackingDynamic Programming for printing additive numbers up to digits nProject Euler: #36 Binary and Base 10 PalindromesFinding all divisors of an integerGenerate set of random numbers and remove lowestFind two distinct subsets of a list that add up to the same valueFirstDuplicate FinderSearch father (x) of the number D(x) and measure time and memory consumed










0












$begingroup$


I am trying to solve this question:



  • Given a list of integers, verifies if any two numbers from this list add up to another number in the same list.

I came up with:



def func(l):
sum_set = set() # using a set to store sums of two numbers.
for index in range(len(l)-1):
counter = 1
while counter + index < len(l):
sum = l[index] + l[index+counter]
sum_set.add(sum)
counter += 1
for number in l:
if number in sum_set:
return True
return False

print(func([1,2,3,4]))
print(func([1,2,1,4]))
print(func([1,1,1]))
print(func([1]))
print(func([1,2,5,9]))
print(func([2,1,1]))
print(func([1,-1,0]))


From the tests I ran above, my function is working. But there is at least one way I can think of my approach is lacking of:



  • I should filter the original list to get rid of duplicate numbers. If a number appears more than 2 times, its rest of appearance should be disregarded. E.g. l = [1,1,1,1,2] should be optimised to l = [1,1,2]

Is there any other aspect that I can improve my code snippet on to make it more Pythonic / more efficient?









share









$endgroup$
















    0












    $begingroup$


    I am trying to solve this question:



    • Given a list of integers, verifies if any two numbers from this list add up to another number in the same list.

    I came up with:



    def func(l):
    sum_set = set() # using a set to store sums of two numbers.
    for index in range(len(l)-1):
    counter = 1
    while counter + index < len(l):
    sum = l[index] + l[index+counter]
    sum_set.add(sum)
    counter += 1
    for number in l:
    if number in sum_set:
    return True
    return False

    print(func([1,2,3,4]))
    print(func([1,2,1,4]))
    print(func([1,1,1]))
    print(func([1]))
    print(func([1,2,5,9]))
    print(func([2,1,1]))
    print(func([1,-1,0]))


    From the tests I ran above, my function is working. But there is at least one way I can think of my approach is lacking of:



    • I should filter the original list to get rid of duplicate numbers. If a number appears more than 2 times, its rest of appearance should be disregarded. E.g. l = [1,1,1,1,2] should be optimised to l = [1,1,2]

    Is there any other aspect that I can improve my code snippet on to make it more Pythonic / more efficient?









    share









    $endgroup$














      0












      0








      0





      $begingroup$


      I am trying to solve this question:



      • Given a list of integers, verifies if any two numbers from this list add up to another number in the same list.

      I came up with:



      def func(l):
      sum_set = set() # using a set to store sums of two numbers.
      for index in range(len(l)-1):
      counter = 1
      while counter + index < len(l):
      sum = l[index] + l[index+counter]
      sum_set.add(sum)
      counter += 1
      for number in l:
      if number in sum_set:
      return True
      return False

      print(func([1,2,3,4]))
      print(func([1,2,1,4]))
      print(func([1,1,1]))
      print(func([1]))
      print(func([1,2,5,9]))
      print(func([2,1,1]))
      print(func([1,-1,0]))


      From the tests I ran above, my function is working. But there is at least one way I can think of my approach is lacking of:



      • I should filter the original list to get rid of duplicate numbers. If a number appears more than 2 times, its rest of appearance should be disregarded. E.g. l = [1,1,1,1,2] should be optimised to l = [1,1,2]

      Is there any other aspect that I can improve my code snippet on to make it more Pythonic / more efficient?









      share









      $endgroup$




      I am trying to solve this question:



      • Given a list of integers, verifies if any two numbers from this list add up to another number in the same list.

      I came up with:



      def func(l):
      sum_set = set() # using a set to store sums of two numbers.
      for index in range(len(l)-1):
      counter = 1
      while counter + index < len(l):
      sum = l[index] + l[index+counter]
      sum_set.add(sum)
      counter += 1
      for number in l:
      if number in sum_set:
      return True
      return False

      print(func([1,2,3,4]))
      print(func([1,2,1,4]))
      print(func([1,1,1]))
      print(func([1]))
      print(func([1,2,5,9]))
      print(func([2,1,1]))
      print(func([1,-1,0]))


      From the tests I ran above, my function is working. But there is at least one way I can think of my approach is lacking of:



      • I should filter the original list to get rid of duplicate numbers. If a number appears more than 2 times, its rest of appearance should be disregarded. E.g. l = [1,1,1,1,2] should be optimised to l = [1,1,2]

      Is there any other aspect that I can improve my code snippet on to make it more Pythonic / more efficient?







      python





      share












      share










      share



      share










      asked 3 mins ago









      Yu ZhangYu Zhang

      302312




      302312




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );













          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216696%2fverify-two-numbers-from-a-list-will-add-up-to-a-number-in-the-same-list-using-py%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes















          draft saved

          draft discarded
















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216696%2fverify-two-numbers-from-a-list-will-add-up-to-a-number-in-the-same-list-using-py%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          瀋陽號驅逐艦 目录 接收與服役 配置反潛直升機 武進三型性能升級 歷史 除役 參考資料 外部連結 导航菜单Taiwan Air Power海疆老兵-陽字號驅逐艦沿革World Navies Today: Taiwan (Republic of China)DD-839 USS POWER

          波兰旗帜列表 目录 国旗 军旗 其他制服部门旗帜 特别国家机构船只 参考文献 外部链接 导航菜单Polskie flagi, chorągwie, bandery... [波兰旗帜、条幅、船旗等]原始内容Ustawa z dnia 31 stycznia 1980 r. o godle, barwach i hymnie Rzeczypospolitej Polskiej oraz o pieczęciach państwowychZarządzenie Ministra Obrony Narodowej z dnia 14 grudnia 2005 r. zmieniające zarządzenie w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejZarządzenie Ministra Obrony Narodowej z dnia 29 stycznia 1996 r. w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejUstawa z dnia 19 lutego 1993 r. o znakach Sił Zbrojnych Rzeczypospolitej PolskiejHistoria Marynarki Wojennej RP [波兰海军史]Rozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 12 kwietnia 2002 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych Straży GranicznejRozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 18 kwietnia 2005 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych PolicjiRozporządzenie Ministra Infrastruktury z dnia 21 października 2005 r. w sprawie wzorów flag dla statków morskich na oznaczenie pełnionej specjalnej służby państwowej oraz okoliczności i warunków ich podnoszenia波兰旗帜波兰

          Indenting and Dedenting ASP code with Python