make arcpy script quicker Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?
preposition before coffee
One-one communication
Is there any word for a place full of confusion?
Is the IBM 5153 color display compatible with the Tandy 1000 16 color modes?
How do living politicians protect their readily obtainable signatures from misuse?
What does 丫 mean? 丫是什么意思?
Is CEO the "profession" with the most psychopaths?
How long can equipment go unused before powering up runs the risk of damage?
Co-worker has annoying ringtone
Why are my pictures showing a dark band on one edge?
What do you call the main part of a joke?
What is an "asse" in Elizabethan English?
Are sorcerers unable to use the Careful Spell metamagic option on themselves?
macOS: Name for app shortcut screen found by pinching with thumb and three fingers
Why weren't discrete x86 CPUs ever used in game hardware?
What would you call this weird metallic apparatus that allows you to lift people?
What is the meaning of 'breadth' in breadth first search?
How were pictures turned from film to a big picture in a picture frame before digital scanning?
Significance of Cersei's obsession with elephants?
Karn the great creator - 'card from outside the game' in sealed
Semigroups with no morphisms between them
If Windows 7 doesn't support WSL, then what is "Subsystem for UNIX-based Applications"?
What to do with repeated rejections for phd position
Dynamic filling of a region of a polar plot
make arcpy script quicker
Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)
Announcing the arrival of Valued Associate #679: Cesar Manara
Unicorn Meta Zoo #1: Why another podcast?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
The script below is used to update a shp which is missing values from another .shp using a spatial reference. It's taking about 19 minutes to run through ~53,000 rows. Any ideas on how I can make it quicker?
enter code here
import arc module and datetime
import arcpy, datetime
# Get start time
start = datetime.datetime.now()
#Create an error class
class NoExist(Exception):
pass
#Get Dataset locations (need to turn this into a toolbox)
dataSetFolder = arcpy.GetParameterAsText(0)
propertyDataset = arcpy.GetParameterAsText(1)
suburbsDataset = arcpy.GetParameterAsText(2)
#Test locations exist
try:
if not arcpy.Exists(dataSetFolder):
raise NoExist
elif not arcpy.Exists(propertyDataset):
raise NoExist
elif not arcpy.Exists(suburbsDataset):
raise NoExist
arcpy.env.workspace = dataSetFolder
# if data doesnt exist display error message
except NoExist:
print "No data available"
arcpy.AddMessage("No data available")
# construct variable list
fc_p = propertyDataset
fc_s = suburbsDataset
fields = arcpy.ListFields(fc_p)
LOCALITYList = []
# build query (blank string) and assign fields to variables
query = '"LOCALITY" = '''
field_p = ['FID','LOCALITY']
field_s = ['FID', 'ADMINAREA']
# Make feature layers of each of the files
arcpy.MakeFeatureLayer_management(fc_s,'suburbs_lyr')
arcpy.MakeFeatureLayer_management(fc_p,'properties_lyr')
# use update cursor to identify properties without associated locality
with arcpy.da.UpdateCursor('properties_lyr', field_p,query) as Urows:
for Urow in Urows:
# second query for FID while using cursor through rows
query2 = '"FID" = ' + str(Urow[0])
# make a temp layer with the results and then select properties which
are contained in suburbs layer
arcpy.MakeFeatureLayer_management(fc_p,'Temp_properties_lyr', query2)
arcpy.SelectLayerByLocation_management('suburbs_lyr', "CONTAINS",
'Temp_properties_lyr')
# Search cursor to scroll through suburbs
for Srow in arcpy.da.SearchCursor('suburbs_lyr',field_s):
#variable to record result of ADMINAREA in search cursor
Suburb = Srow[1]
# set value of temp properties layer LOCALITY to Suburbs ADMINAREA
Urow[1] = Suburb
print Urow
# continue through rows
Urows.updateRow(Urow)
# place reults into list
LOCALITYList.append(Suburb)
# delete temp properties layer
arcpy.Delete_management('Temp_properties_lyr')
#Delete cursors
del Urows
python arcpy
New contributor
$endgroup$
add a comment |
$begingroup$
The script below is used to update a shp which is missing values from another .shp using a spatial reference. It's taking about 19 minutes to run through ~53,000 rows. Any ideas on how I can make it quicker?
enter code here
import arc module and datetime
import arcpy, datetime
# Get start time
start = datetime.datetime.now()
#Create an error class
class NoExist(Exception):
pass
#Get Dataset locations (need to turn this into a toolbox)
dataSetFolder = arcpy.GetParameterAsText(0)
propertyDataset = arcpy.GetParameterAsText(1)
suburbsDataset = arcpy.GetParameterAsText(2)
#Test locations exist
try:
if not arcpy.Exists(dataSetFolder):
raise NoExist
elif not arcpy.Exists(propertyDataset):
raise NoExist
elif not arcpy.Exists(suburbsDataset):
raise NoExist
arcpy.env.workspace = dataSetFolder
# if data doesnt exist display error message
except NoExist:
print "No data available"
arcpy.AddMessage("No data available")
# construct variable list
fc_p = propertyDataset
fc_s = suburbsDataset
fields = arcpy.ListFields(fc_p)
LOCALITYList = []
# build query (blank string) and assign fields to variables
query = '"LOCALITY" = '''
field_p = ['FID','LOCALITY']
field_s = ['FID', 'ADMINAREA']
# Make feature layers of each of the files
arcpy.MakeFeatureLayer_management(fc_s,'suburbs_lyr')
arcpy.MakeFeatureLayer_management(fc_p,'properties_lyr')
# use update cursor to identify properties without associated locality
with arcpy.da.UpdateCursor('properties_lyr', field_p,query) as Urows:
for Urow in Urows:
# second query for FID while using cursor through rows
query2 = '"FID" = ' + str(Urow[0])
# make a temp layer with the results and then select properties which
are contained in suburbs layer
arcpy.MakeFeatureLayer_management(fc_p,'Temp_properties_lyr', query2)
arcpy.SelectLayerByLocation_management('suburbs_lyr', "CONTAINS",
'Temp_properties_lyr')
# Search cursor to scroll through suburbs
for Srow in arcpy.da.SearchCursor('suburbs_lyr',field_s):
#variable to record result of ADMINAREA in search cursor
Suburb = Srow[1]
# set value of temp properties layer LOCALITY to Suburbs ADMINAREA
Urow[1] = Suburb
print Urow
# continue through rows
Urows.updateRow(Urow)
# place reults into list
LOCALITYList.append(Suburb)
# delete temp properties layer
arcpy.Delete_management('Temp_properties_lyr')
#Delete cursors
del Urows
python arcpy
New contributor
$endgroup$
add a comment |
$begingroup$
The script below is used to update a shp which is missing values from another .shp using a spatial reference. It's taking about 19 minutes to run through ~53,000 rows. Any ideas on how I can make it quicker?
enter code here
import arc module and datetime
import arcpy, datetime
# Get start time
start = datetime.datetime.now()
#Create an error class
class NoExist(Exception):
pass
#Get Dataset locations (need to turn this into a toolbox)
dataSetFolder = arcpy.GetParameterAsText(0)
propertyDataset = arcpy.GetParameterAsText(1)
suburbsDataset = arcpy.GetParameterAsText(2)
#Test locations exist
try:
if not arcpy.Exists(dataSetFolder):
raise NoExist
elif not arcpy.Exists(propertyDataset):
raise NoExist
elif not arcpy.Exists(suburbsDataset):
raise NoExist
arcpy.env.workspace = dataSetFolder
# if data doesnt exist display error message
except NoExist:
print "No data available"
arcpy.AddMessage("No data available")
# construct variable list
fc_p = propertyDataset
fc_s = suburbsDataset
fields = arcpy.ListFields(fc_p)
LOCALITYList = []
# build query (blank string) and assign fields to variables
query = '"LOCALITY" = '''
field_p = ['FID','LOCALITY']
field_s = ['FID', 'ADMINAREA']
# Make feature layers of each of the files
arcpy.MakeFeatureLayer_management(fc_s,'suburbs_lyr')
arcpy.MakeFeatureLayer_management(fc_p,'properties_lyr')
# use update cursor to identify properties without associated locality
with arcpy.da.UpdateCursor('properties_lyr', field_p,query) as Urows:
for Urow in Urows:
# second query for FID while using cursor through rows
query2 = '"FID" = ' + str(Urow[0])
# make a temp layer with the results and then select properties which
are contained in suburbs layer
arcpy.MakeFeatureLayer_management(fc_p,'Temp_properties_lyr', query2)
arcpy.SelectLayerByLocation_management('suburbs_lyr', "CONTAINS",
'Temp_properties_lyr')
# Search cursor to scroll through suburbs
for Srow in arcpy.da.SearchCursor('suburbs_lyr',field_s):
#variable to record result of ADMINAREA in search cursor
Suburb = Srow[1]
# set value of temp properties layer LOCALITY to Suburbs ADMINAREA
Urow[1] = Suburb
print Urow
# continue through rows
Urows.updateRow(Urow)
# place reults into list
LOCALITYList.append(Suburb)
# delete temp properties layer
arcpy.Delete_management('Temp_properties_lyr')
#Delete cursors
del Urows
python arcpy
New contributor
$endgroup$
The script below is used to update a shp which is missing values from another .shp using a spatial reference. It's taking about 19 minutes to run through ~53,000 rows. Any ideas on how I can make it quicker?
enter code here
import arc module and datetime
import arcpy, datetime
# Get start time
start = datetime.datetime.now()
#Create an error class
class NoExist(Exception):
pass
#Get Dataset locations (need to turn this into a toolbox)
dataSetFolder = arcpy.GetParameterAsText(0)
propertyDataset = arcpy.GetParameterAsText(1)
suburbsDataset = arcpy.GetParameterAsText(2)
#Test locations exist
try:
if not arcpy.Exists(dataSetFolder):
raise NoExist
elif not arcpy.Exists(propertyDataset):
raise NoExist
elif not arcpy.Exists(suburbsDataset):
raise NoExist
arcpy.env.workspace = dataSetFolder
# if data doesnt exist display error message
except NoExist:
print "No data available"
arcpy.AddMessage("No data available")
# construct variable list
fc_p = propertyDataset
fc_s = suburbsDataset
fields = arcpy.ListFields(fc_p)
LOCALITYList = []
# build query (blank string) and assign fields to variables
query = '"LOCALITY" = '''
field_p = ['FID','LOCALITY']
field_s = ['FID', 'ADMINAREA']
# Make feature layers of each of the files
arcpy.MakeFeatureLayer_management(fc_s,'suburbs_lyr')
arcpy.MakeFeatureLayer_management(fc_p,'properties_lyr')
# use update cursor to identify properties without associated locality
with arcpy.da.UpdateCursor('properties_lyr', field_p,query) as Urows:
for Urow in Urows:
# second query for FID while using cursor through rows
query2 = '"FID" = ' + str(Urow[0])
# make a temp layer with the results and then select properties which
are contained in suburbs layer
arcpy.MakeFeatureLayer_management(fc_p,'Temp_properties_lyr', query2)
arcpy.SelectLayerByLocation_management('suburbs_lyr', "CONTAINS",
'Temp_properties_lyr')
# Search cursor to scroll through suburbs
for Srow in arcpy.da.SearchCursor('suburbs_lyr',field_s):
#variable to record result of ADMINAREA in search cursor
Suburb = Srow[1]
# set value of temp properties layer LOCALITY to Suburbs ADMINAREA
Urow[1] = Suburb
print Urow
# continue through rows
Urows.updateRow(Urow)
# place reults into list
LOCALITYList.append(Suburb)
# delete temp properties layer
arcpy.Delete_management('Temp_properties_lyr')
#Delete cursors
del Urows
python arcpy
python arcpy
New contributor
New contributor
New contributor
asked 2 mins ago
BrettBrett
1
1
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Brett is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217768%2fmake-arcpy-script-quicker%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Brett is a new contributor. Be nice, and check out our Code of Conduct.
Brett is a new contributor. Be nice, and check out our Code of Conduct.
Brett is a new contributor. Be nice, and check out our Code of Conduct.
Brett is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217768%2fmake-arcpy-script-quicker%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown