If a method is doing something and also returning the success, what kind of a name should be chosen?Finding potential thread safety issues and race conditions in my multithreading codeParsing log files of HearthStone: The log reading APIMulti-player game server accessing and querying MongoDBRetrieving data from cursor associated with a list item inside an anonymous listener method declarationWhat kind of Wall should it be? (for an RPG)Clone linked structure with random pointerConvert MQTT messages and publish them to Rabbit MQFinding a repeated pattern and doing something with the matchPHP MySQLi wrapper classJava Pi Calculation using an Averaged-Leibniz formula
What is the difference between lands and mana?
How to convince somebody that he is fit for something else, but not this job?
Giving feedback to someone without sounding prejudiced
How can I write humor as character trait?
How do I fix the group tension caused by my character stealing and possibly killing without provocation?
C++ copy constructor called at return
Has the laser at Magurele, Romania reached a tenth of the Sun's power?
How could a planet have erratic days?
Strong empirical falsification of quantum mechanics based on vacuum energy density?
What is the English pronunciation of "pain au chocolat"?
How to create a paid keyvalue store
Doesn't the system of the Supreme Court oppose justice?
What does Apple's new App Store requirement mean
Which Article Helped Get Rid of Technobabble in RPGs?
Shouldn’t conservatives embrace universal basic income?
What fields between the rationals and the reals allow a good notion of 2D distance?
Quoting Keynes in a lecture
What's the name of the logical fallacy where a debater extends a statement far beyond the original statement to make it true?
Pre-mixing cryogenic fuels and using only one fuel tank
Is it allowed to activate the ability of multiple planeswalkers in a single turn?
How do you make your own symbol when Detexify fails?
Is this toilet slogan correct usage of the English language?
A variation to the phrase "hanging over my shoulders"
Were Persian-Median kings illiterate?
If a method is doing something and also returning the success, what kind of a name should be chosen?
Finding potential thread safety issues and race conditions in my multithreading codeParsing log files of HearthStone: The log reading APIMulti-player game server accessing and querying MongoDBRetrieving data from cursor associated with a list item inside an anonymous listener method declarationWhat kind of Wall should it be? (for an RPG)Clone linked structure with random pointerConvert MQTT messages and publish them to Rabbit MQFinding a repeated pattern and doing something with the matchPHP MySQLi wrapper classJava Pi Calculation using an Averaged-Leibniz formula
$begingroup$
This is the part of an Automated Testing framework.
Objective: Randomly select an option from a table to delete.
Pseudo code:
//Here standardToolbarOptions : is the list of options from which an option should be randomly selected
private String removeRandomOption(ArrayList<String> standardToolbarOptions)
String optionToBeRemoved = "";
try
//Log message that the method is being attempted
//Selects a random option from the table. The option should already be available as 'Visible' in the current Standard toolbar
optionToBeRemoved = getRandomlySelectedOption(standardToolbarOptions);
//Click delete
//Click Ok
catch(Exception e)
//Log the message to an output file
Here's the getRandomlySelectedOption code which is doing some stuff and returning the name of the selected option as a String
private String getRandomlySelectedOption(ArrayList<String> visibleToolBarOptions)
String selectedItemText = "";
while(some condition)
//Do stuff
selectedItemText = trimStringWithLibraryMethod
return selectedItemText
What are the most glaring mistakes in this pseudocode related to naming in particular? Where are the rooms for improvement? Suggestions with examples would be a great tool for my learning.
While this is open for review. I have a question. I have always got code review comments related to how I name my methods. So that's one of the primary areas I am trying to improve. Apart from the fact that I am trying to improve overall.
java object-oriented integration-testing
New contributor
$endgroup$
add a comment |
$begingroup$
This is the part of an Automated Testing framework.
Objective: Randomly select an option from a table to delete.
Pseudo code:
//Here standardToolbarOptions : is the list of options from which an option should be randomly selected
private String removeRandomOption(ArrayList<String> standardToolbarOptions)
String optionToBeRemoved = "";
try
//Log message that the method is being attempted
//Selects a random option from the table. The option should already be available as 'Visible' in the current Standard toolbar
optionToBeRemoved = getRandomlySelectedOption(standardToolbarOptions);
//Click delete
//Click Ok
catch(Exception e)
//Log the message to an output file
Here's the getRandomlySelectedOption code which is doing some stuff and returning the name of the selected option as a String
private String getRandomlySelectedOption(ArrayList<String> visibleToolBarOptions)
String selectedItemText = "";
while(some condition)
//Do stuff
selectedItemText = trimStringWithLibraryMethod
return selectedItemText
What are the most glaring mistakes in this pseudocode related to naming in particular? Where are the rooms for improvement? Suggestions with examples would be a great tool for my learning.
While this is open for review. I have a question. I have always got code review comments related to how I name my methods. So that's one of the primary areas I am trying to improve. Apart from the fact that I am trying to improve overall.
java object-oriented integration-testing
New contributor
$endgroup$
add a comment |
$begingroup$
This is the part of an Automated Testing framework.
Objective: Randomly select an option from a table to delete.
Pseudo code:
//Here standardToolbarOptions : is the list of options from which an option should be randomly selected
private String removeRandomOption(ArrayList<String> standardToolbarOptions)
String optionToBeRemoved = "";
try
//Log message that the method is being attempted
//Selects a random option from the table. The option should already be available as 'Visible' in the current Standard toolbar
optionToBeRemoved = getRandomlySelectedOption(standardToolbarOptions);
//Click delete
//Click Ok
catch(Exception e)
//Log the message to an output file
Here's the getRandomlySelectedOption code which is doing some stuff and returning the name of the selected option as a String
private String getRandomlySelectedOption(ArrayList<String> visibleToolBarOptions)
String selectedItemText = "";
while(some condition)
//Do stuff
selectedItemText = trimStringWithLibraryMethod
return selectedItemText
What are the most glaring mistakes in this pseudocode related to naming in particular? Where are the rooms for improvement? Suggestions with examples would be a great tool for my learning.
While this is open for review. I have a question. I have always got code review comments related to how I name my methods. So that's one of the primary areas I am trying to improve. Apart from the fact that I am trying to improve overall.
java object-oriented integration-testing
New contributor
$endgroup$
This is the part of an Automated Testing framework.
Objective: Randomly select an option from a table to delete.
Pseudo code:
//Here standardToolbarOptions : is the list of options from which an option should be randomly selected
private String removeRandomOption(ArrayList<String> standardToolbarOptions)
String optionToBeRemoved = "";
try
//Log message that the method is being attempted
//Selects a random option from the table. The option should already be available as 'Visible' in the current Standard toolbar
optionToBeRemoved = getRandomlySelectedOption(standardToolbarOptions);
//Click delete
//Click Ok
catch(Exception e)
//Log the message to an output file
Here's the getRandomlySelectedOption code which is doing some stuff and returning the name of the selected option as a String
private String getRandomlySelectedOption(ArrayList<String> visibleToolBarOptions)
String selectedItemText = "";
while(some condition)
//Do stuff
selectedItemText = trimStringWithLibraryMethod
return selectedItemText
What are the most glaring mistakes in this pseudocode related to naming in particular? Where are the rooms for improvement? Suggestions with examples would be a great tool for my learning.
While this is open for review. I have a question. I have always got code review comments related to how I name my methods. So that's one of the primary areas I am trying to improve. Apart from the fact that I am trying to improve overall.
java object-oriented integration-testing
java object-oriented integration-testing
New contributor
New contributor
New contributor
asked 10 mins ago
SteroidKing666SteroidKing666
101
101
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
SteroidKing666 is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215980%2fif-a-method-is-doing-something-and-also-returning-the-success-what-kind-of-a-na%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
SteroidKing666 is a new contributor. Be nice, and check out our Code of Conduct.
SteroidKing666 is a new contributor. Be nice, and check out our Code of Conduct.
SteroidKing666 is a new contributor. Be nice, and check out our Code of Conduct.
SteroidKing666 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215980%2fif-a-method-is-doing-something-and-also-returning-the-success-what-kind-of-a-na%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown