Searching for combinations of words and numbers The Next CEO of Stack OverflowActiveRecord model for upvotes and downvotesActiveRecord object for billing and shipping addressesSearching for words in a dictionarySearching over more models railsSearching has_and_belongs_to_many relations for article categoriesGet distinct combinations of numbersShowing a table for open and closed ticketsSearching for something at a locationPutting numbers into wordsSkip invalid record and avoid execution break for invalid record
Recycling old answers
Some questions about different axiomatic systems for neighbourhoods
WOW air has ceased operation, can I get my tickets refunded?
How to invert MapIndexed on a ragged structure? How to construct a tree from rules?
Bartok - Syncopation (1): Meaning of notes in between Grand Staff
RigExpert AA-35 - Interpreting The Information
Math-accent symbol over parentheses enclosing accented symbol (amsmath)
Make solar eclipses exceedingly rare, but still have new moons
Reference request: Grassmannian and Plucker coordinates in type B, C, D
Is it okay to majorly distort historical facts while writing a fiction story?
Newlines in BSD sed vs gsed
Proper way to express "He disappeared them"
Why does standard notation not preserve intervals (visually)
Won the lottery - how do I keep the money?
The exact meaning of 'Mom made me a sandwich'
What steps are necessary to read a Modern SSD in Medieval Europe?
Beveled cylinder cutout
is it ok to reduce charging current for li ion 18650 battery?
Why did CATV standarize in 75 ohms and everyone else in 50?
Does soap repel water?
Is it possible to replace duplicates of a character with one character using tr
How many extra stops do monopods offer for tele photographs?
Received an invoice from my ex-employer billing me for training; how to handle?
Why don't programming languages automatically manage the synchronous/asynchronous problem?
Searching for combinations of words and numbers
The Next CEO of Stack OverflowActiveRecord model for upvotes and downvotesActiveRecord object for billing and shipping addressesSearching for words in a dictionarySearching over more models railsSearching has_and_belongs_to_many relations for article categoriesGet distinct combinations of numbersShowing a table for open and closed ticketsSearching for something at a locationPutting numbers into wordsSkip invalid record and avoid execution break for invalid record
$begingroup$
My model called Customer contains a method called generate_fields which creates records based on its return values.
def generate_fields
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
kind: word,
value: content
end.compact
end.flatten
end
#[
# kind: "S", value: "BRL" ,
# kind: "M", value: "AUS" ,
# kind: "L", value: "PER" ,
#]
The methods words and numbers are private and return an array of strings. Their implementation is not relevant to this discussion. generate_fields returns an array of hashes which is used to create multiple customers at the database.
Customer.create(generate_fields)
The problem is compact and flatten create a new array for every time they are called as pointed out by @David Aldridge. How can this function be rewritten to avoid excessive array creation? Thanks in advance.
performance ruby ruby-on-rails
edited 5 mins ago
200_success
130k17156420
asked 17 hours ago
tmmgarciatmmgarcia
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
My model called Customer contains a method called generate_fields which creates records based on its return values.
def generate_fields
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
kind: word,
value: content
end.compact
end.flatten
end
#[
# kind: "S", value: "BRL" ,
# kind: "M", value: "AUS" ,
# kind: "L", value: "PER" ,
#]
The methods words and numbers are private and return an array of strings. Their implementation is not relevant to this discussion. generate_fields returns an array of hashes which is used to create multiple customers at the database.
Customer.create(generate_fields)
The problem is compact and flatten create a new array for every time they are called as pointed out by @David Aldridge. How can this function be rewritten to avoid excessive array creation? Thanks in advance.
performance ruby ruby-on-rails
edited 5 mins ago
200_success
130k17156420
asked 17 hours ago
tmmgarciatmmgarcia
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
$begingroup$
Welcome to Code Review. As you have currently framed the question, you seem to be asking about a specific practice, with two hypothetical code snippets included merely as an example. To make this question on-topic, please state what task the code accomplishes, and retitle the question accordingly, so that we are reviewing real concrete code from a project. See How to Ask.
$endgroup$
– 200_success
17 hours ago
$begingroup$
@200_success thanks for pointing me out in the right direction. I've changed the question and I believe now it's closer to this community guidelines.
$endgroup$
– tmmgarcia
10 mins ago
add a comment |
$begingroup$
My model called Customer contains a method called generate_fields which creates records based on its return values.
def generate_fields
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
kind: word,
value: content
end.compact
end.flatten
end
#[
# kind: "S", value: "BRL" ,
# kind: "M", value: "AUS" ,
# kind: "L", value: "PER" ,
#]
The methods words and numbers are private and return an array of strings. Their implementation is not relevant to this discussion. generate_fields returns an array of hashes which is used to create multiple customers at the database.
Customer.create(generate_fields)
The problem is compact and flatten create a new array for every time they are called as pointed out by @David Aldridge. How can this function be rewritten to avoid excessive array creation? Thanks in advance.
performance ruby ruby-on-rails
edited 5 mins ago
200_success
130k17156420
asked 17 hours ago
tmmgarciatmmgarcia
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
My model called Customer contains a method called generate_fields which creates records based on its return values.
def generate_fields
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
kind: word,
value: content
end.compact
end.flatten
end
#[
# kind: "S", value: "BRL" ,
# kind: "M", value: "AUS" ,
# kind: "L", value: "PER" ,
#]
The methods words and numbers are private and return an array of strings. Their implementation is not relevant to this discussion. generate_fields returns an array of hashes which is used to create multiple customers at the database.
Customer.create(generate_fields)
The problem is compact and flatten create a new array for every time they are called as pointed out by @David Aldridge. How can this function be rewritten to avoid excessive array creation? Thanks in advance.
performance ruby ruby-on-rails
performance ruby ruby-on-rails
edited 5 mins ago
200_success
130k17156420
asked 17 hours ago
tmmgarciatmmgarcia
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 5 mins ago
200_success
130k17156420
asked 17 hours ago
tmmgarciatmmgarcia
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 5 mins ago
200_success
130k17156420
edited 5 mins ago
200_success
130k17156420
edited 5 mins ago
200_success
130k17156420
130k17156420
asked 17 hours ago
tmmgarciatmmgarcia
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 17 hours ago
tmmgarciatmmgarcia
32
asked 17 hours ago
tmmgarciatmmgarcia
32
32
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$begingroup$
Welcome to Code Review. As you have currently framed the question, you seem to be asking about a specific practice, with two hypothetical code snippets included merely as an example. To make this question on-topic, please state what task the code accomplishes, and retitle the question accordingly, so that we are reviewing real concrete code from a project. See How to Ask.
$endgroup$
– 200_success
17 hours ago
$begingroup$
@200_success thanks for pointing me out in the right direction. I've changed the question and I believe now it's closer to this community guidelines.
$endgroup$
– tmmgarcia
10 mins ago
add a comment |
$begingroup$
Welcome to Code Review. As you have currently framed the question, you seem to be asking about a specific practice, with two hypothetical code snippets included merely as an example. To make this question on-topic, please state what task the code accomplishes, and retitle the question accordingly, so that we are reviewing real concrete code from a project. See How to Ask.
$endgroup$
– 200_success
17 hours ago
$begingroup$
@200_success thanks for pointing me out in the right direction. I've changed the question and I believe now it's closer to this community guidelines.
$endgroup$
– tmmgarcia
10 mins ago
$begingroup$
Welcome to Code Review. As you have currently framed the question, you seem to be asking about a specific practice, with two hypothetical code snippets included merely as an example. To make this question on-topic, please state what task the code accomplishes, and retitle the question accordingly, so that we are reviewing real concrete code from a project. See How to Ask.
$endgroup$
– 200_success
17 hours ago
$begingroup$
Welcome to Code Review. As you have currently framed the question, you seem to be asking about a specific practice, with two hypothetical code snippets included merely as an example. To make this question on-topic, please state what task the code accomplishes, and retitle the question accordingly, so that we are reviewing real concrete code from a project. See How to Ask.
$endgroup$
– 200_success
17 hours ago
$begingroup$
@200_success thanks for pointing me out in the right direction. I've changed the question and I believe now it's closer to this community guidelines.
$endgroup$
– tmmgarcia
10 mins ago
$begingroup$
@200_success thanks for pointing me out in the right direction. I've changed the question and I believe now it's closer to this community guidelines.
$endgroup$
– tmmgarcia
10 mins ago
add a comment |
1 Answer
1
active
oldest
votes
$begingroup$
I'm not a fan of the latter because the compact and flatten methods create new arrays.
Here's another variation with two additional style options: use of product to combine the two arrays, and each_with_object:
def generate_fields_3
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.product(numbers).each_with_object([]) do |(word, number), fields|
content = find_content(word, number)
next if content.nil?
fields <<
kind: word,
value: content
end
end
answered 8 hours ago
David AldridgeDavid Aldridge
39018
$endgroup$
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216516%2fsearching-for-combinations-of-words-and-numbers%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
I'm not a fan of the latter because the compact and flatten methods create new arrays.
Here's another variation with two additional style options: use of product to combine the two arrays, and each_with_object:
def generate_fields_3
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.product(numbers).each_with_object([]) do |(word, number), fields|
content = find_content(word, number)
next if content.nil?
fields <<
kind: word,
value: content
end
end
answered 8 hours ago
David AldridgeDavid Aldridge
39018
$endgroup$
add a comment |
$begingroup$
I'm not a fan of the latter because the compact and flatten methods create new arrays.
Here's another variation with two additional style options: use of product to combine the two arrays, and each_with_object:
def generate_fields_3
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.product(numbers).each_with_object([]) do |(word, number), fields|
content = find_content(word, number)
next if content.nil?
fields <<
kind: word,
value: content
end
end
answered 8 hours ago
David AldridgeDavid Aldridge
39018
$endgroup$
add a comment |
$begingroup$
I'm not a fan of the latter because the compact and flatten methods create new arrays.
Here's another variation with two additional style options: use of product to combine the two arrays, and each_with_object:
def generate_fields_3
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.product(numbers).each_with_object([]) do |(word, number), fields|
content = find_content(word, number)
next if content.nil?
fields <<
kind: word,
value: content
end
end
answered 8 hours ago
David AldridgeDavid Aldridge
39018
$endgroup$
I'm not a fan of the latter because the compact and flatten methods create new arrays.
Here's another variation with two additional style options: use of product to combine the two arrays, and each_with_object:
def generate_fields_3
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.product(numbers).each_with_object([]) do |(word, number), fields|
content = find_content(word, number)
next if content.nil?
fields <<
kind: word,
value: content
end
end
answered 8 hours ago
David AldridgeDavid Aldridge
39018
answered 8 hours ago
David AldridgeDavid Aldridge
39018
answered 8 hours ago
David AldridgeDavid Aldridge
39018
answered 8 hours ago
David AldridgeDavid Aldridge
39018
39018
add a comment |
add a comment |
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216516%2fsearching-for-combinations-of-words-and-numbers%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
$begingroup$
Welcome to Code Review. As you have currently framed the question, you seem to be asking about a specific practice, with two hypothetical code snippets included merely as an example. To make this question on-topic, please state what task the code accomplishes, and retitle the question accordingly, so that we are reviewing real concrete code from a project. See How to Ask.
$endgroup$
– 200_success
17 hours ago
$begingroup$
@200_success thanks for pointing me out in the right direction. I've changed the question and I believe now it's closer to this community guidelines.
$endgroup$
– tmmgarcia
10 mins ago