wrapper of subset of auto_ptr API that forwards to unique_ptrboost::any replacement with std::unique_ptr supportunique_ptr usage too unwieldyFunction wrapper like std::function that uses “small buffer” allocationCustom class for a borrowed unique_ptr<T>?DeepPtr: a deep-copying unique_ptr wrapper in C++Thread class that uses std::unique_ptrMy implementation for std::unique_ptrBlocking queue implementation with std::unique_ptrUnique_Ptr Implementationunique_ptr basic implementation for single objects
Why do Radio Buttons not fill the entire outer circle?
How do I lift the insulation blower into the attic?
Does capillary rise violate hydrostatic paradox?
Derivative of an interpolated function
What do the positive and negative (+/-) transmit and receive pins mean on Ethernet cables?
How can an organ that provides biological immortality be unable to regenerate?
What is this high flying aircraft over Pennsylvania?
How can a new country break out from a developed country without war?
Travelling in US for more than 90 days
Capacitor electron flow
What is the purpose of using a decision tree?
Do native speakers use "ultima" and "proxima" frequently in spoken English?
"Oh no!" in Latin
A seasonal riddle
What (if any) is the reason to buy in small local stores?
Are hand made posters acceptable in Academia?
1 John in Luther’s Bibel
Do people actually use the word "kaputt" in conversation?
Friend wants my recommendation but I don't want to give it to him
Why is indicated airspeed rather than ground speed used during the takeoff roll?
How do you justify more code being written by following clean code practices?
Is there a page on which I can view all Sitecore jobs running?
Mortal danger in mid-grade literature
Did I make a mistake by ccing email to boss to others?
wrapper of subset of auto_ptr API that forwards to unique_ptr
boost::any replacement with std::unique_ptr supportunique_ptr usage too unwieldyFunction wrapper like std::function that uses “small buffer” allocationCustom class for a borrowed unique_ptr<T>?DeepPtr: a deep-copying unique_ptr wrapper in C++Thread class that uses std::unique_ptrMy implementation for std::unique_ptrBlocking queue implementation with std::unique_ptrUnique_Ptr Implementationunique_ptr basic implementation for single objects
$begingroup$
I read an interesting old question on the Software Engineering SE about how to transition away from std::auto_ptr
. So I wrote a wrapper around std::unique_ptr
that exposes a subset of std::auto_ptr
's API.
The wrapper's mission in life at runtime is to clean up pointers created with new
when the scope ends regardless of how the scope is exited. Its job at compile time is to make compilation fail as informatively as possible when fake_autoptr
is used in a non-lowest-common-denominator way when the code is compiled as C++11 or later.
The example given in the old question is this. This example is not leveraging many of the things that an autoptr
can do. I think, but am not 100% certain that the autoptr
's job here is just to run delete
when its destructor is called and not to steal resources from other autoptr
s.
// NOT MINE DO NOT REVIEW
Foo* GetFoo()
autoptr<Foo> ptr(new Foo);
// Initialize Foo
ptr->Initialize(...);
// Now configure remaining attributes
ptr->SomeSetting(...);
return ptr.release();
Here is the wrapper I came up with.
#ifndef FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
#define FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED 1
#include <memory>
#include <type_traits>
namespace fake_autoptr_ns
namespace detail
template <class T>
void destroy(T* goner)
delete goner;
template <class T>
class fake_autoptr
public:
std::unique_ptr<T, decltype(&detail::destroy<T>)> uniqptr_;
using my_uniqptr = decltype(uniqptr_);
fake_autoptr() = delete;
~fake_autoptr() = default;
template <class CtorArg>
explicit fake_autoptr(CtorArg something) : uniqptr_(something, detail::destroy<T>)
static_assert(std::is_same<T*, CtorArg>::value, "constructor argument must be T*");
// delete special member functions
explicit fake_autoptr(const fake_autoptr<T>&) = delete;
explicit fake_autoptr(fake_autoptr<T>&&) = delete;
fake_autoptr& operator=(const fake_autoptr<T>&) = delete;
fake_autoptr& operator=(fake_autoptr<T> &&) = delete;
T& operator*() = delete;
T* get() = delete;
const std::unique_ptr<T>& operator->() const
return uniqptr_;
my_uniqptr& operator->()
return uniqptr_;
T* release()
return uniqptr_.release();
const T* release() const = delete;
void reset() = delete;
void reset() const = delete;
;
#endif // FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
This is less interesting, but here's a smoke test to make sure it works
#include "fake_autoptr.hpp"
#include <cstdio>
struct TwoInts
int int1;
int int2;
void print_first_int()
printf("1st %dn", int1);
void print_second_int()
printf("2nd %dn", int2);
;
TwoInts* GetInt()
using namespace fake_autoptr_ns;
fake_autoptr<TwoInts> ptr(new TwoInts3, 7);
ptr->print_first_int();
ptr->print_second_int();
return ptr.release();
int main()
TwoInts *t = GetInt();
delete t;
return 0;
c++11
$endgroup$
add a comment |
$begingroup$
I read an interesting old question on the Software Engineering SE about how to transition away from std::auto_ptr
. So I wrote a wrapper around std::unique_ptr
that exposes a subset of std::auto_ptr
's API.
The wrapper's mission in life at runtime is to clean up pointers created with new
when the scope ends regardless of how the scope is exited. Its job at compile time is to make compilation fail as informatively as possible when fake_autoptr
is used in a non-lowest-common-denominator way when the code is compiled as C++11 or later.
The example given in the old question is this. This example is not leveraging many of the things that an autoptr
can do. I think, but am not 100% certain that the autoptr
's job here is just to run delete
when its destructor is called and not to steal resources from other autoptr
s.
// NOT MINE DO NOT REVIEW
Foo* GetFoo()
autoptr<Foo> ptr(new Foo);
// Initialize Foo
ptr->Initialize(...);
// Now configure remaining attributes
ptr->SomeSetting(...);
return ptr.release();
Here is the wrapper I came up with.
#ifndef FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
#define FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED 1
#include <memory>
#include <type_traits>
namespace fake_autoptr_ns
namespace detail
template <class T>
void destroy(T* goner)
delete goner;
template <class T>
class fake_autoptr
public:
std::unique_ptr<T, decltype(&detail::destroy<T>)> uniqptr_;
using my_uniqptr = decltype(uniqptr_);
fake_autoptr() = delete;
~fake_autoptr() = default;
template <class CtorArg>
explicit fake_autoptr(CtorArg something) : uniqptr_(something, detail::destroy<T>)
static_assert(std::is_same<T*, CtorArg>::value, "constructor argument must be T*");
// delete special member functions
explicit fake_autoptr(const fake_autoptr<T>&) = delete;
explicit fake_autoptr(fake_autoptr<T>&&) = delete;
fake_autoptr& operator=(const fake_autoptr<T>&) = delete;
fake_autoptr& operator=(fake_autoptr<T> &&) = delete;
T& operator*() = delete;
T* get() = delete;
const std::unique_ptr<T>& operator->() const
return uniqptr_;
my_uniqptr& operator->()
return uniqptr_;
T* release()
return uniqptr_.release();
const T* release() const = delete;
void reset() = delete;
void reset() const = delete;
;
#endif // FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
This is less interesting, but here's a smoke test to make sure it works
#include "fake_autoptr.hpp"
#include <cstdio>
struct TwoInts
int int1;
int int2;
void print_first_int()
printf("1st %dn", int1);
void print_second_int()
printf("2nd %dn", int2);
;
TwoInts* GetInt()
using namespace fake_autoptr_ns;
fake_autoptr<TwoInts> ptr(new TwoInts3, 7);
ptr->print_first_int();
ptr->print_second_int();
return ptr.release();
int main()
TwoInts *t = GetInt();
delete t;
return 0;
c++11
$endgroup$
add a comment |
$begingroup$
I read an interesting old question on the Software Engineering SE about how to transition away from std::auto_ptr
. So I wrote a wrapper around std::unique_ptr
that exposes a subset of std::auto_ptr
's API.
The wrapper's mission in life at runtime is to clean up pointers created with new
when the scope ends regardless of how the scope is exited. Its job at compile time is to make compilation fail as informatively as possible when fake_autoptr
is used in a non-lowest-common-denominator way when the code is compiled as C++11 or later.
The example given in the old question is this. This example is not leveraging many of the things that an autoptr
can do. I think, but am not 100% certain that the autoptr
's job here is just to run delete
when its destructor is called and not to steal resources from other autoptr
s.
// NOT MINE DO NOT REVIEW
Foo* GetFoo()
autoptr<Foo> ptr(new Foo);
// Initialize Foo
ptr->Initialize(...);
// Now configure remaining attributes
ptr->SomeSetting(...);
return ptr.release();
Here is the wrapper I came up with.
#ifndef FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
#define FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED 1
#include <memory>
#include <type_traits>
namespace fake_autoptr_ns
namespace detail
template <class T>
void destroy(T* goner)
delete goner;
template <class T>
class fake_autoptr
public:
std::unique_ptr<T, decltype(&detail::destroy<T>)> uniqptr_;
using my_uniqptr = decltype(uniqptr_);
fake_autoptr() = delete;
~fake_autoptr() = default;
template <class CtorArg>
explicit fake_autoptr(CtorArg something) : uniqptr_(something, detail::destroy<T>)
static_assert(std::is_same<T*, CtorArg>::value, "constructor argument must be T*");
// delete special member functions
explicit fake_autoptr(const fake_autoptr<T>&) = delete;
explicit fake_autoptr(fake_autoptr<T>&&) = delete;
fake_autoptr& operator=(const fake_autoptr<T>&) = delete;
fake_autoptr& operator=(fake_autoptr<T> &&) = delete;
T& operator*() = delete;
T* get() = delete;
const std::unique_ptr<T>& operator->() const
return uniqptr_;
my_uniqptr& operator->()
return uniqptr_;
T* release()
return uniqptr_.release();
const T* release() const = delete;
void reset() = delete;
void reset() const = delete;
;
#endif // FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
This is less interesting, but here's a smoke test to make sure it works
#include "fake_autoptr.hpp"
#include <cstdio>
struct TwoInts
int int1;
int int2;
void print_first_int()
printf("1st %dn", int1);
void print_second_int()
printf("2nd %dn", int2);
;
TwoInts* GetInt()
using namespace fake_autoptr_ns;
fake_autoptr<TwoInts> ptr(new TwoInts3, 7);
ptr->print_first_int();
ptr->print_second_int();
return ptr.release();
int main()
TwoInts *t = GetInt();
delete t;
return 0;
c++11
$endgroup$
I read an interesting old question on the Software Engineering SE about how to transition away from std::auto_ptr
. So I wrote a wrapper around std::unique_ptr
that exposes a subset of std::auto_ptr
's API.
The wrapper's mission in life at runtime is to clean up pointers created with new
when the scope ends regardless of how the scope is exited. Its job at compile time is to make compilation fail as informatively as possible when fake_autoptr
is used in a non-lowest-common-denominator way when the code is compiled as C++11 or later.
The example given in the old question is this. This example is not leveraging many of the things that an autoptr
can do. I think, but am not 100% certain that the autoptr
's job here is just to run delete
when its destructor is called and not to steal resources from other autoptr
s.
// NOT MINE DO NOT REVIEW
Foo* GetFoo()
autoptr<Foo> ptr(new Foo);
// Initialize Foo
ptr->Initialize(...);
// Now configure remaining attributes
ptr->SomeSetting(...);
return ptr.release();
Here is the wrapper I came up with.
#ifndef FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
#define FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED 1
#include <memory>
#include <type_traits>
namespace fake_autoptr_ns
namespace detail
template <class T>
void destroy(T* goner)
delete goner;
template <class T>
class fake_autoptr
public:
std::unique_ptr<T, decltype(&detail::destroy<T>)> uniqptr_;
using my_uniqptr = decltype(uniqptr_);
fake_autoptr() = delete;
~fake_autoptr() = default;
template <class CtorArg>
explicit fake_autoptr(CtorArg something) : uniqptr_(something, detail::destroy<T>)
static_assert(std::is_same<T*, CtorArg>::value, "constructor argument must be T*");
// delete special member functions
explicit fake_autoptr(const fake_autoptr<T>&) = delete;
explicit fake_autoptr(fake_autoptr<T>&&) = delete;
fake_autoptr& operator=(const fake_autoptr<T>&) = delete;
fake_autoptr& operator=(fake_autoptr<T> &&) = delete;
T& operator*() = delete;
T* get() = delete;
const std::unique_ptr<T>& operator->() const
return uniqptr_;
my_uniqptr& operator->()
return uniqptr_;
T* release()
return uniqptr_.release();
const T* release() const = delete;
void reset() = delete;
void reset() const = delete;
;
#endif // FAKE_AUTOPTR_FAKE_AUTOPTR_INCLUDED
This is less interesting, but here's a smoke test to make sure it works
#include "fake_autoptr.hpp"
#include <cstdio>
struct TwoInts
int int1;
int int2;
void print_first_int()
printf("1st %dn", int1);
void print_second_int()
printf("2nd %dn", int2);
;
TwoInts* GetInt()
using namespace fake_autoptr_ns;
fake_autoptr<TwoInts> ptr(new TwoInts3, 7);
ptr->print_first_int();
ptr->print_second_int();
return ptr.release();
int main()
TwoInts *t = GetInt();
delete t;
return 0;
c++11
c++11
asked 7 mins ago
Gregory NisbetGregory Nisbet
128111
128111
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215798%2fwrapper-of-subset-of-auto-ptr-api-that-forwards-to-unique-ptr%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215798%2fwrapper-of-subset-of-auto-ptr-api-that-forwards-to-unique-ptr%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown