Is there a way to slim down this JavaScript code? The Next CEO of Stack OverflowSimplifying up/down vote codeIs there a “code less” way to construct this JS loop?Is there a better way of writing this JavaScript, or is it idiomatic?Is there anything can be improved in this JavaScript module?Is there a more succinct way of writing this simple JavaScript loop?Interupt redirect to catch potential newsletter signupSlim down Javascript MomentJS FunctionSimple jQuery plugin that excerpt textIs there a better way to sort this items?Is there a better way to create constants in javascript?

Is it possible to create a QR code using text?

Can I cast Thunderwave and be at the center of its bottom face, but not be affected by it?

Does int main() need a declaration on C++?

Raspberry pi 3 B with Ubuntu 18.04 server arm64: what pi version

Is it reasonable to ask other researchers to send me their previous grant applications?

An elegant way to define a sequence

What day is it again?

Is it correct to say moon starry nights?

How do I secure a TV wall mount?

Why did the Drakh emissary look so blurred in S04:E11 "Lines of Communication"?

Is it okay to majorly distort historical facts while writing a fiction story?

Is it possible to make a 9x9 table fit within the default margins?

What is the difference between 'contrib' and 'non-free' packages repositories?

Cannot restore registry to default in Windows 10?

How to pronounce fünf in 45

May one celebrate April fools day?

Post-doc vs. Assistant Professor choice, but neither ideal

Is a distribution that is normal, but highly skewed, considered Gaussian?

What are the unusually-enlarged wing sections on this P-38 Lightning?

How seriously should I take size and weight limits of hand luggage?

How to implement Comparable so it is consistent with identity-equality

How does a dynamic QR code work?

Small nick on power cord from an electric alarm clock, and copper wiring exposed but intact

Would a grinding machine be a simple and workable propulsion system for an interplanetary spacecraft?



Is there a way to slim down this JavaScript code?



The Next CEO of Stack OverflowSimplifying up/down vote codeIs there a “code less” way to construct this JS loop?Is there a better way of writing this JavaScript, or is it idiomatic?Is there anything can be improved in this JavaScript module?Is there a more succinct way of writing this simple JavaScript loop?Interupt redirect to catch potential newsletter signupSlim down Javascript MomentJS FunctionSimple jQuery plugin that excerpt textIs there a better way to sort this items?Is there a better way to create constants in javascript?










0












$begingroup$


A user wrote an issue asking if inside the bio (or any arbitrary tag), any tagged accounts can be automatically linked like on Github.



I gave them this function:



 <script>
let bio = "The coolest company to work for is @github! There is also @aws and @microsoft.";
let linkedBio = "";
let found = false;
let link = "";
for (let i = 0; i < bio.length; i++)
let currentChar = bio[i];

if (currentChar.startsWith("@"))
link += currentChar;
found = true;
continue // we don't need to look at other chars until next iterations


if (found)
if (/[^A-Za-z0-9]/.test(currentChar)) // we found the end of the link (you can add more special chars to this)
let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
linkedBio += tag + currentChar // we add the special char at the end of the tag so that it actually appears, otherwise it does not
link = "";
found = false;
else
link += currentChar;

else
linkedBio += currentChar;



if (link.length > 0) // means we need to add a link that is the last possible thing without anything after it
let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
linkedBio += tag


document.getElementById("bio").innerHTML = linkedBio
</script>


I was going to use string.split(" "), but then I realized that if I did that I would destroy the specific formatting of the text if I used array.join(" ") after all of the formatting changes.



Ex:
Original: "I work for the coolest companies: @aws, @microsoft, and @apple"



Joined: "I work for the coolest companies: @aws , @microsoft , and @apple"



The commas are messed up.



Is there a way to slim it down and/or simplify it? JS isn't my strongest language.



Thanks!









share







New contributor




Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    A user wrote an issue asking if inside the bio (or any arbitrary tag), any tagged accounts can be automatically linked like on Github.



    I gave them this function:



     <script>
    let bio = "The coolest company to work for is @github! There is also @aws and @microsoft.";
    let linkedBio = "";
    let found = false;
    let link = "";
    for (let i = 0; i < bio.length; i++)
    let currentChar = bio[i];

    if (currentChar.startsWith("@"))
    link += currentChar;
    found = true;
    continue // we don't need to look at other chars until next iterations


    if (found)
    if (/[^A-Za-z0-9]/.test(currentChar)) // we found the end of the link (you can add more special chars to this)
    let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
    linkedBio += tag + currentChar // we add the special char at the end of the tag so that it actually appears, otherwise it does not
    link = "";
    found = false;
    else
    link += currentChar;

    else
    linkedBio += currentChar;



    if (link.length > 0) // means we need to add a link that is the last possible thing without anything after it
    let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
    linkedBio += tag


    document.getElementById("bio").innerHTML = linkedBio
    </script>


    I was going to use string.split(" "), but then I realized that if I did that I would destroy the specific formatting of the text if I used array.join(" ") after all of the formatting changes.



    Ex:
    Original: "I work for the coolest companies: @aws, @microsoft, and @apple"



    Joined: "I work for the coolest companies: @aws , @microsoft , and @apple"



    The commas are messed up.



    Is there a way to slim it down and/or simplify it? JS isn't my strongest language.



    Thanks!









    share







    New contributor




    Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      A user wrote an issue asking if inside the bio (or any arbitrary tag), any tagged accounts can be automatically linked like on Github.



      I gave them this function:



       <script>
      let bio = "The coolest company to work for is @github! There is also @aws and @microsoft.";
      let linkedBio = "";
      let found = false;
      let link = "";
      for (let i = 0; i < bio.length; i++)
      let currentChar = bio[i];

      if (currentChar.startsWith("@"))
      link += currentChar;
      found = true;
      continue // we don't need to look at other chars until next iterations


      if (found)
      if (/[^A-Za-z0-9]/.test(currentChar)) // we found the end of the link (you can add more special chars to this)
      let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
      linkedBio += tag + currentChar // we add the special char at the end of the tag so that it actually appears, otherwise it does not
      link = "";
      found = false;
      else
      link += currentChar;

      else
      linkedBio += currentChar;



      if (link.length > 0) // means we need to add a link that is the last possible thing without anything after it
      let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
      linkedBio += tag


      document.getElementById("bio").innerHTML = linkedBio
      </script>


      I was going to use string.split(" "), but then I realized that if I did that I would destroy the specific formatting of the text if I used array.join(" ") after all of the formatting changes.



      Ex:
      Original: "I work for the coolest companies: @aws, @microsoft, and @apple"



      Joined: "I work for the coolest companies: @aws , @microsoft , and @apple"



      The commas are messed up.



      Is there a way to slim it down and/or simplify it? JS isn't my strongest language.



      Thanks!









      share







      New contributor




      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      A user wrote an issue asking if inside the bio (or any arbitrary tag), any tagged accounts can be automatically linked like on Github.



      I gave them this function:



       <script>
      let bio = "The coolest company to work for is @github! There is also @aws and @microsoft.";
      let linkedBio = "";
      let found = false;
      let link = "";
      for (let i = 0; i < bio.length; i++)
      let currentChar = bio[i];

      if (currentChar.startsWith("@"))
      link += currentChar;
      found = true;
      continue // we don't need to look at other chars until next iterations


      if (found)
      if (/[^A-Za-z0-9]/.test(currentChar)) // we found the end of the link (you can add more special chars to this)
      let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
      linkedBio += tag + currentChar // we add the special char at the end of the tag so that it actually appears, otherwise it does not
      link = "";
      found = false;
      else
      link += currentChar;

      else
      linkedBio += currentChar;



      if (link.length > 0) // means we need to add a link that is the last possible thing without anything after it
      let tag = "<a href=https://github.com/" + link.substr(1) + ">" + link + "</a>"
      linkedBio += tag


      document.getElementById("bio").innerHTML = linkedBio
      </script>


      I was going to use string.split(" "), but then I realized that if I did that I would destroy the specific formatting of the text if I used array.join(" ") after all of the formatting changes.



      Ex:
      Original: "I work for the coolest companies: @aws, @microsoft, and @apple"



      Joined: "I work for the coolest companies: @aws , @microsoft , and @apple"



      The commas are messed up.



      Is there a way to slim it down and/or simplify it? JS isn't my strongest language.



      Thanks!







      javascript





      share







      New contributor




      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 4 mins ago









      LandonLandon

      11




      11




      New contributor




      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Landon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Landon is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216685%2fis-there-a-way-to-slim-down-this-javascript-code%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Landon is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Landon is a new contributor. Be nice, and check out our Code of Conduct.












          Landon is a new contributor. Be nice, and check out our Code of Conduct.











          Landon is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216685%2fis-there-a-way-to-slim-down-this-javascript-code%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          格濟夫卡 參考資料 导航菜单51°3′40″N 34°2′21″E / 51.06111°N 34.03917°E / 51.06111; 34.03917ГезівкаПогода в селі 编辑或修订