Min heap C++ implementation Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?Max heap in JavaImplementation of binary min-heap data structure(Min)Heap implementationGeneric Pairing Heap PerformanceMin & Max heap implementationOperations on a heapMaximum Heap ContainerProgram to check if heap order is correct or notMin Heap ImplementationC++11 min-heap with configurable arity
Positioning dot before text in math mode
Putting class ranking in CV, but against dept guidelines
A `coordinate` command ignored
Found this skink in my tomato plant bucket. Is he trapped? Or could he leave if he wanted?
Test print coming out spongy
Asymptotics question
Are the endpoints of the domain of a function counted as critical points?
Why not send Voyager 3 and 4 following up the paths taken by Voyager 1 and 2 to re-transmit signals of later as they fly away from Earth?
The Nth Gryphon Number
License to disallow distribution in closed source software, but allow exceptions made by owner?
How does light 'choose' between wave and particle behaviour?
Trying to understand entropy as a novice in thermodynamics
How do living politicians protect their readily obtainable signatures from misuse?
I can't produce songs
Printing attributes of selection in ArcPy?
AppleTVs create a chatty alternate WiFi network
What is the chair depicted in Cesare Maccari's 1889 painting "Cicerone denuncia Catilina"?
Co-worker has annoying ringtone
As a dual citizen, my US passport will expire one day after traveling to the US. Will this work?
Can two person see the same photon?
A proverb that is used to imply that you have unexpectedly faced a big problem
Is CEO the "profession" with the most psychopaths?
Flight departed from the gate 5 min before scheduled departure time. Refund options
What is the difference between CTSS and ITS?
Min heap C++ implementation
Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)
Announcing the arrival of Valued Associate #679: Cesar Manara
Unicorn Meta Zoo #1: Why another podcast?Max heap in JavaImplementation of binary min-heap data structure(Min)Heap implementationGeneric Pairing Heap PerformanceMin & Max heap implementationOperations on a heapMaximum Heap ContainerProgram to check if heap order is correct or notMin Heap ImplementationC++11 min-heap with configurable arity
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
I have implemented a min heap in C++, and I want to improve it in every possible way. Could you please review the same and let me know your suggestions/comments?
Appreciate your time and inputs!
#include <iostream>
#include <vector>
#include <algorithm> // std::swap
class MinHeap
private:
std::vector<int> heap;
void heapify(int);
int parent(int);
int left(int);
int right(int);
public:
void insert(int);
int extractMin();
;
// heapifies down the index-i
void MinHeap::heapify(int i)
int l = left(i);
int r = right(i);
// find the smallest amongst the parent, it's left & right child
int smallest;
smallest = (l != -1 && heap[l] < heap[i]) ? l : i;
smallest = (r != -1 && heap[r] < heap[smallest]) ? r : smallest;
// If heap[i] (parent) is the smallest, then it is already a Heap!
if (smallest != i)
std::swap(heap[i], heap[smallest]);
heapify(smallest);
// Returns the index of the left-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::left(int i)
int l = (((2 * i) + 1) < heap.size() - 1) ? (2 * i) + 1 : -1;
return l;
// Returns the index of the Right-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::right(int i)
int r = (((2 * i) + 2) < heap.size() - 1)? (2 * i) + 2 : -1;
return r;
// Returns the index of the Parent of the ith element
// Returns -1 if parent-index < 0
int MinHeap::parent(int i)
int p = (((i - 1) / 2) >= 0)? (i - 1) / 2 : -1;
return p;
// Returns the minimum element from the heap and also deletes it from the heap
int MinHeap::extractMin()
// back-up the root, it's the min value
int min = heap[0];
// copy the value of the very-last element into the root and delete the last element
heap[0] = heap.back();
heap.pop_back();
// heapify-down the root
heapify(0);
return min;
// inserts a value at the right-spot in the heap, ensures the heap property is maintained.
void MinHeap::insert(int value)
// insert the new element at the end of heap
heap.push_back(value);
// bubble-up the new value to its right position, thus maintaining the heap property
int i = heap.size() - 1;
while (heap[parent(i)] > heap[i])
std::swap(heap[parent(i)], heap[i]);
i = parent(i);
c++11 heap
$endgroup$
add a comment |
$begingroup$
I have implemented a min heap in C++, and I want to improve it in every possible way. Could you please review the same and let me know your suggestions/comments?
Appreciate your time and inputs!
#include <iostream>
#include <vector>
#include <algorithm> // std::swap
class MinHeap
private:
std::vector<int> heap;
void heapify(int);
int parent(int);
int left(int);
int right(int);
public:
void insert(int);
int extractMin();
;
// heapifies down the index-i
void MinHeap::heapify(int i)
int l = left(i);
int r = right(i);
// find the smallest amongst the parent, it's left & right child
int smallest;
smallest = (l != -1 && heap[l] < heap[i]) ? l : i;
smallest = (r != -1 && heap[r] < heap[smallest]) ? r : smallest;
// If heap[i] (parent) is the smallest, then it is already a Heap!
if (smallest != i)
std::swap(heap[i], heap[smallest]);
heapify(smallest);
// Returns the index of the left-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::left(int i)
int l = (((2 * i) + 1) < heap.size() - 1) ? (2 * i) + 1 : -1;
return l;
// Returns the index of the Right-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::right(int i)
int r = (((2 * i) + 2) < heap.size() - 1)? (2 * i) + 2 : -1;
return r;
// Returns the index of the Parent of the ith element
// Returns -1 if parent-index < 0
int MinHeap::parent(int i)
int p = (((i - 1) / 2) >= 0)? (i - 1) / 2 : -1;
return p;
// Returns the minimum element from the heap and also deletes it from the heap
int MinHeap::extractMin()
// back-up the root, it's the min value
int min = heap[0];
// copy the value of the very-last element into the root and delete the last element
heap[0] = heap.back();
heap.pop_back();
// heapify-down the root
heapify(0);
return min;
// inserts a value at the right-spot in the heap, ensures the heap property is maintained.
void MinHeap::insert(int value)
// insert the new element at the end of heap
heap.push_back(value);
// bubble-up the new value to its right position, thus maintaining the heap property
int i = heap.size() - 1;
while (heap[parent(i)] > heap[i])
std::swap(heap[parent(i)], heap[i]);
i = parent(i);
c++11 heap
$endgroup$
add a comment |
$begingroup$
I have implemented a min heap in C++, and I want to improve it in every possible way. Could you please review the same and let me know your suggestions/comments?
Appreciate your time and inputs!
#include <iostream>
#include <vector>
#include <algorithm> // std::swap
class MinHeap
private:
std::vector<int> heap;
void heapify(int);
int parent(int);
int left(int);
int right(int);
public:
void insert(int);
int extractMin();
;
// heapifies down the index-i
void MinHeap::heapify(int i)
int l = left(i);
int r = right(i);
// find the smallest amongst the parent, it's left & right child
int smallest;
smallest = (l != -1 && heap[l] < heap[i]) ? l : i;
smallest = (r != -1 && heap[r] < heap[smallest]) ? r : smallest;
// If heap[i] (parent) is the smallest, then it is already a Heap!
if (smallest != i)
std::swap(heap[i], heap[smallest]);
heapify(smallest);
// Returns the index of the left-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::left(int i)
int l = (((2 * i) + 1) < heap.size() - 1) ? (2 * i) + 1 : -1;
return l;
// Returns the index of the Right-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::right(int i)
int r = (((2 * i) + 2) < heap.size() - 1)? (2 * i) + 2 : -1;
return r;
// Returns the index of the Parent of the ith element
// Returns -1 if parent-index < 0
int MinHeap::parent(int i)
int p = (((i - 1) / 2) >= 0)? (i - 1) / 2 : -1;
return p;
// Returns the minimum element from the heap and also deletes it from the heap
int MinHeap::extractMin()
// back-up the root, it's the min value
int min = heap[0];
// copy the value of the very-last element into the root and delete the last element
heap[0] = heap.back();
heap.pop_back();
// heapify-down the root
heapify(0);
return min;
// inserts a value at the right-spot in the heap, ensures the heap property is maintained.
void MinHeap::insert(int value)
// insert the new element at the end of heap
heap.push_back(value);
// bubble-up the new value to its right position, thus maintaining the heap property
int i = heap.size() - 1;
while (heap[parent(i)] > heap[i])
std::swap(heap[parent(i)], heap[i]);
i = parent(i);
c++11 heap
$endgroup$
I have implemented a min heap in C++, and I want to improve it in every possible way. Could you please review the same and let me know your suggestions/comments?
Appreciate your time and inputs!
#include <iostream>
#include <vector>
#include <algorithm> // std::swap
class MinHeap
private:
std::vector<int> heap;
void heapify(int);
int parent(int);
int left(int);
int right(int);
public:
void insert(int);
int extractMin();
;
// heapifies down the index-i
void MinHeap::heapify(int i)
int l = left(i);
int r = right(i);
// find the smallest amongst the parent, it's left & right child
int smallest;
smallest = (l != -1 && heap[l] < heap[i]) ? l : i;
smallest = (r != -1 && heap[r] < heap[smallest]) ? r : smallest;
// If heap[i] (parent) is the smallest, then it is already a Heap!
if (smallest != i)
std::swap(heap[i], heap[smallest]);
heapify(smallest);
// Returns the index of the left-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::left(int i)
int l = (((2 * i) + 1) < heap.size() - 1) ? (2 * i) + 1 : -1;
return l;
// Returns the index of the Right-child of the ith element
// Returns -1 if the index > heap size
int MinHeap::right(int i)
int r = (((2 * i) + 2) < heap.size() - 1)? (2 * i) + 2 : -1;
return r;
// Returns the index of the Parent of the ith element
// Returns -1 if parent-index < 0
int MinHeap::parent(int i)
int p = (((i - 1) / 2) >= 0)? (i - 1) / 2 : -1;
return p;
// Returns the minimum element from the heap and also deletes it from the heap
int MinHeap::extractMin()
// back-up the root, it's the min value
int min = heap[0];
// copy the value of the very-last element into the root and delete the last element
heap[0] = heap.back();
heap.pop_back();
// heapify-down the root
heapify(0);
return min;
// inserts a value at the right-spot in the heap, ensures the heap property is maintained.
void MinHeap::insert(int value)
// insert the new element at the end of heap
heap.push_back(value);
// bubble-up the new value to its right position, thus maintaining the heap property
int i = heap.size() - 1;
while (heap[parent(i)] > heap[i])
std::swap(heap[parent(i)], heap[i]);
i = parent(i);
c++11 heap
c++11 heap
asked 10 mins ago
CompScipleCompSciple
516
516
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217803%2fmin-heap-c-implementation%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217803%2fmin-heap-c-implementation%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown