Project Euler #1: Sum of Multiples of 3 and 5 below 1000 Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Project Euler Problem 12 in PythonFunction to return the sum of multiples within a rangeProject Euler 78: Coin Partitions in PythonProject Euler #14: Longest Collatz sequenceProject Euler #15 in PythonProject Euler #4 - Largest Palindrome Project - PythonProject Euler problem #1 in Python 3Sum of multiples of 3 or 5 using functional programmingProject Euler 001 in C++Project Euler Problem 37 in Python

How does the particle を relate to the verb 行く in the structure「A を + B に行く」?

How come Sam didn't become Lord of Horn Hill?

What is a non-alternating simple group with big order, but relatively few conjugacy classes?

Bete Noir -- no dairy

How can I make names more distinctive without making them longer?

Is the Standard Deduction better than Itemized when both are the same amount?

How to bypass password on Windows XP account?

Do I really need recursive chmod to restrict access to a folder?

When a candle burns, why does the top of wick glow if bottom of flame is hottest?

If a contract sometimes uses the wrong name, is it still valid?

What exactly is a "Meth" in Altered Carbon?

ListPlot join points by nearest neighbor rather than order

What does an IRS interview request entail when called in to verify expenses for a sole proprietor small business?

Extract all GPU name, model and GPU ram

How does debian/ubuntu knows a package has a updated version

How to align text above triangle figure

Why did the Falcon Heavy center core fall off the ASDS OCISLY barge?

List *all* the tuples!

Why are there no cargo aircraft with "flying wing" design?

How widely used is the term Treppenwitz? Is it something that most Germans know?

When do you get frequent flier miles - when you buy, or when you fly?

Why is my conclusion inconsistent with the van't Hoff equation?

How to answer "Have you ever been terminated?"

Seeking colloquialism for “just because”



Project Euler #1: Sum of Multiples of 3 and 5 below 1000



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Project Euler Problem 12 in PythonFunction to return the sum of multiples within a rangeProject Euler 78: Coin Partitions in PythonProject Euler #14: Longest Collatz sequenceProject Euler #15 in PythonProject Euler #4 - Largest Palindrome Project - PythonProject Euler problem #1 in Python 3Sum of multiples of 3 or 5 using functional programmingProject Euler 001 in C++Project Euler Problem 37 in Python



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


def prob_1():
sum_mult=[] #Create an empty list which will take sum of multiples of 3 and 5
check_sum=0
for i in range(1,1000): #Take numbers till 1000
#if(i)
if( (i%3)==0 or (i%35)==0 ): #divisor condition
sum_mult.append(i)

return sum(sum_mult) #return sum of list


I am just starting out my journey as a programmer, here is my code and I would love to see any critical feedback and other alternative solutions maybe using some clever hack of using lambda function's etc.










share|improve this question









New contributor




DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    0












    $begingroup$


    def prob_1():
    sum_mult=[] #Create an empty list which will take sum of multiples of 3 and 5
    check_sum=0
    for i in range(1,1000): #Take numbers till 1000
    #if(i)
    if( (i%3)==0 or (i%35)==0 ): #divisor condition
    sum_mult.append(i)

    return sum(sum_mult) #return sum of list


    I am just starting out my journey as a programmer, here is my code and I would love to see any critical feedback and other alternative solutions maybe using some clever hack of using lambda function's etc.










    share|improve this question









    New contributor




    DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      def prob_1():
      sum_mult=[] #Create an empty list which will take sum of multiples of 3 and 5
      check_sum=0
      for i in range(1,1000): #Take numbers till 1000
      #if(i)
      if( (i%3)==0 or (i%35)==0 ): #divisor condition
      sum_mult.append(i)

      return sum(sum_mult) #return sum of list


      I am just starting out my journey as a programmer, here is my code and I would love to see any critical feedback and other alternative solutions maybe using some clever hack of using lambda function's etc.










      share|improve this question









      New contributor




      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      def prob_1():
      sum_mult=[] #Create an empty list which will take sum of multiples of 3 and 5
      check_sum=0
      for i in range(1,1000): #Take numbers till 1000
      #if(i)
      if( (i%3)==0 or (i%35)==0 ): #divisor condition
      sum_mult.append(i)

      return sum(sum_mult) #return sum of list


      I am just starting out my journey as a programmer, here is my code and I would love to see any critical feedback and other alternative solutions maybe using some clever hack of using lambda function's etc.







      python performance python-3.x programming-challenge






      share|improve this question









      New contributor




      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 44 secs ago









      AJNeufeld

      6,9641723




      6,9641723






      New contributor




      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 48 mins ago









      DjVasuDjVasu

      11




      11




      New contributor




      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      DjVasu is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          1 Answer
          1






          active

          oldest

          votes


















          0












          $begingroup$

          I expect you made a typo. You don't want (i%35)==0, you want (i%5)==0.




          check_sum is unused, and can be omitted.




          The brackets around the if( ... ): condition are unnecessary. This is Python, not C, C++ or Java:



           if (i % 3) == 0 or (i % 5) == 0: #divisor condition



          There is no need to create a list just to add up all the numbers after the fact. You are only using each value once, so you could simply add the numbers up as you find them:



          def prob_1():

          sum_of_multiples = 0

          for i in range(1, 1000): # Take numbers up to but not including 1000
          if (i % 3) == 0 or (i % 5) == 0: #divisor condition
          sum_of_multiples += i

          return sum_of_multiples



          You should add """doc_strings""" to your functions:



          def prob_1():
          """
          Compute the sum of all the multiples of 3 or 5 below 1000.

          Returns:
          The sum of the multiples of 3 or 5, below 1000.
          """

          sum_of_multiples = 0

          for i in range(1, 1000): # Take numbers up to but not including 1000
          if (i % 3) == 0 or (i % 5) == 0: #divisor condition
          sum_of_multiples += i

          return sum_of_multiples



          You can use list comprehension and the sum(...) function to compute the result, without ever creating the list in memory:



          def prob_1():
          """
          Compute the sum of all the multiples of 3 or 5 below 1000.

          Returns:
          The sum of the multiples of 3 or 5, below 1000.
          """

          return sum(i for i in range(1000) if i % 3 == 0 or i % 5 == 0)



          You can also solve this problem by hand with a pen, a sheet of paper, a calculator and about 1 minute of your time. A program is entirely unnecessary.





          share









          $endgroup$













            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );






            DjVasu is a new contributor. Be nice, and check out our Code of Conduct.









            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217598%2fproject-euler-1-sum-of-multiples-of-3-and-5-below-1000%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0












            $begingroup$

            I expect you made a typo. You don't want (i%35)==0, you want (i%5)==0.




            check_sum is unused, and can be omitted.




            The brackets around the if( ... ): condition are unnecessary. This is Python, not C, C++ or Java:



             if (i % 3) == 0 or (i % 5) == 0: #divisor condition



            There is no need to create a list just to add up all the numbers after the fact. You are only using each value once, so you could simply add the numbers up as you find them:



            def prob_1():

            sum_of_multiples = 0

            for i in range(1, 1000): # Take numbers up to but not including 1000
            if (i % 3) == 0 or (i % 5) == 0: #divisor condition
            sum_of_multiples += i

            return sum_of_multiples



            You should add """doc_strings""" to your functions:



            def prob_1():
            """
            Compute the sum of all the multiples of 3 or 5 below 1000.

            Returns:
            The sum of the multiples of 3 or 5, below 1000.
            """

            sum_of_multiples = 0

            for i in range(1, 1000): # Take numbers up to but not including 1000
            if (i % 3) == 0 or (i % 5) == 0: #divisor condition
            sum_of_multiples += i

            return sum_of_multiples



            You can use list comprehension and the sum(...) function to compute the result, without ever creating the list in memory:



            def prob_1():
            """
            Compute the sum of all the multiples of 3 or 5 below 1000.

            Returns:
            The sum of the multiples of 3 or 5, below 1000.
            """

            return sum(i for i in range(1000) if i % 3 == 0 or i % 5 == 0)



            You can also solve this problem by hand with a pen, a sheet of paper, a calculator and about 1 minute of your time. A program is entirely unnecessary.





            share









            $endgroup$

















              0












              $begingroup$

              I expect you made a typo. You don't want (i%35)==0, you want (i%5)==0.




              check_sum is unused, and can be omitted.




              The brackets around the if( ... ): condition are unnecessary. This is Python, not C, C++ or Java:



               if (i % 3) == 0 or (i % 5) == 0: #divisor condition



              There is no need to create a list just to add up all the numbers after the fact. You are only using each value once, so you could simply add the numbers up as you find them:



              def prob_1():

              sum_of_multiples = 0

              for i in range(1, 1000): # Take numbers up to but not including 1000
              if (i % 3) == 0 or (i % 5) == 0: #divisor condition
              sum_of_multiples += i

              return sum_of_multiples



              You should add """doc_strings""" to your functions:



              def prob_1():
              """
              Compute the sum of all the multiples of 3 or 5 below 1000.

              Returns:
              The sum of the multiples of 3 or 5, below 1000.
              """

              sum_of_multiples = 0

              for i in range(1, 1000): # Take numbers up to but not including 1000
              if (i % 3) == 0 or (i % 5) == 0: #divisor condition
              sum_of_multiples += i

              return sum_of_multiples



              You can use list comprehension and the sum(...) function to compute the result, without ever creating the list in memory:



              def prob_1():
              """
              Compute the sum of all the multiples of 3 or 5 below 1000.

              Returns:
              The sum of the multiples of 3 or 5, below 1000.
              """

              return sum(i for i in range(1000) if i % 3 == 0 or i % 5 == 0)



              You can also solve this problem by hand with a pen, a sheet of paper, a calculator and about 1 minute of your time. A program is entirely unnecessary.





              share









              $endgroup$















                0












                0








                0





                $begingroup$

                I expect you made a typo. You don't want (i%35)==0, you want (i%5)==0.




                check_sum is unused, and can be omitted.




                The brackets around the if( ... ): condition are unnecessary. This is Python, not C, C++ or Java:



                 if (i % 3) == 0 or (i % 5) == 0: #divisor condition



                There is no need to create a list just to add up all the numbers after the fact. You are only using each value once, so you could simply add the numbers up as you find them:



                def prob_1():

                sum_of_multiples = 0

                for i in range(1, 1000): # Take numbers up to but not including 1000
                if (i % 3) == 0 or (i % 5) == 0: #divisor condition
                sum_of_multiples += i

                return sum_of_multiples



                You should add """doc_strings""" to your functions:



                def prob_1():
                """
                Compute the sum of all the multiples of 3 or 5 below 1000.

                Returns:
                The sum of the multiples of 3 or 5, below 1000.
                """

                sum_of_multiples = 0

                for i in range(1, 1000): # Take numbers up to but not including 1000
                if (i % 3) == 0 or (i % 5) == 0: #divisor condition
                sum_of_multiples += i

                return sum_of_multiples



                You can use list comprehension and the sum(...) function to compute the result, without ever creating the list in memory:



                def prob_1():
                """
                Compute the sum of all the multiples of 3 or 5 below 1000.

                Returns:
                The sum of the multiples of 3 or 5, below 1000.
                """

                return sum(i for i in range(1000) if i % 3 == 0 or i % 5 == 0)



                You can also solve this problem by hand with a pen, a sheet of paper, a calculator and about 1 minute of your time. A program is entirely unnecessary.





                share









                $endgroup$



                I expect you made a typo. You don't want (i%35)==0, you want (i%5)==0.




                check_sum is unused, and can be omitted.




                The brackets around the if( ... ): condition are unnecessary. This is Python, not C, C++ or Java:



                 if (i % 3) == 0 or (i % 5) == 0: #divisor condition



                There is no need to create a list just to add up all the numbers after the fact. You are only using each value once, so you could simply add the numbers up as you find them:



                def prob_1():

                sum_of_multiples = 0

                for i in range(1, 1000): # Take numbers up to but not including 1000
                if (i % 3) == 0 or (i % 5) == 0: #divisor condition
                sum_of_multiples += i

                return sum_of_multiples



                You should add """doc_strings""" to your functions:



                def prob_1():
                """
                Compute the sum of all the multiples of 3 or 5 below 1000.

                Returns:
                The sum of the multiples of 3 or 5, below 1000.
                """

                sum_of_multiples = 0

                for i in range(1, 1000): # Take numbers up to but not including 1000
                if (i % 3) == 0 or (i % 5) == 0: #divisor condition
                sum_of_multiples += i

                return sum_of_multiples



                You can use list comprehension and the sum(...) function to compute the result, without ever creating the list in memory:



                def prob_1():
                """
                Compute the sum of all the multiples of 3 or 5 below 1000.

                Returns:
                The sum of the multiples of 3 or 5, below 1000.
                """

                return sum(i for i in range(1000) if i % 3 == 0 or i % 5 == 0)



                You can also solve this problem by hand with a pen, a sheet of paper, a calculator and about 1 minute of your time. A program is entirely unnecessary.






                share











                share


                share










                answered 2 mins ago









                AJNeufeldAJNeufeld

                6,9641723




                6,9641723




















                    DjVasu is a new contributor. Be nice, and check out our Code of Conduct.









                    draft saved

                    draft discarded


















                    DjVasu is a new contributor. Be nice, and check out our Code of Conduct.












                    DjVasu is a new contributor. Be nice, and check out our Code of Conduct.











                    DjVasu is a new contributor. Be nice, and check out our Code of Conduct.














                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217598%2fproject-euler-1-sum-of-multiples-of-3-and-5-below-1000%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

                    Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

                    Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar