Ttykuu

Why wasn't DOSKEY integrated with COMMAND.COM?

Generate an RGB colour grid

How do I find out the mythology and history of my Fortress?

Why does the resolve message appear first?

Do square wave exist?

Is the Standard Deduction better than Itemized when both are the same amount?

Amount of permutations on an NxNxN Rubik's Cube

Is "Reachable Object" really an NP-complete problem?

Would "destroying" Wurmcoil Engine prevent its tokens from being created?

What does the "x" in "x86" represent?

Why do we bend a book to keep it straight?

What's the meaning of "fortified infraction restraint"?

Significance of Cersei's obsession with elephants?

Is there such thing as an Availability Group failover trigger?

Why are both D and D# fitting into my E minor key?

Do wooden building fires get hotter than 600°C?

How to answer "Have you ever been terminated?"

How to react to hostile behavior from a senior developer?

Is it fair for a professor to grade us on the possession of past papers?

Is CEO the profession with the most psychopaths?

2001: A Space Odyssey's use of the song "Daisy Bell" (Bicycle Built for Two); life imitates art or vice-versa?

What do you call the main part of a joke?

For a new assistant professor in CS, how to build/manage a publication pipeline

Is there a kind of relay only consumes power when switching?

Python, Rock, Paper, Scissor

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;

1

$begingroup$

Recently i wanted to test my Python knowledge so I'm taking some challenges. I came across a Rock Paper Scissor challenge and I wanted to make it with less code and reuse the same code over and over. The code below is what I have written so far and it works great. I just want to get your opinions: what can i do better?

rules = 
 'rock': 
 'scissor': 'smashes'
 ,
 'paper': 
 'rock': 'packs'
 ,
 'scissor': 
 'paper': 'cuts'
 


player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()


def play(p1, p2):
 if p1 in rules:
 if p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))

 if p2 in rules:
 if p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

 if p1 not in rules or p2 not in rules:
 print("Invalid input")


if __name__ == '__main__':
 play(player_one, player_two)

python rock-paper-scissors

share|improve this question

edited 14 mins ago

200_success

131k17157422

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

New contributor

Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

add a comment | 

1

$begingroup$

Recently i wanted to test my Python knowledge so I'm taking some challenges. I came across a Rock Paper Scissor challenge and I wanted to make it with less code and reuse the same code over and over. The code below is what I have written so far and it works great. I just want to get your opinions: what can i do better?

rules = 
 'rock': 
 'scissor': 'smashes'
 ,
 'paper': 
 'rock': 'packs'
 ,
 'scissor': 
 'paper': 'cuts'
 


player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()


def play(p1, p2):
 if p1 in rules:
 if p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))

 if p2 in rules:
 if p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

 if p1 not in rules or p2 not in rules:
 print("Invalid input")


if __name__ == '__main__':
 play(player_one, player_two)

python rock-paper-scissors

share|improve this question

edited 14 mins ago

200_success

131k17157422

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

New contributor

Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

add a comment | 

$begingroup$

Recently i wanted to test my Python knowledge so I'm taking some challenges. I came across a Rock Paper Scissor challenge and I wanted to make it with less code and reuse the same code over and over. The code below is what I have written so far and it works great. I just want to get your opinions: what can i do better?

rules = 
 'rock': 
 'scissor': 'smashes'
 ,
 'paper': 
 'rock': 'packs'
 ,
 'scissor': 
 'paper': 'cuts'
 


player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()


def play(p1, p2):
 if p1 in rules:
 if p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))

 if p2 in rules:
 if p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

 if p1 not in rules or p2 not in rules:
 print("Invalid input")


if __name__ == '__main__':
 play(player_one, player_two)

python rock-paper-scissors

share|improve this question

edited 14 mins ago

200_success

131k17157422

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

New contributor

Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

rules = 
 'rock': 
 'scissor': 'smashes'
 ,
 'paper': 
 'rock': 'packs'
 ,
 'scissor': 
 'paper': 'cuts'
 


player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()


def play(p1, p2):
 if p1 in rules:
 if p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))

 if p2 in rules:
 if p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

 if p1 not in rules or p2 not in rules:
 print("Invalid input")


if __name__ == '__main__':
 play(player_one, player_two)

share|improve this question

edited 14 mins ago

200_success

131k17157422

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

New contributor

Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share|improve this question

edited 14 mins ago

200_success

131k17157422

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

New contributor

Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

edited 14 mins ago

200_success

131k17157422

edited 14 mins ago

200_success

131k17157422

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

New contributor

Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 20 mins ago

Johnny NiklassonJohnny Niklasson

61

1 Answer
1

active

oldest

votes

0

$begingroup$

Perform the validation first, to eliminate redundant conditionals.

def play(p1, p2):
 if p1 not in rules or p2 not in rules:
 print("Invalid input")
 elif p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))
 elif p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

share

answered 9 mins ago

200_success200_success

131k17157422

$endgroup$

add a comment | 

Your Answer

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);

Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');

var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);

;
$window.on('scroll', onScroll);

);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name

Email

Required, but never shown

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217645%2fpython-rock-paper-scissor%23new-answer', 'question_page');

);

Post as a guest

Name

Email

Required, but never shown

0

$begingroup$

Perform the validation first, to eliminate redundant conditionals.

def play(p1, p2):
 if p1 not in rules or p2 not in rules:
 print("Invalid input")
 elif p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))
 elif p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

share

answered 9 mins ago

200_success200_success

131k17157422

$endgroup$

add a comment | 

0

$begingroup$

Perform the validation first, to eliminate redundant conditionals.

def play(p1, p2):
 if p1 not in rules or p2 not in rules:
 print("Invalid input")
 elif p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))
 elif p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

share

answered 9 mins ago

200_success200_success

131k17157422

$endgroup$

add a comment | 

$begingroup$

Perform the validation first, to eliminate redundant conditionals.

def play(p1, p2):
 if p1 not in rules or p2 not in rules:
 print("Invalid input")
 elif p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))
 elif p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

share

answered 9 mins ago

200_success200_success

131k17157422

$endgroup$

def play(p1, p2):
 if p1 not in rules or p2 not in rules:
 print("Invalid input")
 elif p2 in rules[p1]:
 print(" ".format(p1, rules[p1][p2], p2))
 elif p1 in rules[p2]:
 print(" ".format(p2, rules[p2][p1], p1))

share

answered 9 mins ago

200_success200_success

131k17157422

answered 9 mins ago

200_success200_success

131k17157422

answered 9 mins ago

200_success200_success

131k17157422