Python, Rock, Paper, Scissor [Better code help] Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Rock, Paper, Scissors in PythonScissors, Paper, Rock in PythonPangrams python implementationPython rock paper scissorsRounding a number up to the nearest multiple of a power of 2Rock, Paper, Scissors - Python gameRock, Paper Scissor game (console-based) in PythonRock Paper Scissors in PythonPython 3 Rock, Paper, ScissorsPython Rock Paper Scissors sqlite

How to tell that you are a giant?

What do you call the main part of a joke?

How come Sam didn't become Lord of Horn Hill?

Has negative voting ever been officially implemented in elections, or seriously proposed, or even studied?

8 Prisoners wearing hats

How would a mousetrap for use in space work?

Integration Help

Why aren't air breathing engines used as small first stages

Do jazz musicians improvise on the parent scale in addition to the chord-scales?

Compare a given version number in the form major.minor.build.patch and see if one is less than the other

Do square wave exist?

Do wooden building fires get hotter than 600°C?

Extracting terms with certain heads in a function

Fundamental Solution of the Pell Equation

Using et al. for a last / senior author rather than for a first author

Generate an RGB colour grid

Should I use a zero-interest credit card for a large one-time purchase?

Fantasy story; one type of magic grows in power with use, but the more powerful they are, they more they are drawn to travel to their source

Is there a kind of relay only consumes power when switching?

How can I use the Python library networkx from Mathematica?

What do you call a floor made of glass so you can see through the floor?

Wu formula for manifolds with boundary

Did MS DOS itself ever use blinking text?

Is grep documentation wrong?



Python, Rock, Paper, Scissor [Better code help]



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Rock, Paper, Scissors in PythonScissors, Paper, Rock in PythonPangrams python implementationPython rock paper scissorsRounding a number up to the nearest multiple of a power of 2Rock, Paper, Scissors - Python gameRock, Paper Scissor game (console-based) in PythonRock Paper Scissors in PythonPython 3 Rock, Paper, ScissorsPython Rock Paper Scissors sqlite



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.



rules = 
'rock':
'scissor': 'smashes'
,
'paper':
'rock': 'packs'
,
'scissor':
'paper': 'cuts'



player_one = input("P1 | Rock, Paper or Scissor: ").lower()
player_two = input("P2 | Rock, Paper or Scissor: ").lower()


def play(p1, p2):
if p1 in rules:
if p2 in rules[p1]:
print(" ".format(p1, rules[p1][p2], p2))

if p2 in rules:
if p1 in rules[p2]:
print(" ".format(p2, rules[p2][p1], p1))

if p1 not in rules or p2 not in rules:
print("Invalid input")


if __name__ == '__main__':
play(player_one, player_two)








share







New contributor




Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    0












    $begingroup$


    ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.



    rules = 
    'rock':
    'scissor': 'smashes'
    ,
    'paper':
    'rock': 'packs'
    ,
    'scissor':
    'paper': 'cuts'



    player_one = input("P1 | Rock, Paper or Scissor: ").lower()
    player_two = input("P2 | Rock, Paper or Scissor: ").lower()


    def play(p1, p2):
    if p1 in rules:
    if p2 in rules[p1]:
    print(" ".format(p1, rules[p1][p2], p2))

    if p2 in rules:
    if p1 in rules[p2]:
    print(" ".format(p2, rules[p2][p1], p1))

    if p1 not in rules or p2 not in rules:
    print("Invalid input")


    if __name__ == '__main__':
    play(player_one, player_two)








    share







    New contributor




    Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.



      rules = 
      'rock':
      'scissor': 'smashes'
      ,
      'paper':
      'rock': 'packs'
      ,
      'scissor':
      'paper': 'cuts'



      player_one = input("P1 | Rock, Paper or Scissor: ").lower()
      player_two = input("P2 | Rock, Paper or Scissor: ").lower()


      def play(p1, p2):
      if p1 in rules:
      if p2 in rules[p1]:
      print(" ".format(p1, rules[p1][p2], p2))

      if p2 in rules:
      if p1 in rules[p2]:
      print(" ".format(p2, rules[p2][p1], p1))

      if p1 not in rules or p2 not in rules:
      print("Invalid input")


      if __name__ == '__main__':
      play(player_one, player_two)








      share







      New contributor




      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      ecently i wanted to test my python knowledge so im taking these challenges, i came across a Rock paper Scissor challenge and i wanted to make it with less code and reuse the same code over and over. The code below is what i have written so far and it works great, i just want to get your opinions, what can i do better? PS: this is not done.



      rules = 
      'rock':
      'scissor': 'smashes'
      ,
      'paper':
      'rock': 'packs'
      ,
      'scissor':
      'paper': 'cuts'



      player_one = input("P1 | Rock, Paper or Scissor: ").lower()
      player_two = input("P2 | Rock, Paper or Scissor: ").lower()


      def play(p1, p2):
      if p1 in rules:
      if p2 in rules[p1]:
      print(" ".format(p1, rules[p1][p2], p2))

      if p2 in rules:
      if p1 in rules[p2]:
      print(" ".format(p2, rules[p2][p1], p1))

      if p1 not in rules or p2 not in rules:
      print("Invalid input")


      if __name__ == '__main__':
      play(player_one, player_two)






      python





      share







      New contributor




      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 4 mins ago









      Johnny NiklassonJohnny Niklasson

      1




      1




      New contributor




      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Johnny Niklasson is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer






          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217645%2fpython-rock-paper-scissor-better-code-help%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.












          Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.











          Johnny Niklasson is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217645%2fpython-rock-paper-scissor-better-code-help%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          瀋陽號驅逐艦 目录 接收與服役 配置反潛直升機 武進三型性能升級 歷史 除役 參考資料 外部連結 导航菜单Taiwan Air Power海疆老兵-陽字號驅逐艦沿革World Navies Today: Taiwan (Republic of China)DD-839 USS POWER

          波兰旗帜列表 目录 国旗 军旗 其他制服部门旗帜 特别国家机构船只 参考文献 外部链接 导航菜单Polskie flagi, chorągwie, bandery... [波兰旗帜、条幅、船旗等]原始内容Ustawa z dnia 31 stycznia 1980 r. o godle, barwach i hymnie Rzeczypospolitej Polskiej oraz o pieczęciach państwowychZarządzenie Ministra Obrony Narodowej z dnia 14 grudnia 2005 r. zmieniające zarządzenie w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejZarządzenie Ministra Obrony Narodowej z dnia 29 stycznia 1996 r. w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejUstawa z dnia 19 lutego 1993 r. o znakach Sił Zbrojnych Rzeczypospolitej PolskiejHistoria Marynarki Wojennej RP [波兰海军史]Rozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 12 kwietnia 2002 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych Straży GranicznejRozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 18 kwietnia 2005 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych PolicjiRozporządzenie Ministra Infrastruktury z dnia 21 października 2005 r. w sprawie wzorów flag dla statków morskich na oznaczenie pełnionej specjalnej służby państwowej oraz okoliczności i warunków ich podnoszenia波兰旗帜波兰

          Indenting and Dedenting ASP code with Python