“First Python program: Tic-Tac-Toe (Followup) The 2019 Stack Overflow Developer Survey Results Are InFirst Python program: Tic-Tac-ToeTic-Tac-Toe optimization 2.0 with AITic-Tac-Toe solverTic Tac Toe Player written in PythonTic-Tac-Toe Game (Java)First Tic Tac Toe gameTic Tac Toe in RubyDesign Tic tac toe gameTic Tac Toe in CFirst Python game of Tic-Tac-ToeTic-Tac-Toe with React hooks

What is the meaning of Triage in Cybersec world?

Why was M87 targeted for the Event Horizon Telescope instead of Sagittarius A*?

Is it possible for absolutely everyone to attain enlightenment?

What does もの mean in this sentence?

Output the Arecibo Message

Match Roman Numerals

Relationship between Gromov-Witten and Taubes' Gromov invariant

"as much details as you can remember"

Are there any other methods to apply to solving simultaneous equations?

APIPA and LAN Broadcast Domain

Why not take a picture of a closer black hole?

What to do when moving next to a bird sanctuary with a loosely-domesticated cat?

Can we generate random numbers using irrational numbers like π and e?

I am an eight letter word. What am I?

How can I define good in a religion that claims no moral authority?

Did any laptop computers have a built-in 5 1/4 inch floppy drive?

Will it cause any balance problems to have PCs level up and gain the benefits of a long rest mid-fight?

Worn-tile Scrabble

Why didn't the Event Horizon Telescope team mention Sagittarius A*?

What does Linus Torvalds mean when he says that Git "never ever" tracks a file?

writing variables above the numbers in tikz picture

Is it a good practice to use a static variable in a Test Class and use that in the actual class instead of Test.isRunningTest()?

Deal with toxic manager when you can't quit

For what reasons would an animal species NOT cross a *horizontal* land bridge?



“First Python program: Tic-Tac-Toe (Followup)



The 2019 Stack Overflow Developer Survey Results Are InFirst Python program: Tic-Tac-ToeTic-Tac-Toe optimization 2.0 with AITic-Tac-Toe solverTic Tac Toe Player written in PythonTic-Tac-Toe Game (Java)First Tic Tac Toe gameTic Tac Toe in RubyDesign Tic tac toe gameTic Tac Toe in CFirst Python game of Tic-Tac-ToeTic-Tac-Toe with React hooks



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



'''python 3.7.4'''



import sys
from textwrap import dedent
import os
import random

os.system('CLS')

# board number setup
board = [0, 1, 2,
3, 4, 5,
6, 7, 8]


# Defines the board layout printed to the console
def board_layout():
print(dedent(f'''
*************
* board[0] | board[1] | board[2] *
*-----------*
* board[3] | board[4] | board[5] *
*-----------*
* board[6] | board[7] | board[8] *
*************
'''))


def main():
players = ('Player','NPC')
turn = 'Player'
change_turn = 0
for moves in range(9):
if turn == 'Player':
while True:
try:
board_layout()
player_move = int(input('Please select a spot: '))
if board[player_move] != 'x' and board[player_move] != 'o':
board[player_move] = 'x'
check_winner()
break
except IndexError:
print('please select valid spot')
if turn == 'NPC':
# npc move, chooses a random spot that is not taken
while True:
npc = random.randint(0, 8)
if board[npc] != 'o' and board[npc] != 'x':
board[npc] = 'o'
print('Computer chooses spot ', npc)
check_winner()
break
try:
change_turn += 1
turn = players[change_turn]
except:
change_turn = 0
turn = players[change_turn]
else:
print('You Tied')
end()





def end():
print('Thank you for playing')
answer = input('Would you like to play again?: Y/N')

if answer.lower() == 'n':
quit()
elif answer.lower() == 'y':
clear_board()
main()
else:
print('Please choose a valid option')
end()

def clear_board():
for i in range(9):
board[i] = i

# checks for a winner when called at end of each turn
def check_winner():

# list of lists with all the winning combinations for from the tic tac toe board
winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
[board[6], board[7], board[8]], [board[0], board[4], board[8]],
[board[2], board[4], board[6]],
[board[0], board[3], board[6]], [board[1], board[4], board[7]],
[board[2], board[5], board[8]]]

# iterates over the lists in winning_list
for i, j, k in winning_list:
# looks at the lists in winning_list to determine if a list has all x's for a win
if i == 'x' and j == 'x' and k == 'x':
print('X wins')
end()
# looks at the lists in winning_list to determine if a list has all o's for a win
elif i == 'o' and j == 'o' and k == 'o':
print('O wins')
end()


if __name__ == "__main__":
main()









share|improve this question







New contributor




andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    0












    $begingroup$


    This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
    I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



    '''python 3.7.4'''



    import sys
    from textwrap import dedent
    import os
    import random

    os.system('CLS')

    # board number setup
    board = [0, 1, 2,
    3, 4, 5,
    6, 7, 8]


    # Defines the board layout printed to the console
    def board_layout():
    print(dedent(f'''
    *************
    * board[0] | board[1] | board[2] *
    *-----------*
    * board[3] | board[4] | board[5] *
    *-----------*
    * board[6] | board[7] | board[8] *
    *************
    '''))


    def main():
    players = ('Player','NPC')
    turn = 'Player'
    change_turn = 0
    for moves in range(9):
    if turn == 'Player':
    while True:
    try:
    board_layout()
    player_move = int(input('Please select a spot: '))
    if board[player_move] != 'x' and board[player_move] != 'o':
    board[player_move] = 'x'
    check_winner()
    break
    except IndexError:
    print('please select valid spot')
    if turn == 'NPC':
    # npc move, chooses a random spot that is not taken
    while True:
    npc = random.randint(0, 8)
    if board[npc] != 'o' and board[npc] != 'x':
    board[npc] = 'o'
    print('Computer chooses spot ', npc)
    check_winner()
    break
    try:
    change_turn += 1
    turn = players[change_turn]
    except:
    change_turn = 0
    turn = players[change_turn]
    else:
    print('You Tied')
    end()





    def end():
    print('Thank you for playing')
    answer = input('Would you like to play again?: Y/N')

    if answer.lower() == 'n':
    quit()
    elif answer.lower() == 'y':
    clear_board()
    main()
    else:
    print('Please choose a valid option')
    end()

    def clear_board():
    for i in range(9):
    board[i] = i

    # checks for a winner when called at end of each turn
    def check_winner():

    # list of lists with all the winning combinations for from the tic tac toe board
    winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
    [board[6], board[7], board[8]], [board[0], board[4], board[8]],
    [board[2], board[4], board[6]],
    [board[0], board[3], board[6]], [board[1], board[4], board[7]],
    [board[2], board[5], board[8]]]

    # iterates over the lists in winning_list
    for i, j, k in winning_list:
    # looks at the lists in winning_list to determine if a list has all x's for a win
    if i == 'x' and j == 'x' and k == 'x':
    print('X wins')
    end()
    # looks at the lists in winning_list to determine if a list has all o's for a win
    elif i == 'o' and j == 'o' and k == 'o':
    print('O wins')
    end()


    if __name__ == "__main__":
    main()









    share|improve this question







    New contributor




    andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
      I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



      '''python 3.7.4'''



      import sys
      from textwrap import dedent
      import os
      import random

      os.system('CLS')

      # board number setup
      board = [0, 1, 2,
      3, 4, 5,
      6, 7, 8]


      # Defines the board layout printed to the console
      def board_layout():
      print(dedent(f'''
      *************
      * board[0] | board[1] | board[2] *
      *-----------*
      * board[3] | board[4] | board[5] *
      *-----------*
      * board[6] | board[7] | board[8] *
      *************
      '''))


      def main():
      players = ('Player','NPC')
      turn = 'Player'
      change_turn = 0
      for moves in range(9):
      if turn == 'Player':
      while True:
      try:
      board_layout()
      player_move = int(input('Please select a spot: '))
      if board[player_move] != 'x' and board[player_move] != 'o':
      board[player_move] = 'x'
      check_winner()
      break
      except IndexError:
      print('please select valid spot')
      if turn == 'NPC':
      # npc move, chooses a random spot that is not taken
      while True:
      npc = random.randint(0, 8)
      if board[npc] != 'o' and board[npc] != 'x':
      board[npc] = 'o'
      print('Computer chooses spot ', npc)
      check_winner()
      break
      try:
      change_turn += 1
      turn = players[change_turn]
      except:
      change_turn = 0
      turn = players[change_turn]
      else:
      print('You Tied')
      end()





      def end():
      print('Thank you for playing')
      answer = input('Would you like to play again?: Y/N')

      if answer.lower() == 'n':
      quit()
      elif answer.lower() == 'y':
      clear_board()
      main()
      else:
      print('Please choose a valid option')
      end()

      def clear_board():
      for i in range(9):
      board[i] = i

      # checks for a winner when called at end of each turn
      def check_winner():

      # list of lists with all the winning combinations for from the tic tac toe board
      winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
      [board[6], board[7], board[8]], [board[0], board[4], board[8]],
      [board[2], board[4], board[6]],
      [board[0], board[3], board[6]], [board[1], board[4], board[7]],
      [board[2], board[5], board[8]]]

      # iterates over the lists in winning_list
      for i, j, k in winning_list:
      # looks at the lists in winning_list to determine if a list has all x's for a win
      if i == 'x' and j == 'x' and k == 'x':
      print('X wins')
      end()
      # looks at the lists in winning_list to determine if a list has all o's for a win
      elif i == 'o' and j == 'o' and k == 'o':
      print('O wins')
      end()


      if __name__ == "__main__":
      main()









      share|improve this question







      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
      I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



      '''python 3.7.4'''



      import sys
      from textwrap import dedent
      import os
      import random

      os.system('CLS')

      # board number setup
      board = [0, 1, 2,
      3, 4, 5,
      6, 7, 8]


      # Defines the board layout printed to the console
      def board_layout():
      print(dedent(f'''
      *************
      * board[0] | board[1] | board[2] *
      *-----------*
      * board[3] | board[4] | board[5] *
      *-----------*
      * board[6] | board[7] | board[8] *
      *************
      '''))


      def main():
      players = ('Player','NPC')
      turn = 'Player'
      change_turn = 0
      for moves in range(9):
      if turn == 'Player':
      while True:
      try:
      board_layout()
      player_move = int(input('Please select a spot: '))
      if board[player_move] != 'x' and board[player_move] != 'o':
      board[player_move] = 'x'
      check_winner()
      break
      except IndexError:
      print('please select valid spot')
      if turn == 'NPC':
      # npc move, chooses a random spot that is not taken
      while True:
      npc = random.randint(0, 8)
      if board[npc] != 'o' and board[npc] != 'x':
      board[npc] = 'o'
      print('Computer chooses spot ', npc)
      check_winner()
      break
      try:
      change_turn += 1
      turn = players[change_turn]
      except:
      change_turn = 0
      turn = players[change_turn]
      else:
      print('You Tied')
      end()





      def end():
      print('Thank you for playing')
      answer = input('Would you like to play again?: Y/N')

      if answer.lower() == 'n':
      quit()
      elif answer.lower() == 'y':
      clear_board()
      main()
      else:
      print('Please choose a valid option')
      end()

      def clear_board():
      for i in range(9):
      board[i] = i

      # checks for a winner when called at end of each turn
      def check_winner():

      # list of lists with all the winning combinations for from the tic tac toe board
      winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
      [board[6], board[7], board[8]], [board[0], board[4], board[8]],
      [board[2], board[4], board[6]],
      [board[0], board[3], board[6]], [board[1], board[4], board[7]],
      [board[2], board[5], board[8]]]

      # iterates over the lists in winning_list
      for i, j, k in winning_list:
      # looks at the lists in winning_list to determine if a list has all x's for a win
      if i == 'x' and j == 'x' and k == 'x':
      print('X wins')
      end()
      # looks at the lists in winning_list to determine if a list has all o's for a win
      elif i == 'o' and j == 'o' and k == 'o':
      print('O wins')
      end()


      if __name__ == "__main__":
      main()






      beginner python-3.x tic-tac-toe






      share|improve this question







      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 11 mins ago









      andrewtwandrewtw

      215




      215




      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217304%2ffirst-python-program-tic-tac-toe-followup%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.












          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.











          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217304%2ffirst-python-program-tic-tac-toe-followup%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          瀋陽號驅逐艦 目录 接收與服役 配置反潛直升機 武進三型性能升級 歷史 除役 參考資料 外部連結 导航菜单Taiwan Air Power海疆老兵-陽字號驅逐艦沿革World Navies Today: Taiwan (Republic of China)DD-839 USS POWER

          波兰旗帜列表 目录 国旗 军旗 其他制服部门旗帜 特别国家机构船只 参考文献 外部链接 导航菜单Polskie flagi, chorągwie, bandery... [波兰旗帜、条幅、船旗等]原始内容Ustawa z dnia 31 stycznia 1980 r. o godle, barwach i hymnie Rzeczypospolitej Polskiej oraz o pieczęciach państwowychZarządzenie Ministra Obrony Narodowej z dnia 14 grudnia 2005 r. zmieniające zarządzenie w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejZarządzenie Ministra Obrony Narodowej z dnia 29 stycznia 1996 r. w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejUstawa z dnia 19 lutego 1993 r. o znakach Sił Zbrojnych Rzeczypospolitej PolskiejHistoria Marynarki Wojennej RP [波兰海军史]Rozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 12 kwietnia 2002 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych Straży GranicznejRozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 18 kwietnia 2005 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych PolicjiRozporządzenie Ministra Infrastruktury z dnia 21 października 2005 r. w sprawie wzorów flag dla statków morskich na oznaczenie pełnionej specjalnej służby państwowej oraz okoliczności i warunków ich podnoszenia波兰旗帜波兰

          Indenting and Dedenting ASP code with Python