How can this code which turns hourly data for columns of data into daily be improved? The 2019 Stack Overflow Developer Survey Results Are In Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Non-standardised data across multiple worksheets: Aggregation, Validation, FilteringVBA macro which filters and splits dataset into new workbooksForecast maintenance interval for fleet of aircraftConsolidate used student hours into master sheet for exportWorkbook for tracking projectsMaking a report from payroll detailsSum hours worked depending on day typeExcel 'big' data processing with vlookupsExcel 'Big' Data Processing FollowupFastest method of getting the bounding box containing all value ranges

Circular reasoning in L'Hopital's rule

"is" operation returns false even though two objects have same id

How do spell lists change if the party levels up without taking a long rest?

Homework question about an engine pulling a train

Why did Peik Lin say, "I'm not an animal"?

Was credit for the black hole image misappropriated?

Do I have Disadvantage attacking with an off-hand weapon?

The following signatures were invalid: EXPKEYSIG 1397BC53640DB551

What force causes entropy to increase?

ELI5: Why do they say that Israel would have been the fourth country to land a spacecraft on the Moon and why do they call it low cost?

Is this wall load bearing? Blueprints and photos attached

Is an up-to-date browser secure on an out-of-date OS?

Accepted by European university, rejected by all American ones I applied to? Possible reasons?

Simulating Exploding Dice

How to support a colleague who finds meetings extremely tiring?

Solving overdetermined system by QR decomposition

Didn't get enough time to take a Coding Test - what to do now?

Can we generate random numbers using irrational numbers like π and e?

What does "spokes" mean in this context?

What other Star Trek series did the main TNG cast show up in?

For what reasons would an animal species NOT cross a *horizontal* land bridge?

Nested ellipses in tikzpicture: Chomsky hierarchy

What is the padding with red substance inside of steak packaging?

Do working physicists consider Newtonian mechanics to be "falsified"?



How can this code which turns hourly data for columns of data into daily be improved?



The 2019 Stack Overflow Developer Survey Results Are In
Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Non-standardised data across multiple worksheets: Aggregation, Validation, FilteringVBA macro which filters and splits dataset into new workbooksForecast maintenance interval for fleet of aircraftConsolidate used student hours into master sheet for exportWorkbook for tracking projectsMaking a report from payroll detailsSum hours worked depending on day typeExcel 'big' data processing with vlookupsExcel 'Big' Data Processing FollowupFastest method of getting the bounding box containing all value ranges



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1

Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

counter = 0
total_obs_q = 0

For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s

total_obs_q = total_obs_q + obs_q_d(w)

Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w









share|improve this question







New contributor




Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    0












    $begingroup$


    Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



    u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
    t = Int((n - 1) / 24) + 1

    Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
    Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


    ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

    ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

    counter = 0
    total_obs_q = 0

    For w = 1 To t
    rain_d(0) = 0
    evap_d(0) = 0
    obs_q_d(0) = 0
    sim_q_d(0) = 0
    For s = 0 To 23
    rain_recalc(w, s) = rainfall(counter)
    rain_d(w) = rain_d(w) + rain_recalc(w, s)
    evap_recalc(w, s) = evaporation(counter)
    evap_d(w) = evap_d(w) + evap_recalc(w, s)
    obs_q_recalc(w, s) = obs_q(counter)
    obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
    sim_q_recalc(w, s) = simulated_q(counter)
    sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
    counter = counter + 1
    Next s

    total_obs_q = total_obs_q + obs_q_d(w)

    Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
    Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
    Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
    Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
    Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
    Next w









    share|improve this question







    New contributor




    Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



      u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
      t = Int((n - 1) / 24) + 1

      Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
      Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


      ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

      ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

      counter = 0
      total_obs_q = 0

      For w = 1 To t
      rain_d(0) = 0
      evap_d(0) = 0
      obs_q_d(0) = 0
      sim_q_d(0) = 0
      For s = 0 To 23
      rain_recalc(w, s) = rainfall(counter)
      rain_d(w) = rain_d(w) + rain_recalc(w, s)
      evap_recalc(w, s) = evaporation(counter)
      evap_d(w) = evap_d(w) + evap_recalc(w, s)
      obs_q_recalc(w, s) = obs_q(counter)
      obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
      sim_q_recalc(w, s) = simulated_q(counter)
      sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
      counter = counter + 1
      Next s

      total_obs_q = total_obs_q + obs_q_d(w)

      Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
      Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
      Next w









      share|improve this question







      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data



      u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
      t = Int((n - 1) / 24) + 1

      Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
      Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double


      ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double

      ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double

      counter = 0
      total_obs_q = 0

      For w = 1 To t
      rain_d(0) = 0
      evap_d(0) = 0
      obs_q_d(0) = 0
      sim_q_d(0) = 0
      For s = 0 To 23
      rain_recalc(w, s) = rainfall(counter)
      rain_d(w) = rain_d(w) + rain_recalc(w, s)
      evap_recalc(w, s) = evaporation(counter)
      evap_d(w) = evap_d(w) + evap_recalc(w, s)
      obs_q_recalc(w, s) = obs_q(counter)
      obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
      sim_q_recalc(w, s) = simulated_q(counter)
      sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
      counter = counter + 1
      Next s

      total_obs_q = total_obs_q + obs_q_d(w)

      Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
      Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
      Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
      Next w






      vba excel






      share|improve this question







      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 12 mins ago









      Josh AltonJosh Alton

      1




      1




      New contributor




      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Josh Alton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer






          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fhow-can-this-code-which-turns-hourly-data-for-columns-of-data-into-daily-be-impr%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.












          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.











          Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fhow-can-this-code-which-turns-hourly-data-for-columns-of-data-into-daily-be-impr%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

          Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar