How can this code which turns hourly data for columns of data into daily be improved? The 2019 Stack Overflow Developer Survey Results Are In Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Non-standardised data across multiple worksheets: Aggregation, Validation, FilteringVBA macro which filters and splits dataset into new workbooksForecast maintenance interval for fleet of aircraftConsolidate used student hours into master sheet for exportWorkbook for tracking projectsMaking a report from payroll detailsSum hours worked depending on day typeExcel 'big' data processing with vlookupsExcel 'Big' Data Processing FollowupFastest method of getting the bounding box containing all value ranges
Circular reasoning in L'Hopital's rule
"is" operation returns false even though two objects have same id
How do spell lists change if the party levels up without taking a long rest?
Homework question about an engine pulling a train
Why did Peik Lin say, "I'm not an animal"?
Was credit for the black hole image misappropriated?
Do I have Disadvantage attacking with an off-hand weapon?
The following signatures were invalid: EXPKEYSIG 1397BC53640DB551
What force causes entropy to increase?
ELI5: Why do they say that Israel would have been the fourth country to land a spacecraft on the Moon and why do they call it low cost?
Is this wall load bearing? Blueprints and photos attached
Is an up-to-date browser secure on an out-of-date OS?
Accepted by European university, rejected by all American ones I applied to? Possible reasons?
Simulating Exploding Dice
How to support a colleague who finds meetings extremely tiring?
Solving overdetermined system by QR decomposition
Didn't get enough time to take a Coding Test - what to do now?
Can we generate random numbers using irrational numbers like π and e?
What does "spokes" mean in this context?
What other Star Trek series did the main TNG cast show up in?
For what reasons would an animal species NOT cross a *horizontal* land bridge?
Nested ellipses in tikzpicture: Chomsky hierarchy
What is the padding with red substance inside of steak packaging?
Do working physicists consider Newtonian mechanics to be "falsified"?
How can this code which turns hourly data for columns of data into daily be improved?
The 2019 Stack Overflow Developer Survey Results Are In
Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Non-standardised data across multiple worksheets: Aggregation, Validation, FilteringVBA macro which filters and splits dataset into new workbooksForecast maintenance interval for fleet of aircraftConsolidate used student hours into master sheet for exportWorkbook for tracking projectsMaking a report from payroll detailsSum hours worked depending on day typeExcel 'big' data processing with vlookupsExcel 'Big' Data Processing FollowupFastest method of getting the bounding box containing all value ranges
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
New contributor
$endgroup$
add a comment |
$begingroup$
Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
New contributor
$endgroup$
add a comment |
$begingroup$
Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
New contributor
$endgroup$
Ive got some code which converts data from hours to days. I am wondering if there are any improvements which could be made to make it more efficient or any other improvements in general that could be made? other information:for t = Int((n - 1) / 24) + 1, the n is the amount of rows of data. u is the first cell of the hourly data
u = Int(Worksheets("Hydrological_Data").Cells(6, 1))
t = Int((n - 1) / 24) + 1
Dim rain_recalc(), evap_recalc(), obs_q_recalc(), sim_q_recalc() As Double
Dim rain_d(), evap_d(), available_w_d(), interflow_d(), overflow_d(), obs_q_d(), sim_q_d() As Double
ReDim rain_recalc(t, 24), evap_recalc(t, 24), obs_q_recalc(t, 24), sim_q_recalc(t, 24) As Double
ReDim rain_d(t), evap_d(t), available_w_d(t), interflow_d(t), overflow_d(t), obs_q_d(t), sim_q_d(t) As Double
counter = 0
total_obs_q = 0
For w = 1 To t
rain_d(0) = 0
evap_d(0) = 0
obs_q_d(0) = 0
sim_q_d(0) = 0
For s = 0 To 23
rain_recalc(w, s) = rainfall(counter)
rain_d(w) = rain_d(w) + rain_recalc(w, s)
evap_recalc(w, s) = evaporation(counter)
evap_d(w) = evap_d(w) + evap_recalc(w, s)
obs_q_recalc(w, s) = obs_q(counter)
obs_q_d(w) = obs_q_d(w) + obs_q_recalc(w, s)
sim_q_recalc(w, s) = simulated_q(counter)
sim_q_d(w) = sim_q_d(w) + sim_q_recalc(w, s)
counter = counter + 1
Next s
total_obs_q = total_obs_q + obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 7) = u + w - 1
Worksheets("Hydrological_Data").Cells(5 + w, 8) = rain_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 9) = evap_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 10) = obs_q_d(w)
Worksheets("Hydrological_Data").Cells(5 + w, 11) = sim_q_d(w)
Next w
vba excel
vba excel
New contributor
New contributor
New contributor
asked 12 mins ago
Josh AltonJosh Alton
1
1
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fhow-can-this-code-which-turns-hourly-data-for-columns-of-data-into-daily-be-impr%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Josh Alton is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217352%2fhow-can-this-code-which-turns-hourly-data-for-columns-of-data-into-daily-be-impr%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown