Is this a good code for implementation of Radix Sort algorithm for sorting integers in c++? The Next CEO of Stack Overflow

Can a caster that cast Polymorph on themselves stop concentrating at any point even if their Int is low?

What can we do to stop prior company from asking us questions?

How long to clear the 'suck zone' of a turbofan after start is initiated?

How does practicing restraint and performing actions of merit purify the mind?

Should I tutor a student who I know has cheated on their homework?

What is the point of a new vote on May's deal when the indicative votes suggest she will not win?

The King's new dress

How to count occurrences of text in a file?

How do we know the LHC results are robust?

Example of a Mathematician/Physicist whose Other Publications during their PhD eclipsed their PhD Thesis

I believe this to be a fraud - hired, then asked to cash check and send cash as Bitcoin

Unreliable Magic - Is it worth it?

Return the Closest Prime Number

MAZDA 3 2006 (UK) - poor acceleration then takes off at 3250 revs

Natural language into sentence logic

Does the Brexit deal have to be agreed by both Houses?

Why do professional authors make "consistency" mistakes? And how to avoid them?

What do "high sea" and "carry" mean in this sentence?

Term for the "extreme-extension" version of a straw man fallacy?

Horror movie/show or scene where a horse creature opens its mouth really wide and devours a man in a stables

How do I go from 300 unfinished/half written blog posts, to published posts?

How do scammers retract money, while you can’t?

Where to find order of arguments for default functions

Would this house-rule that treats advantage as a +1 to the roll instead (and disadvantage as -1) and allows them to stack be balanced?



Is this a good code for implementation of Radix Sort algorithm for sorting integers in c++?



The Next CEO of Stack Overflow










0












$begingroup$


Wrote code for Radix Sort algorithm for number sorting.
Just curious to know if it is good.. I am open for discussion and improvements.
Any review is highly appreciated.




You can also view and run/test the code here Radix Sort




#include<iostream>
using namespace std;

int getNumberAtPosition(int num,int position)
return (num/position)%10;

void radixSort(int array[],int length)
int sizeOfEachBucket = length;
int numberOfBuckets = 10;
int buckets[10][sizeOfEachBucket];
int large = 0;
int maxPasses = 0;
//finding largest number from array
for(int i=0; i<length; i++)
if(array[i]>large)
large = array[i];



//finding the number of passes
while(large != 0)
maxPasses++;
large = large/10;

cout<<"Max passes ="<<maxPasses<<endl;
int position = 1;
int bucketIndex = 0;
int newListIndex = 0;
int arrayLengths[10];
for(int i=0; i<maxPasses; i++)
//cout<<"i ="<<i<<endl;
for(int k=0; k<=9; k++)
//cout<<"k ="<<k<<endl;
bucketIndex = 0;
for(int j=0; j<length; j++)
if(k==getNumberAtPosition(array[j],position))
buckets[k][bucketIndex] = array[j];
bucketIndex++;


arrayLengths[k] = bucketIndex;

position = position*10;
int newArrayIndex = 0;
for(int k=0; k<=9; k++)
//cout<<"k ="<<k<<endl;
bucketIndex = 0;
for(int x=0; x<arrayLengths[k];x++)
array[newArrayIndex] = buckets[k][x];
newArrayIndex++;




for(int i=0; i<length; i++)
cout<<array[i]<<"t";










share









$endgroup$
















    0












    $begingroup$


    Wrote code for Radix Sort algorithm for number sorting.
    Just curious to know if it is good.. I am open for discussion and improvements.
    Any review is highly appreciated.




    You can also view and run/test the code here Radix Sort




    #include<iostream>
    using namespace std;

    int getNumberAtPosition(int num,int position)
    return (num/position)%10;

    void radixSort(int array[],int length)
    int sizeOfEachBucket = length;
    int numberOfBuckets = 10;
    int buckets[10][sizeOfEachBucket];
    int large = 0;
    int maxPasses = 0;
    //finding largest number from array
    for(int i=0; i<length; i++)
    if(array[i]>large)
    large = array[i];



    //finding the number of passes
    while(large != 0)
    maxPasses++;
    large = large/10;

    cout<<"Max passes ="<<maxPasses<<endl;
    int position = 1;
    int bucketIndex = 0;
    int newListIndex = 0;
    int arrayLengths[10];
    for(int i=0; i<maxPasses; i++)
    //cout<<"i ="<<i<<endl;
    for(int k=0; k<=9; k++)
    //cout<<"k ="<<k<<endl;
    bucketIndex = 0;
    for(int j=0; j<length; j++)
    if(k==getNumberAtPosition(array[j],position))
    buckets[k][bucketIndex] = array[j];
    bucketIndex++;


    arrayLengths[k] = bucketIndex;

    position = position*10;
    int newArrayIndex = 0;
    for(int k=0; k<=9; k++)
    //cout<<"k ="<<k<<endl;
    bucketIndex = 0;
    for(int x=0; x<arrayLengths[k];x++)
    array[newArrayIndex] = buckets[k][x];
    newArrayIndex++;




    for(int i=0; i<length; i++)
    cout<<array[i]<<"t";










    share









    $endgroup$














      0












      0








      0





      $begingroup$


      Wrote code for Radix Sort algorithm for number sorting.
      Just curious to know if it is good.. I am open for discussion and improvements.
      Any review is highly appreciated.




      You can also view and run/test the code here Radix Sort




      #include<iostream>
      using namespace std;

      int getNumberAtPosition(int num,int position)
      return (num/position)%10;

      void radixSort(int array[],int length)
      int sizeOfEachBucket = length;
      int numberOfBuckets = 10;
      int buckets[10][sizeOfEachBucket];
      int large = 0;
      int maxPasses = 0;
      //finding largest number from array
      for(int i=0; i<length; i++)
      if(array[i]>large)
      large = array[i];



      //finding the number of passes
      while(large != 0)
      maxPasses++;
      large = large/10;

      cout<<"Max passes ="<<maxPasses<<endl;
      int position = 1;
      int bucketIndex = 0;
      int newListIndex = 0;
      int arrayLengths[10];
      for(int i=0; i<maxPasses; i++)
      //cout<<"i ="<<i<<endl;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int j=0; j<length; j++)
      if(k==getNumberAtPosition(array[j],position))
      buckets[k][bucketIndex] = array[j];
      bucketIndex++;


      arrayLengths[k] = bucketIndex;

      position = position*10;
      int newArrayIndex = 0;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int x=0; x<arrayLengths[k];x++)
      array[newArrayIndex] = buckets[k][x];
      newArrayIndex++;




      for(int i=0; i<length; i++)
      cout<<array[i]<<"t";










      share









      $endgroup$




      Wrote code for Radix Sort algorithm for number sorting.
      Just curious to know if it is good.. I am open for discussion and improvements.
      Any review is highly appreciated.




      You can also view and run/test the code here Radix Sort




      #include<iostream>
      using namespace std;

      int getNumberAtPosition(int num,int position)
      return (num/position)%10;

      void radixSort(int array[],int length)
      int sizeOfEachBucket = length;
      int numberOfBuckets = 10;
      int buckets[10][sizeOfEachBucket];
      int large = 0;
      int maxPasses = 0;
      //finding largest number from array
      for(int i=0; i<length; i++)
      if(array[i]>large)
      large = array[i];



      //finding the number of passes
      while(large != 0)
      maxPasses++;
      large = large/10;

      cout<<"Max passes ="<<maxPasses<<endl;
      int position = 1;
      int bucketIndex = 0;
      int newListIndex = 0;
      int arrayLengths[10];
      for(int i=0; i<maxPasses; i++)
      //cout<<"i ="<<i<<endl;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int j=0; j<length; j++)
      if(k==getNumberAtPosition(array[j],position))
      buckets[k][bucketIndex] = array[j];
      bucketIndex++;


      arrayLengths[k] = bucketIndex;

      position = position*10;
      int newArrayIndex = 0;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int x=0; x<arrayLengths[k];x++)
      array[newArrayIndex] = buckets[k][x];
      newArrayIndex++;




      for(int i=0; i<length; i++)
      cout<<array[i]<<"t";








      c++ algorithm sorting





      share












      share










      share



      share










      asked 2 mins ago









      DeepeshkumarDeepeshkumar

      61




      61




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );













          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216460%2fis-this-a-good-code-for-implementation-of-radix-sort-algorithm-for-sorting-integ%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes















          draft saved

          draft discarded
















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216460%2fis-this-a-good-code-for-implementation-of-radix-sort-algorithm-for-sorting-integ%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          瀋陽號驅逐艦 目录 接收與服役 配置反潛直升機 武進三型性能升級 歷史 除役 參考資料 外部連結 导航菜单Taiwan Air Power海疆老兵-陽字號驅逐艦沿革World Navies Today: Taiwan (Republic of China)DD-839 USS POWER

          波兰旗帜列表 目录 国旗 军旗 其他制服部门旗帜 特别国家机构船只 参考文献 外部链接 导航菜单Polskie flagi, chorągwie, bandery... [波兰旗帜、条幅、船旗等]原始内容Ustawa z dnia 31 stycznia 1980 r. o godle, barwach i hymnie Rzeczypospolitej Polskiej oraz o pieczęciach państwowychZarządzenie Ministra Obrony Narodowej z dnia 14 grudnia 2005 r. zmieniające zarządzenie w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejZarządzenie Ministra Obrony Narodowej z dnia 29 stycznia 1996 r. w sprawie szczegółowych zasad używania znaków Sił Zbrojnych Rzeczypospolitej Polskiej oraz ustalenia innych znaków używanych w Siłach Zbrojnych Rzeczypospolitej PolskiejUstawa z dnia 19 lutego 1993 r. o znakach Sił Zbrojnych Rzeczypospolitej PolskiejHistoria Marynarki Wojennej RP [波兰海军史]Rozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 12 kwietnia 2002 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych Straży GranicznejRozporządzenie Ministra Spraw Wewnętrznych i Administracji z dnia 18 kwietnia 2005 r. w sprawie wzoru flagi oraz oznakowania jednostek pływających i statków powietrznych PolicjiRozporządzenie Ministra Infrastruktury z dnia 21 października 2005 r. w sprawie wzorów flag dla statków morskich na oznaczenie pełnionej specjalnej służby państwowej oraz okoliczności i warunków ich podnoszenia波兰旗帜波兰

          Indenting and Dedenting ASP code with Python