Ttykuu

how to draw discrete time diagram in tikz

Sailing the cryptic seas

(Calculus) Derivative Thinking Question

What do Xenomorphs eat in the Alien series?

How to use of "the" before known matrices

Why did it take so long to abandon sail after steamships were demonstrated?

Are there verbs that are neither telic, or atelic?

Have researchers managed to "reverse time"? If so, what does that mean for physics?

Are ETF trackers fundamentally better than individual stocks?

How could a scammer know the apps on my phone / iTunes account?

Is it normal that my co-workers at a fitness company criticize my food choices?

PTIJ: Who should I vote for? (21st Knesset Edition)

It's a yearly task, alright

Is it possible to upcast ritual spells?

My adviser wants to be the first author

Employee lack of ownership

What should tie a collection of short-stories together?

Do these spellcasting foci from Xanathar's Guide to Everything have to be held in a hand?

How big is a MODIS 250m pixel in reality?

How difficult is it to simply disable/disengage the MCAS on Boeing 737 Max 8 & 9 Aircraft?

How to create the Curved texte?

What exactly is this small puffer fish doing and how did it manage to accomplish such a feat?

Is there a data structure that only stores hash codes and not the actual objects?

What are substitutions for coconut in curry?

Is this a good practice to load controllers

Framework to drive a small personal siteRouting in MVC with PHPRouting, Navigation and State in MVCVery small MVC login frameworkImplementation of MVC Bootstrap & FactoryProcedural to OOP MVC: Understanding Controllers, Models, and Service LayerMy included in every script file - follow-up -1Simple OO MVC PHP frameworkUpload and database insert php functionSimple MVC built in PHP

-1

$begingroup$

I'm new to PHP and I'm learning mostly,

Is this a good practice to load controllers in PHP? (for a small and lightweight app)

Does it have any vulnerabilities? or it's fine and I can move on to write my controllers?

<?php

// application path (outside public_html)
define('APP', '../application/');
// controllers
define('CONTROLLER', APP.'controller/');

// Default controller
$controller = 'default';

// Check if page is set (e.g. index.php?page=login)
if(isset($_GET['page']))
 // Get controller name and remove possible / from the end
 $controller = rtrim($_GET['page'],'/');


// Set controller path
$file = CONTROLLER."$controller.php";

// Check page
if(preg_match('/^[A-Za-z0-9_]+$/', $controller) !== 1 OR ! file_exists($file))
 // Error
 require_once('404.php');
 die();


// Necessary stuff
require_once(APP.'system.php');

// Load the controller
require_once($file);

// Nothing more comes in index.php

P.S. This is the bare bone with some extra stuff removed

P.S.S. I'm not trying to go with MVC, just some way to load pages securely under index.php

php

share|improve this question

edited 3 hours ago

J. Doe

asked 5 hours ago

J. DoeJ. Doe

11

New contributor

J. Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Downvote reason please? This is "Code Review" and as a beginner I simply hoped for a professional to kindly take a look at this if possible :(
  $endgroup$
  – J. Doe
  5 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  $path is undefined in your question's code. Which means file_exists($path) is always false in this example. And if it made it far enough this would fail too require_once($path);
  $endgroup$
  – ArtisticPhoenix
  4 hours ago
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  @ArtisticPhoenix I simplified variable/constant names for here, it was a typo, thanks for pointing that out
  $endgroup$
  – J. Doe
  4 hours ago
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  That was what I figured. - no problem. Otherwise it looks ok, you may want to name our constants something more "verbose" so they don't cause any conflicts. I would probably do this as a constant $controller = 'default'; then if(!defined('DEFAULT_CONTROLER')) define('DEFAULT_CONTROLER', 'default') That way if you assign it before including this you can override it. But thats not a big deal.
  $endgroup$
  – ArtisticPhoenix
  4 hours ago
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  P.S.S. I'm not trying to go with MVC - You don't have to go full on MVC, the benefit is that with an auto loader you can avoid touching the path at all. So there is no possiblillity for Directory Transversal ../../../config.php etc. I have this Router and AutoLoader - the router I did for a SO question, so it's less robust then the autoloader. But it loads based on the Class by instantiating instead of building a path. The autoloader has fair documentation, and its simple
  $endgroup$
  – ArtisticPhoenix
  4 hours ago
  
  

  
  
  
  

 | 
show 2 more comments

-1

$begingroup$

I'm new to PHP and I'm learning mostly,

Is this a good practice to load controllers in PHP? (for a small and lightweight app)

Does it have any vulnerabilities? or it's fine and I can move on to write my controllers?

<?php

// application path (outside public_html)
define('APP', '../application/');
// controllers
define('CONTROLLER', APP.'controller/');

// Default controller
$controller = 'default';

// Check if page is set (e.g. index.php?page=login)
if(isset($_GET['page']))
 // Get controller name and remove possible / from the end
 $controller = rtrim($_GET['page'],'/');


// Set controller path
$file = CONTROLLER."$controller.php";

// Check page
if(preg_match('/^[A-Za-z0-9_]+$/', $controller) !== 1 OR ! file_exists($file))
 // Error
 require_once('404.php');
 die();


// Necessary stuff
require_once(APP.'system.php');

// Load the controller
require_once($file);

// Nothing more comes in index.php

P.S. This is the bare bone with some extra stuff removed

P.S.S. I'm not trying to go with MVC, just some way to load pages securely under index.php

php

share|improve this question

edited 3 hours ago

J. Doe

asked 5 hours ago

J. DoeJ. Doe

11

New contributor

J. Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Downvote reason please? This is "Code Review" and as a beginner I simply hoped for a professional to kindly take a look at this if possible :(
  $endgroup$
  – J. Doe
  5 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  $path is undefined in your question's code. Which means file_exists($path) is always false in this example. And if it made it far enough this would fail too require_once($path);
  $endgroup$
  – ArtisticPhoenix
  4 hours ago
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  @ArtisticPhoenix I simplified variable/constant names for here, it was a typo, thanks for pointing that out
  $endgroup$
  – J. Doe
  4 hours ago
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  That was what I figured. - no problem. Otherwise it looks ok, you may want to name our constants something more "verbose" so they don't cause any conflicts. I would probably do this as a constant $controller = 'default'; then if(!defined('DEFAULT_CONTROLER')) define('DEFAULT_CONTROLER', 'default') That way if you assign it before including this you can override it. But thats not a big deal.
  $endgroup$
  – ArtisticPhoenix
  4 hours ago
  
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  P.S.S. I'm not trying to go with MVC - You don't have to go full on MVC, the benefit is that with an auto loader you can avoid touching the path at all. So there is no possiblillity for Directory Transversal ../../../config.php etc. I have this Router and AutoLoader - the router I did for a SO question, so it's less robust then the autoloader. But it loads based on the Class by instantiating instead of building a path. The autoloader has fair documentation, and its simple
  $endgroup$
  – ArtisticPhoenix
  4 hours ago
  
  

  
  
  
  

 | 
show 2 more comments

$begingroup$

I'm new to PHP and I'm learning mostly,

Is this a good practice to load controllers in PHP? (for a small and lightweight app)

Does it have any vulnerabilities? or it's fine and I can move on to write my controllers?

<?php

// application path (outside public_html)
define('APP', '../application/');
// controllers
define('CONTROLLER', APP.'controller/');

// Default controller
$controller = 'default';

// Check if page is set (e.g. index.php?page=login)
if(isset($_GET['page']))
 // Get controller name and remove possible / from the end
 $controller = rtrim($_GET['page'],'/');


// Set controller path
$file = CONTROLLER."$controller.php";

// Check page
if(preg_match('/^[A-Za-z0-9_]+$/', $controller) !== 1 OR ! file_exists($file))
 // Error
 require_once('404.php');
 die();


// Necessary stuff
require_once(APP.'system.php');

// Load the controller
require_once($file);

// Nothing more comes in index.php

P.S. This is the bare bone with some extra stuff removed

P.S.S. I'm not trying to go with MVC, just some way to load pages securely under index.php

php

share|improve this question

edited 3 hours ago

J. Doe

asked 5 hours ago

J. DoeJ. Doe

11

New contributor

J. Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

<?php

// application path (outside public_html)
define('APP', '../application/');
// controllers
define('CONTROLLER', APP.'controller/');

// Default controller
$controller = 'default';

// Check if page is set (e.g. index.php?page=login)
if(isset($_GET['page']))
 // Get controller name and remove possible / from the end
 $controller = rtrim($_GET['page'],'/');


// Set controller path
$file = CONTROLLER."$controller.php";

// Check page
if(preg_match('/^[A-Za-z0-9_]+$/', $controller) !== 1 OR ! file_exists($file))
 // Error
 require_once('404.php');
 die();


// Necessary stuff
require_once(APP.'system.php');

// Load the controller
require_once($file);

// Nothing more comes in index.php

share|improve this question

edited 3 hours ago

J. Doe

asked 5 hours ago

J. DoeJ. Doe

11

New contributor

J. Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share|improve this question

edited 3 hours ago

J. Doe

asked 5 hours ago

J. DoeJ. Doe

11

New contributor

J. Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 5 hours ago

J. DoeJ. Doe

11

New contributor

J. Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 5 hours ago

J. DoeJ. Doe

11