Ttykuu

Review

Class SectorController calculates coefficients for sectors of equity exchange markets using minute data from an API. Would you be so kind and review this class, which is also connected to some other classes, some of them I will post after this review?

I have simplified and added some dummy numbers (such as 0.05, 5) to be easier for your review. If there is anything that can make this script faster, it would be great.

Script

class SectorController


 /**
 *
 * @var a string of iextrading base URL
 */

 const BASE_URL = "https://api.iextrading.com/1.0/"; 

 /**
 *
 * @var a string of target path and query
 */

 const TARGET_QUERY = "stock/market/batch?symbols=";


 /**
 *
 * @var a string for backend path for every sector
 */

 const EACH_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir-";


 /**
 *
 * @var a string for backend path for index sector
 */

 const INDEX_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir/";


 /**
 *
 * @var a string for live data path
 */

 const LIVE_DATA_DIR = "/../../../public_html/dir/dir/";

 function __construct()
 
 echo "YAAAY! " . __METHOD__ . " success 💚n"; 
 return true;
 

 public static function getSectors()
 $baseUrl=self::BASE_URL.self::TARGET_QUERY;
 $currentTime = date("Y-m-d-H-i-s");

 $permission = 0755;

 $indexData = array( "Overall" => array("sector_weight" => 1, "sector_coefficient" => 5,
 $sectorInfos=SectorController::iexSectorParams();
 foreach ($sectorInfos as $a => $sectorInfo) 
 $sectorUrl = $baseUrl . implode(",", array_keys($sectorInfo["selected_tickers"])) . "&types=quote&range=1m";
 $rawSectorJson = file_get_contents($sectorUrl);
 $rawSectorArray = json_decode($rawSectorJson, true);

 // Write the raw file
 $rawSectorDir = __DIR__ . self::EACH_SECTOR_DIR_PREFIX . $sectorInfo["directory"];

 if (!is_dir($rawSectorDir)) 
 mkdir($rawSectorDir, $permission, true);
 

 $rawSectorFile = $rawSectorDir . "/" . $currentTime . ".json";
 $fp = fopen($rawSectorFile, "a+");
 fwrite($fp, $rawSectorJson);
 fclose($fp);

 // Calculate the real-time index
 $indexValue = 0;
 foreach ($rawSectorArray as $ticker => $tickerStats) 
 if (isset($sectorInfo["selected_tickers"][$ticker], $tickerStats["quote"], $tickerStats["quote"]["extendedChangePercent"], $tickerStats["quote"]["changePercent"], $tickerStats["quote"]["ytdChange"])) 

 $changeAmount = ($tickerStats["quote"]["extendedChangePercent"] + $tickerStats["quote"]["changePercent"] + $tickerStats["quote"]["ytdChange"])/200;
 $indexValue += $sectorInfo["sector_weight"] * $sectorInfo["selected_tickers"][$ticker] * $changeAmount;
 
 

 $indexData[$sectorInfo["sector"]] = array("sector_weight" => $sectorInfo["sector_weight"], "sector_coefficient" => 5,
 $indexData["Overall"]["sector_value"] += $indexData[$sectorInfo["sector"]]["sector_value"];
 

 // Calculate the index factor for better visibility between -1 and +1
 $frontIndexData = array();
 foreach ($indexData as $sectorName => $sectorIndexData) 
 $indexSign = $sectorIndexData["sector_value"];
 if ($indexSign < 0) 
 $indexSign = - $indexSign;
 

 $indexFactor = 1;
 for ($i=0; $i <= 10; $i++) 
 $indexFactor = pow(10, $i);
 if (($indexFactor * $indexSign) > 1) 
 $indexFactor = pow(10, $i - 1);
 break;
 
 

 $frontIndexData[$sectorName] = $sectorIndexData["sector_weight"] * $sectorIndexData["sector_coefficient"] * $sectorIndexData["sector_value"] * $indexFactor;
 

 // Write the index file
 $indexSectorDir = __DIR__ . self::INDEX_SECTOR_DIR_PREFIX;

 if (!is_dir($indexSectorDir)) mkdir($indexSectorDir, $permission, true);

 $indexSectorFile = $indexSectorDir . $currentTime . ".json";

 $indexSectorJson = json_encode($frontIndexData, JSON_FORCE_OBJECT);
 $fp = fopen($indexSectorFile, "a+");
 fwrite($fp, $indexSectorJson);
 fclose($fp);

 $sectorDir = __DIR__ . self::LIVE_DATA_DIR;


 if (!is_dir($sectorDir)) mkdir($sectorDir, $permission, true); // if data directory did not exist

 // if text file did not exist
 if (!file_exists($sectorDir . "text.txt"))
 $handle=fopen($sectorDir . "text.txt", "wb");
 fwrite($handle, "d");
 fclose($handle);
 

 $sectorCoefFile = $sectorDir . "text.txt";
 copy($indexSectorFile, $sectorCoefFile);
 echo "YAAAY! " . __METHOD__ . " updated sector coefficients successfully 💚!n";

 return $frontIndexData;
 


 public static function iexSectorParams()
 $sectorInfos = array(
 array(
 "sector" => "IT",
 "directory" => "information-technology",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array( 
 "AAPL" => 0.05,
 "AMZN" => 0.05,
 "GOOGL" => 0.05,
 "IBM" => 0.05
 "MSFT" => 0.05
 "FB" => 0.05
 "NFLX" => 0.05,
 "ADBE" => 0.05,
 "CRM" => 0.05,
 "NVDA" => 0.05,
 )
 ),
 array( 
 "sector" => "Telecommunication",
 "directory" => "telecommunication-services",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "VZ" => 0.05,
 "CSCO" => 0.05,
 "CMCSA" => 0.05,
 "T" => 0.05,
 "CTL" => 0.05
 "CHTR" => 0.05
 "S" => 0.05,
 "DISH" => 0.05,
 "USM" => 0.05,
 "VOD" => 0.05,
 )
 ),
 array( 
 "sector" => "Finance",
 "directory" => "financial-services",
 "sector_weight" => 0.05
 "sector_coefficient" => 5,
 "selected_tickers" => array( 
 "JPM" => 0.05,
 "GS" => 0.05,
 "V" => 0.05,
 "BAC" => 0.05,
 "AXP" => 0.05
 "WFC" => 0.05
 "USB" => 0.05,
 "PNC" => 0.05,
 "AMG" => 0.05,
 "AIG" => 0.05,
 )
 ),
 array(
 "sector" => "Energy",
 "directory" => "energy",
 "sector_weight" => 0.05
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "CVX" => 0.05,
 "XOM" => 0.05,
 "APA" => 0.05,
 "COP" => 0.05,
 "BHGE" => 0.05
 "VLO" => 0.05
 "APC" => 0.05,
 "ANDV" => 0.05,
 "OXY" => 0.05,
 "HAL" => 0.05,
 )
 ),
 array(
 "sector" => "Industrials",
 "directory" => "industrials",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "CAT" => 0.05,
 "FLR" => 0.05,
 "GE" => 0.05,
 "JEC" => 0.05,
 "JCI" => 0.05
 "MAS" => 0.05
 "FLS" => 0.05,
 "AAL" => 0.05,
 "AME" => 0.05,
 "CHRW" => 0.05,
 )
 ),
 array(
 "sector" => "Materials and Chemicals",
 "directory" => "materials-and-chemicals",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "DWDP" => 0.05,
 "APD" => 0.05,
 "EMN" => 0.05,
 "ECL" => 0.05,
 "FMC" => 0.05
 "LYB" => 0.05
 "MOS" => 0.05,
 "NEM" => 0.05,
 "PPG" => 0.05,
 "MLM" => 0.05,
 )
 ),
 array(
 "sector" => "Utilities",
 "directory" => "utilities",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "PPL" => 0.05,
 "PCG" => 0.05,
 "SO" => 0.05,
 "WEC" => 0.05,
 "PEG" => 0.05
 "XEL" => 0.05
 "D" => 0.05,
 "NGG" => 0.05,
 "NEE" => 0.05,
 "PNW" => 0.05,
 )
 ),
 array( 
 "sector" => "Consumer Discretionary",
 "directory" => "consumer-discretionary",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "DIS" => 0.05,
 "HD" => 0.05,
 "BBY" => 0.05,
 "CBS" => 0.05,
 "CMG" => 0.05
 "MCD" => 0.05
 "GPS" => 0.05,
 "HOG" => 0.05,
 "AZO" => 0.05,
 "EXPE" => 0.05,
 )
 ),
 array(
 "sector" => "Consumer Staples",
 "directory" => "consumer-staples",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array( 
 "PEP" => 0.05,
 "PM" => 0.05,
 "PG" => 0.05,
 "MNST" => 0.05,
 "TSN" => 0.05
 "CPB" => 0.05
 "HRL" => 0.05,
 "SJM" => 0.05,
 "CAG" => 0.05,
 "KHC" => 0.05,
 )
 ),
 array( 
 "sector" => "Defense",
 "directory" => "defense-and-aerospace",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array( 
 "BA" => 0.05,
 "LMT" => 0.05,
 "UTX" => 0.05,
 "NOC" => 0.05,
 "HON" => 0.05
 "RTN" => 0.05
 "TXT" => 0.05,
 "LLL" => 0.05,
 "COL" => 0.05,
 "GD" => 0.05,
 )
 ),
 array( 
 "sector" => "Health",
 "directory" => "health-care-and-pharmaceuticals",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array( 
 "UNH" => 0.05,
 "JNJ" => 0.05,
 "PFE" => 0.05,
 "UHS" => 0.05,
 "AET" => 0.05
 "RMD" => 0.05
 "TMO" => 0.05,
 "MRK" => 0.05,
 "ABT" => 0.05,
 "LLY" => 0.05,
 )
 ),


 array(
 "sector" => "Real Estate",
 "directory" => "real-estate",
 "sector_weight" => 0.05,
 "sector_coefficient" => 5,
 "selected_tickers" => array(
 "CCI" => 0.05,
 "AMT" => 0.05,
 "AVB" => 0.05,
 "HCP" => 0.05,
 "RCL" => 0.05
 "HST" => 0.05
 "NCLH" => 0.05,
 "HLT" => 0.05,
 "ARE" => 0.05,
 "AIV" => 0.05,
 )
 )
 );
 return $sectorInfos;
 


 function __destruct()
 
 echo "YAAAY! " . __METHOD__ . " success! 💚 n";
 return true;
 

Output (text.txt)

"Overall":0.05,"IT":0.05,"Telecommunication":0.05,"Finance":0.05,"Energy":0.05,"Industrials":0.05,"Materials
and Chemicals":0.05,"Utilities":0.05,"Consumer
Discretionary":0.05,"Consumer
Staples":0.05,"Defense":0.05,"Health":0.05,"Real Estate":0.05