ASP.Identity - Use As-Is or Reorganize the code? The 2019 Stack Overflow Developer Survey Results Are In Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Generic ASP.NET MVC controller that generates many pagesConcerned with Enums, JSON, and ASP.NET MVCIs there currently anything wrong with my custom authentication and authorization?MVC app to associate users with rolesSafe Login StandardsPattern-matching-esque codeMenu system to manage contactsOAuth2 login for ASP.NET Core without local accountsValidating list of values to be sent to APISecurity Helper Class According To NIST SP800-63B Guidelines
TDS update packages don't remove unneeded items
Why did Peik Lin say, "I'm not an animal"?
Does Parliament hold absolute power in the UK?
What happens to a Warlock's expended Spell Slots when they gain a Level?
Did the UK government pay "millions and millions of dollars" to try to snag Julian Assange?
Can a flute soloist sit?
Do I have Disadvantage attacking with an off-hand weapon?
Why are Marketing Cloud timestamps not stored in the same timezone as Sales Cloud?
How did passengers keep warm on sail ships?
Deal with toxic manager when you can't quit
Could an empire control the whole planet with today's comunication methods?
Word to describe a time interval
Working through Single Responsibility Principle in Python when Calls are Expensive
How to read αἱμύλιος or when to aspirate
What other Star Trek series did the main TNG cast show up in?
Why doesn't a hydraulic lever violate conservation of energy?
Define a list range inside a list
Using `min_active_rowversion` for global temporary tables
Does Parliament need to approve the new Brexit delay to 31 October 2019?
One-dimensional Japanese puzzle
Is this wall load bearing? Blueprints and photos attached
For what reasons would an animal species NOT cross a *horizontal* land bridge?
What to do when moving next to a bird sanctuary with a loosely-domesticated cat?
Was credit for the black hole image misappropriated?
ASP.Identity - Use As-Is or Reorganize the code?
The 2019 Stack Overflow Developer Survey Results Are In
Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Generic ASP.NET MVC controller that generates many pagesConcerned with Enums, JSON, and ASP.NET MVCIs there currently anything wrong with my custom authentication and authorization?MVC app to associate users with rolesSafe Login StandardsPattern-matching-esque codeMenu system to manage contactsOAuth2 login for ASP.NET Core without local accountsValidating list of values to be sent to APISecurity Helper Class According To NIST SP800-63B Guidelines
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
I am still fairly new to coding and learned about the basics of ASP.NET Identity. I have used ASP.NET Identity in past personal projects for User Authentication (Individual User Accounts) and Login. As I learn more about how an application should be structured and other coding guidelines, I question whether one should reorganize the code that ASP.NET Identity provides when User Authentication is provided. Should we? For example, looking at the AccountViewModel Class below other ViewModel classes are defined within it. I was under the impression that this was bad practice. Is it? Any examples of organizing the ASP.NET Identity code better? Are there any other authorization/authentication solutions I should learn or consider using instead of ASP.NET Identity? Looking for guidance so any direction you can give would be much appreciated. Thank you!
AccountViewModel Class
public class ExternalLoginConfirmationViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class ExternalLoginListViewModel
public string ReturnUrl get; set;
public class SendCodeViewModel
public string SelectedProvider get; set;
public ICollection<System.Web.Mvc.SelectListItem> Providers get; set;
public string ReturnUrl get; set;
public bool RememberMe get; set;
public class VerifyCodeViewModel
[Required]
public string Provider get; set;
[Required]
[Display(Name = "Code")]
public string Code get; set;
public string ReturnUrl get; set;
[Display(Name = "Remember this browser?")]
public bool RememberBrowser get; set;
public bool RememberMe get; set;
public class ForgotViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class LoginViewModel
[Required]
[Display(Name = "Email")]
[EmailAddress]
public string Email get; set;
[Required]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[Display(Name = "Remember me?")]
public bool RememberMe get; set;
public class RegisterViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public class ResetPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public string Code get; set;
public class ForgotPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
c# asp.net-mvc asp.net-identity
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I am still fairly new to coding and learned about the basics of ASP.NET Identity. I have used ASP.NET Identity in past personal projects for User Authentication (Individual User Accounts) and Login. As I learn more about how an application should be structured and other coding guidelines, I question whether one should reorganize the code that ASP.NET Identity provides when User Authentication is provided. Should we? For example, looking at the AccountViewModel Class below other ViewModel classes are defined within it. I was under the impression that this was bad practice. Is it? Any examples of organizing the ASP.NET Identity code better? Are there any other authorization/authentication solutions I should learn or consider using instead of ASP.NET Identity? Looking for guidance so any direction you can give would be much appreciated. Thank you!
AccountViewModel Class
public class ExternalLoginConfirmationViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class ExternalLoginListViewModel
public string ReturnUrl get; set;
public class SendCodeViewModel
public string SelectedProvider get; set;
public ICollection<System.Web.Mvc.SelectListItem> Providers get; set;
public string ReturnUrl get; set;
public bool RememberMe get; set;
public class VerifyCodeViewModel
[Required]
public string Provider get; set;
[Required]
[Display(Name = "Code")]
public string Code get; set;
public string ReturnUrl get; set;
[Display(Name = "Remember this browser?")]
public bool RememberBrowser get; set;
public bool RememberMe get; set;
public class ForgotViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class LoginViewModel
[Required]
[Display(Name = "Email")]
[EmailAddress]
public string Email get; set;
[Required]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[Display(Name = "Remember me?")]
public bool RememberMe get; set;
public class RegisterViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public class ResetPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public string Code get; set;
public class ForgotPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
c# asp.net-mvc asp.net-identity
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I am still fairly new to coding and learned about the basics of ASP.NET Identity. I have used ASP.NET Identity in past personal projects for User Authentication (Individual User Accounts) and Login. As I learn more about how an application should be structured and other coding guidelines, I question whether one should reorganize the code that ASP.NET Identity provides when User Authentication is provided. Should we? For example, looking at the AccountViewModel Class below other ViewModel classes are defined within it. I was under the impression that this was bad practice. Is it? Any examples of organizing the ASP.NET Identity code better? Are there any other authorization/authentication solutions I should learn or consider using instead of ASP.NET Identity? Looking for guidance so any direction you can give would be much appreciated. Thank you!
AccountViewModel Class
public class ExternalLoginConfirmationViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class ExternalLoginListViewModel
public string ReturnUrl get; set;
public class SendCodeViewModel
public string SelectedProvider get; set;
public ICollection<System.Web.Mvc.SelectListItem> Providers get; set;
public string ReturnUrl get; set;
public bool RememberMe get; set;
public class VerifyCodeViewModel
[Required]
public string Provider get; set;
[Required]
[Display(Name = "Code")]
public string Code get; set;
public string ReturnUrl get; set;
[Display(Name = "Remember this browser?")]
public bool RememberBrowser get; set;
public bool RememberMe get; set;
public class ForgotViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class LoginViewModel
[Required]
[Display(Name = "Email")]
[EmailAddress]
public string Email get; set;
[Required]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[Display(Name = "Remember me?")]
public bool RememberMe get; set;
public class RegisterViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public class ResetPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public string Code get; set;
public class ForgotPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
c# asp.net-mvc asp.net-identity
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I am still fairly new to coding and learned about the basics of ASP.NET Identity. I have used ASP.NET Identity in past personal projects for User Authentication (Individual User Accounts) and Login. As I learn more about how an application should be structured and other coding guidelines, I question whether one should reorganize the code that ASP.NET Identity provides when User Authentication is provided. Should we? For example, looking at the AccountViewModel Class below other ViewModel classes are defined within it. I was under the impression that this was bad practice. Is it? Any examples of organizing the ASP.NET Identity code better? Are there any other authorization/authentication solutions I should learn or consider using instead of ASP.NET Identity? Looking for guidance so any direction you can give would be much appreciated. Thank you!
AccountViewModel Class
public class ExternalLoginConfirmationViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class ExternalLoginListViewModel
public string ReturnUrl get; set;
public class SendCodeViewModel
public string SelectedProvider get; set;
public ICollection<System.Web.Mvc.SelectListItem> Providers get; set;
public string ReturnUrl get; set;
public bool RememberMe get; set;
public class VerifyCodeViewModel
[Required]
public string Provider get; set;
[Required]
[Display(Name = "Code")]
public string Code get; set;
public string ReturnUrl get; set;
[Display(Name = "Remember this browser?")]
public bool RememberBrowser get; set;
public bool RememberMe get; set;
public class ForgotViewModel
[Required]
[Display(Name = "Email")]
public string Email get; set;
public class LoginViewModel
[Required]
[Display(Name = "Email")]
[EmailAddress]
public string Email get; set;
[Required]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[Display(Name = "Remember me?")]
public bool RememberMe get; set;
public class RegisterViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public class ResetPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
[Required]
[StringLength(100, ErrorMessage = "The 0 must be at least 2 characters long.", MinimumLength = 6)]
[DataType(DataType.Password)]
[Display(Name = "Password")]
public string Password get; set;
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword get; set;
public string Code get; set;
public class ForgotPasswordViewModel
[Required]
[EmailAddress]
[Display(Name = "Email")]
public string Email get; set;
c# asp.net-mvc asp.net-identity
c# asp.net-mvc asp.net-identity
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
IndyCodeNoobIndyCodeNoob
1
1
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
IndyCodeNoob is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
IndyCodeNoob is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217345%2fasp-identity-use-as-is-or-reorganize-the-code%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
IndyCodeNoob is a new contributor. Be nice, and check out our Code of Conduct.
IndyCodeNoob is a new contributor. Be nice, and check out our Code of Conduct.
IndyCodeNoob is a new contributor. Be nice, and check out our Code of Conduct.
IndyCodeNoob is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217345%2fasp-identity-use-as-is-or-reorganize-the-code%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown