Ttykuu

I'm currently working in a project where the user needs to log in and after that i will check if the directory /cloud/user/Projects exists and if it doesn't i will create them.

The code works, however i would like to know if there is any better way of handleing exceptions,errors or if the internet is down while doing one of the steps.

I don't think that using try-catch blocks for each FTPCommand is the best way of doing it but i cannot find information about it.(I'm using FluentFTP library).

Also i'm using await and asynchronous methods because i do not want to freeze the UI (WPF).

 var ftp = StoryManager.MainWindow.FtpClient;

 ContentGrid.Opacity = 0;
 LoadingIndicator.Opacity = 1;

 if (UsernameTextBox.Text.Equals("") || PasswordTextBox.Password.ToString().Equals(""))
 

 MessageBox.Show("Please, enter your credentials");
 ContentGrid.Opacity = 1;
 LoadingIndicator.Opacity = 0;
 return;
 


 if ((Properties.Settings.Default.LoggedUser = await Rest.LoginAsync(UsernameTextBox.Text.ToLower(), PasswordTextBox.Password.ToString())) != null)
 
 Properties.Settings.Default.KeepLogged = (bool)KeepLogged.IsChecked;
 Properties.Settings.Default.Save();
 Properties.Settings.Default.Upgrade();
 Properties.Settings.Default.Reload();
 string userDir = "/cloud/" + Properties.Settings.Default.LoggedUser.UserName;

 try
 
 bool userDirExist = StoryManager.MainWindow.FtpClient.DirectoryExists(userDir);
 bool projectsDirExist = StoryManager.MainWindow.FtpClient.DirectoryExists(userDir + "/Projects");
 bool fileExist = StoryManager.MainWindow.FtpClient.FileExists("log.txt");

 if (userDirExist)
 
 try
 
 await StoryManager.MainWindow.FtpClient.SetWorkingDirectoryAsync(userDir);
 
 catch (Exception ex)
 
 System.Windows.Forms.MessageBox.Show("An error ocurred please try again " + ex.Message);
 

 if (!projectsDirExist)
 
 try
 
 await StoryManager.MainWindow.FtpClient.CreateDirectoryAsync(userDir + "/Projects");
 
 catch (Exception ex)
 
 System.Windows.Forms.MessageBox.Show("An error ocurred please try again " + ex.Message);
 
 
 

 else
 
 try
 
 await StoryManager.MainWindow.FtpClient.CreateDirectoryAsync(userDir);
 await StoryManager.MainWindow.FtpClient.SetWorkingDirectoryAsync(userDir);
 await StoryManager.MainWindow.FtpClient.CreateDirectoryAsync(userDir + "/Projects");
 
 catch (Exception ex)
 
 System.Windows.Forms.MessageBox.Show("An error ocurred please try again " + ex.Message);
 
 

 if (!fileExist)
 
 var tempPath = Path.GetTempPath();
 var textFile = "##### Log File #####";
 textFile.AddLine(DateTime.Now.ToString());
 File.WriteAllText(tempPath + "log.txt", textFile);
 await StoryManager.MainWindow.FtpClient.UploadFileAsync(tempPath + "log.txt", "log.txt");
 File.Delete(tempPath + "log.txt");
 

 StoryManager.Add(new WelcomeScreen());
 


 catch (Exception ex)
 
 System.Windows.Forms.MessageBox.Show("An error ocurred please try again " + ex.Message);
 
 

 else
 
 ContentGrid.Opacity = 1;
 LoadingIndicator.Opacity = 0;
 
 }

Any tips/recommendations for better security, performance and error handleing for this method or for FTP management in general?

Edit 1

The Rest.LoginAsync method implementation is

 public static async Task<User> LoginAsync(string usernameValue, string passwordValue)
 

 try
 
 var result = await "https://foo.com/bar"
 .PostUrlEncodedAsync(new
 
 username = usernameValue,
 password = passwordValue
 ).ReceiveString();

 var fields = result.Split(';');

 switch (result)
 
 case "-1":
 MessageBox.Show("User/Password error");
 break;
 case "-2":
 MessageBox.Show("User/Password error");
 break;
 case "-3":
 MessageBox.Show("No License");
 break;
 case "-4":
 MessageBox.Show("Connection error");
 break;
 default:
 break;
 

 User loggedUser = new User
 
 IdUser = int.Parse(fields[0]),
 UserName = fields[1],
 MembershipStatus = fields[2],
 Name = fields[3]
 ;

 return loggedUser;

 
 catch (Exception ex)

 
 Console.WriteLine(ex.ToString());
 

 return null;

 

The rest of the operations are from C#, WPF or FluentFTP (CreateDirectory, UploadFile...)

• I would add a variable var ftpClient = StoryManager.MainWindow.FtpClient; to shorten the calls to FtpClient a bit


• You catch exceptions several times, but handle them equally. And also continue after an error. I would make a single try..catch block around everything. So the exception handling code is not duplicated and the following actions don't get executed. (Why try to add a project dir to user dir project dir does not exist yet?)