VBA Performance Deficiency in Nested LoopsCleaning up and reformatting imported data in an Excel sheetMatching between files and a list of filenames at scaleStandard Methods in VBAReport Building (Data Retrieval, Validation, Aggregation, Business Logic, Report Building, Visual Presentation)Consolidate used student hours into master sheet for exportCompare and find duplicates in 2 corresponding columns in 2 sheetsSummarize raw data in new sheet, 2.0Making a report from payroll detailsPrint For loop to immediate windowPull together information from many workbooks based on headers
Method Does Not Exist error message
Should I tell management that I intend to leave due to bad software development practices?
Extract rows of a table, that include less than x NULLs
How to tell a function to use the default argument values?
How writing a dominant 7 sus4 chord in RNA ( Vsus7 chord in the 1st inversion)
Why can't we play rap on piano?
ssTTsSTtRrriinInnnnNNNIiinngg
Is "remove commented out code" correct English?
Is there an expression that means doing something right before you will need it rather than doing it in case you might need it?
Can compressed videos be decoded back to their uncompresed original format?
Mathematica command that allows it to read my intentions
What is the most common color to indicate the input-field is disabled?
Is it logically or scientifically possible to artificially send energy to the body?
Expand and Contract
Venezuelan girlfriend wants to travel the USA to be with me. What is the process?
Assassin's bullet with mercury
How seriously should I take size and weight limits of hand luggage?
How to prevent "they're falling in love" trope
What is a romance in Latin?
What does the expression "A Mann!" means
Why doesn't using multiple commands with a || or && conditional work?
Apex Framework / library for consuming REST services
Personal Teleportation: From Rags to Riches
What killed these X2 caps?
VBA Performance Deficiency in Nested Loops
Cleaning up and reformatting imported data in an Excel sheetMatching between files and a list of filenames at scaleStandard Methods in VBAReport Building (Data Retrieval, Validation, Aggregation, Business Logic, Report Building, Visual Presentation)Consolidate used student hours into master sheet for exportCompare and find duplicates in 2 corresponding columns in 2 sheetsSummarize raw data in new sheet, 2.0Making a report from payroll detailsPrint For loop to immediate windowPull together information from many workbooks based on headers
$begingroup$
The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?
All suggestions and improvements will be highly appreciated.
Code:
Sub FillStandardHours()
'
' FillStandardHours Macro
'
Application.ScreenUpdating = False
Application.DisplayStatusBar = False
Application.Calculation = xlCalculationManual
Application.EnableEvents = False
Dim CurrentSheet, StandRosSheet As Worksheet
Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
Dim a, b, c, d, DayNum As Integer
Dim EndLoop1, EndLoop2 As Boolean
Set CurrentSheet = Sheets(ActiveSheet.Name)
CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
Set StandRosSheet = Sheets("Standard Roster")
StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
CurrentSheet.DisplayPageBreaks = False
StandRosSheet.DisplayPageBreaks = False
a = 9
Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet
b = 8
EndLoop1 = False
Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then
c = 7
Do Until c = CurrentSheetLastColumn + 1
d = 8
DayNum = CurrentSheet.Cells(6, c).Value
Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
If StandRosSheet.Cells(7, d).Value <> DayNum Then
d = d + 1
End If
If d = 22 Then
MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
Exit Sub
End If
Loop
If IsEmpty(CurrentSheet.Cells(8, c)) Then
c = c + 1
Else:
If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
CurrentSheet.Cells(a, c).Value = "NR"
ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
CurrentSheet.Cells(a, c).Value = "WFH"
Else: CurrentSheet.Cells(a, c).Value = "STD"
End If
c = c + 1
End If
Loop
EndLoop1 = True
Else: b = b + 1
End If
Loop
a = a + 1
Loop
CurrentSheet.DisplayPageBreaks = True
StandRosSheet.DisplayPageBreaks = True
Application.ScreenUpdating = True
Application.DisplayStatusBar = True
Application.Calculation = xlCalculationAutomatic
Application.EnableEvents = True
'
End Sub
vba
New contributor
$endgroup$
add a comment |
$begingroup$
The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?
All suggestions and improvements will be highly appreciated.
Code:
Sub FillStandardHours()
'
' FillStandardHours Macro
'
Application.ScreenUpdating = False
Application.DisplayStatusBar = False
Application.Calculation = xlCalculationManual
Application.EnableEvents = False
Dim CurrentSheet, StandRosSheet As Worksheet
Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
Dim a, b, c, d, DayNum As Integer
Dim EndLoop1, EndLoop2 As Boolean
Set CurrentSheet = Sheets(ActiveSheet.Name)
CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
Set StandRosSheet = Sheets("Standard Roster")
StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
CurrentSheet.DisplayPageBreaks = False
StandRosSheet.DisplayPageBreaks = False
a = 9
Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet
b = 8
EndLoop1 = False
Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then
c = 7
Do Until c = CurrentSheetLastColumn + 1
d = 8
DayNum = CurrentSheet.Cells(6, c).Value
Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
If StandRosSheet.Cells(7, d).Value <> DayNum Then
d = d + 1
End If
If d = 22 Then
MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
Exit Sub
End If
Loop
If IsEmpty(CurrentSheet.Cells(8, c)) Then
c = c + 1
Else:
If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
CurrentSheet.Cells(a, c).Value = "NR"
ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
CurrentSheet.Cells(a, c).Value = "WFH"
Else: CurrentSheet.Cells(a, c).Value = "STD"
End If
c = c + 1
End If
Loop
EndLoop1 = True
Else: b = b + 1
End If
Loop
a = a + 1
Loop
CurrentSheet.DisplayPageBreaks = True
StandRosSheet.DisplayPageBreaks = True
Application.ScreenUpdating = True
Application.DisplayStatusBar = True
Application.Calculation = xlCalculationAutomatic
Application.EnableEvents = True
'
End Sub
vba
New contributor
$endgroup$
add a comment |
$begingroup$
The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?
All suggestions and improvements will be highly appreciated.
Code:
Sub FillStandardHours()
'
' FillStandardHours Macro
'
Application.ScreenUpdating = False
Application.DisplayStatusBar = False
Application.Calculation = xlCalculationManual
Application.EnableEvents = False
Dim CurrentSheet, StandRosSheet As Worksheet
Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
Dim a, b, c, d, DayNum As Integer
Dim EndLoop1, EndLoop2 As Boolean
Set CurrentSheet = Sheets(ActiveSheet.Name)
CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
Set StandRosSheet = Sheets("Standard Roster")
StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
CurrentSheet.DisplayPageBreaks = False
StandRosSheet.DisplayPageBreaks = False
a = 9
Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet
b = 8
EndLoop1 = False
Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then
c = 7
Do Until c = CurrentSheetLastColumn + 1
d = 8
DayNum = CurrentSheet.Cells(6, c).Value
Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
If StandRosSheet.Cells(7, d).Value <> DayNum Then
d = d + 1
End If
If d = 22 Then
MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
Exit Sub
End If
Loop
If IsEmpty(CurrentSheet.Cells(8, c)) Then
c = c + 1
Else:
If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
CurrentSheet.Cells(a, c).Value = "NR"
ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
CurrentSheet.Cells(a, c).Value = "WFH"
Else: CurrentSheet.Cells(a, c).Value = "STD"
End If
c = c + 1
End If
Loop
EndLoop1 = True
Else: b = b + 1
End If
Loop
a = a + 1
Loop
CurrentSheet.DisplayPageBreaks = True
StandRosSheet.DisplayPageBreaks = True
Application.ScreenUpdating = True
Application.DisplayStatusBar = True
Application.Calculation = xlCalculationAutomatic
Application.EnableEvents = True
'
End Sub
vba
New contributor
$endgroup$
The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?
All suggestions and improvements will be highly appreciated.
Code:
Sub FillStandardHours()
'
' FillStandardHours Macro
'
Application.ScreenUpdating = False
Application.DisplayStatusBar = False
Application.Calculation = xlCalculationManual
Application.EnableEvents = False
Dim CurrentSheet, StandRosSheet As Worksheet
Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
Dim a, b, c, d, DayNum As Integer
Dim EndLoop1, EndLoop2 As Boolean
Set CurrentSheet = Sheets(ActiveSheet.Name)
CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
Set StandRosSheet = Sheets("Standard Roster")
StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row
CurrentSheet.DisplayPageBreaks = False
StandRosSheet.DisplayPageBreaks = False
a = 9
Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet
b = 8
EndLoop1 = False
Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then
c = 7
Do Until c = CurrentSheetLastColumn + 1
d = 8
DayNum = CurrentSheet.Cells(6, c).Value
Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
If StandRosSheet.Cells(7, d).Value <> DayNum Then
d = d + 1
End If
If d = 22 Then
MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
Exit Sub
End If
Loop
If IsEmpty(CurrentSheet.Cells(8, c)) Then
c = c + 1
Else:
If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
CurrentSheet.Cells(a, c).Value = "NR"
ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
CurrentSheet.Cells(a, c).Value = "WFH"
Else: CurrentSheet.Cells(a, c).Value = "STD"
End If
c = c + 1
End If
Loop
EndLoop1 = True
Else: b = b + 1
End If
Loop
a = a + 1
Loop
CurrentSheet.DisplayPageBreaks = True
StandRosSheet.DisplayPageBreaks = True
Application.ScreenUpdating = True
Application.DisplayStatusBar = True
Application.Calculation = xlCalculationAutomatic
Application.EnableEvents = True
'
End Sub
vba
vba
New contributor
New contributor
New contributor
asked 5 mins ago
Josh TJosh T
11
11
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Josh T is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216825%2fvba-performance-deficiency-in-nested-loops%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Josh T is a new contributor. Be nice, and check out our Code of Conduct.
Josh T is a new contributor. Be nice, and check out our Code of Conduct.
Josh T is a new contributor. Be nice, and check out our Code of Conduct.
Josh T is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216825%2fvba-performance-deficiency-in-nested-loops%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown