A set solution to 3-sum which is slower than 80% of submissionsR-Python sieve, 36 times slower than World RecordBrainfuck Interpreter: Slower than a Snail?Python 3 decompression routine 10x slower than C# equivalentDijkstra's algorithm using priority queue running slower than without PQInsertion sort slower than bubble sort3-Sum Problem in PythonFind every possible pair of numbers that sum up to n numberTwo-sum solution in JavaScriptHash table solution to twoSumQuadratic solution to 3Sum

Should my PhD thesis be submitted under my legal name?

Did US corporations pay demonstrators in the German demonstrations against article 13?

Adding empty element to declared container without declaring type of element

How can I raise concerns with a new DM about XP splitting?

Invariance of results when scaling explanatory variables in logistic regression, is there a proof?

Are Warlocks Arcane or Divine?

Simulating a probability of 1 of 2^N with less than N random bits

Partial sums of primes

Installing PowerShell on 32-bit Kali OS fails

How to prevent YouTube from showing already watched videos?

What is the opposite of 'gravitas'?

A workplace installs custom certificates on personal devices, can this be used to decrypt HTTPS traffic?

Greatest common substring

Can I create an upright 7-foot × 5-foot wall with the Minor Illusion spell?

Pronouncing Homer as in modern Greek

Hostile work environment after whistle-blowing on coworker and our boss. What do I do?

Can I rely on these GitHub repository files?

Bob has never been a M before

Is exact Kanji stroke length important?

Proving by induction of n. Is this correct until this point?

Resetting two CD4017 counters simultaneously, only one resets

Lifted its hind leg on or lifted its hind leg towards?

My boss asked me to take a one-day class, then signs it up as a day off

Is there a problem with hiding "forgot password" until it's needed?



A set solution to 3-sum which is slower than 80% of submissions


R-Python sieve, 36 times slower than World RecordBrainfuck Interpreter: Slower than a Snail?Python 3 decompression routine 10x slower than C# equivalentDijkstra's algorithm using priority queue running slower than without PQInsertion sort slower than bubble sort3-Sum Problem in PythonFind every possible pair of numbers that sum up to n numberTwo-sum solution in JavaScriptHash table solution to twoSumQuadratic solution to 3Sum













1












$begingroup$


I use a dummy solution to solve 3Sum problem.



that is employ set date type to handle duplicates then transform back list.




Given an array nums of n integers, are there elements a, b in nums such that a + b = 9? Find all unique couples in the array which gives the sum of zero.



Note:



The solution set must not contain duplicate triplets.



Example:



Given array nums = [-1, 0, 1, 2, -1, -4],



A solution set is:



[
[-1, 0, 1],
[-1, -1, 2]
]



My codes:



from typing import List
import logging
import unittest
import random
from collections import defaultdict,Counter

##logging.disable(level=#logging.CRITICAL)
##logging.basicConfig(level=#logging.DEBUG, format="%(levelname)s %(message)s")

class Solution:
def threeSum(self, nums, target: int=0) -> List[List[int]]:
"""
:type nums: List[int]
:type target: int
"""
if len(nums) < 3: return []

triplets = []
if target == [0, 0, 0]:
triplets.append([0, 0, 0])
return triplets # finish fast

lookup = nums[i]:i for i in range(len(nums)) #overwrite from the high
if len(lookup) == 1:#assert one identical element
keys = [k for k in lookup.keys()]
if keys[0] != 0:
return []
else:
triplets.append([0,0,0])
return triplets



triplets_set = set()

for i in range(len(nums)):
num_1 = nums[i]
sub_target = target - num_1
# #logging.debug(f"level_1_lookup: lookup")

for j in range(i+1, len(nums)):
num_2 = nums[j]
num_3 = sub_target - num_2
k = lookup.get(num_3) #
if k not in None, i, j: #don't reproduce itself
result = [num_1, num_2, num_3]
result.sort()
result = tuple(result)
triplets_set.add(result)

triplets = [list(t) for t in triplets_set]
return triplets


Run and get report




Your runtime beats 28.86 % of python3 submissions.




Could please give hints to improve?










share|improve this question









New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$











  • $begingroup$
    Can you check the problem description? It is about pairs (a, b) which sum to 9, but the examples are about triples which sum to zero. – Btw, if you beat 28.86 of other submissions then you are slower 71.14 percent, not slower than 80 percent :)
    $endgroup$
    – Martin R
    4 mins ago
















1












$begingroup$


I use a dummy solution to solve 3Sum problem.



that is employ set date type to handle duplicates then transform back list.




Given an array nums of n integers, are there elements a, b in nums such that a + b = 9? Find all unique couples in the array which gives the sum of zero.



Note:



The solution set must not contain duplicate triplets.



Example:



Given array nums = [-1, 0, 1, 2, -1, -4],



A solution set is:



[
[-1, 0, 1],
[-1, -1, 2]
]



My codes:



from typing import List
import logging
import unittest
import random
from collections import defaultdict,Counter

##logging.disable(level=#logging.CRITICAL)
##logging.basicConfig(level=#logging.DEBUG, format="%(levelname)s %(message)s")

class Solution:
def threeSum(self, nums, target: int=0) -> List[List[int]]:
"""
:type nums: List[int]
:type target: int
"""
if len(nums) < 3: return []

triplets = []
if target == [0, 0, 0]:
triplets.append([0, 0, 0])
return triplets # finish fast

lookup = nums[i]:i for i in range(len(nums)) #overwrite from the high
if len(lookup) == 1:#assert one identical element
keys = [k for k in lookup.keys()]
if keys[0] != 0:
return []
else:
triplets.append([0,0,0])
return triplets



triplets_set = set()

for i in range(len(nums)):
num_1 = nums[i]
sub_target = target - num_1
# #logging.debug(f"level_1_lookup: lookup")

for j in range(i+1, len(nums)):
num_2 = nums[j]
num_3 = sub_target - num_2
k = lookup.get(num_3) #
if k not in None, i, j: #don't reproduce itself
result = [num_1, num_2, num_3]
result.sort()
result = tuple(result)
triplets_set.add(result)

triplets = [list(t) for t in triplets_set]
return triplets


Run and get report




Your runtime beats 28.86 % of python3 submissions.




Could please give hints to improve?










share|improve this question









New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$











  • $begingroup$
    Can you check the problem description? It is about pairs (a, b) which sum to 9, but the examples are about triples which sum to zero. – Btw, if you beat 28.86 of other submissions then you are slower 71.14 percent, not slower than 80 percent :)
    $endgroup$
    – Martin R
    4 mins ago














1












1








1





$begingroup$


I use a dummy solution to solve 3Sum problem.



that is employ set date type to handle duplicates then transform back list.




Given an array nums of n integers, are there elements a, b in nums such that a + b = 9? Find all unique couples in the array which gives the sum of zero.



Note:



The solution set must not contain duplicate triplets.



Example:



Given array nums = [-1, 0, 1, 2, -1, -4],



A solution set is:



[
[-1, 0, 1],
[-1, -1, 2]
]



My codes:



from typing import List
import logging
import unittest
import random
from collections import defaultdict,Counter

##logging.disable(level=#logging.CRITICAL)
##logging.basicConfig(level=#logging.DEBUG, format="%(levelname)s %(message)s")

class Solution:
def threeSum(self, nums, target: int=0) -> List[List[int]]:
"""
:type nums: List[int]
:type target: int
"""
if len(nums) < 3: return []

triplets = []
if target == [0, 0, 0]:
triplets.append([0, 0, 0])
return triplets # finish fast

lookup = nums[i]:i for i in range(len(nums)) #overwrite from the high
if len(lookup) == 1:#assert one identical element
keys = [k for k in lookup.keys()]
if keys[0] != 0:
return []
else:
triplets.append([0,0,0])
return triplets



triplets_set = set()

for i in range(len(nums)):
num_1 = nums[i]
sub_target = target - num_1
# #logging.debug(f"level_1_lookup: lookup")

for j in range(i+1, len(nums)):
num_2 = nums[j]
num_3 = sub_target - num_2
k = lookup.get(num_3) #
if k not in None, i, j: #don't reproduce itself
result = [num_1, num_2, num_3]
result.sort()
result = tuple(result)
triplets_set.add(result)

triplets = [list(t) for t in triplets_set]
return triplets


Run and get report




Your runtime beats 28.86 % of python3 submissions.




Could please give hints to improve?










share|improve this question









New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$




I use a dummy solution to solve 3Sum problem.



that is employ set date type to handle duplicates then transform back list.




Given an array nums of n integers, are there elements a, b in nums such that a + b = 9? Find all unique couples in the array which gives the sum of zero.



Note:



The solution set must not contain duplicate triplets.



Example:



Given array nums = [-1, 0, 1, 2, -1, -4],



A solution set is:



[
[-1, 0, 1],
[-1, -1, 2]
]



My codes:



from typing import List
import logging
import unittest
import random
from collections import defaultdict,Counter

##logging.disable(level=#logging.CRITICAL)
##logging.basicConfig(level=#logging.DEBUG, format="%(levelname)s %(message)s")

class Solution:
def threeSum(self, nums, target: int=0) -> List[List[int]]:
"""
:type nums: List[int]
:type target: int
"""
if len(nums) < 3: return []

triplets = []
if target == [0, 0, 0]:
triplets.append([0, 0, 0])
return triplets # finish fast

lookup = nums[i]:i for i in range(len(nums)) #overwrite from the high
if len(lookup) == 1:#assert one identical element
keys = [k for k in lookup.keys()]
if keys[0] != 0:
return []
else:
triplets.append([0,0,0])
return triplets



triplets_set = set()

for i in range(len(nums)):
num_1 = nums[i]
sub_target = target - num_1
# #logging.debug(f"level_1_lookup: lookup")

for j in range(i+1, len(nums)):
num_2 = nums[j]
num_3 = sub_target - num_2
k = lookup.get(num_3) #
if k not in None, i, j: #don't reproduce itself
result = [num_1, num_2, num_3]
result.sort()
result = tuple(result)
triplets_set.add(result)

triplets = [list(t) for t in triplets_set]
return triplets


Run and get report




Your runtime beats 28.86 % of python3 submissions.




Could please give hints to improve?







python performance algorithm k-sum






share|improve this question









New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question









New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question








edited 2 mins ago









200_success

130k17155419




130k17155419






New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked 2 hours ago









AliceAlice

1764




1764




New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











  • $begingroup$
    Can you check the problem description? It is about pairs (a, b) which sum to 9, but the examples are about triples which sum to zero. – Btw, if you beat 28.86 of other submissions then you are slower 71.14 percent, not slower than 80 percent :)
    $endgroup$
    – Martin R
    4 mins ago

















  • $begingroup$
    Can you check the problem description? It is about pairs (a, b) which sum to 9, but the examples are about triples which sum to zero. – Btw, if you beat 28.86 of other submissions then you are slower 71.14 percent, not slower than 80 percent :)
    $endgroup$
    – Martin R
    4 mins ago
















$begingroup$
Can you check the problem description? It is about pairs (a, b) which sum to 9, but the examples are about triples which sum to zero. – Btw, if you beat 28.86 of other submissions then you are slower 71.14 percent, not slower than 80 percent :)
$endgroup$
– Martin R
4 mins ago





$begingroup$
Can you check the problem description? It is about pairs (a, b) which sum to 9, but the examples are about triples which sum to zero. – Btw, if you beat 28.86 of other submissions then you are slower 71.14 percent, not slower than 80 percent :)
$endgroup$
– Martin R
4 mins ago











0






active

oldest

votes











Your Answer





StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);






Alice is a new contributor. Be nice, and check out our Code of Conduct.









draft saved

draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216207%2fa-set-solution-to-3-sum-which-is-slower-than-80-of-submissions%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes








Alice is a new contributor. Be nice, and check out our Code of Conduct.









draft saved

draft discarded


















Alice is a new contributor. Be nice, and check out our Code of Conduct.












Alice is a new contributor. Be nice, and check out our Code of Conduct.











Alice is a new contributor. Be nice, and check out our Code of Conduct.














Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216207%2fa-set-solution-to-3-sum-which-is-slower-than-80-of-submissions%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar