Ttykuu

I have implemented two related shortest path algorithms for unweighted graphs in C89. My attempt was to learn some more idiomatic C constructs such as genericity (a client programmer should be able to plug in his/her graph data structures to the algorithms). Some questions:

1. Is it a good idea to embed the unit tests of a data type in the same *.c files?


2. Is it a good idea to do rather explicit type casting in order to make gcc -Wall -pendatic -ansi shut up?


3. Might the code below rely on an antipattern?

Code

bidirectional_breadth_first_search.c

#include "bidirectional_breadth_first_search.h"
#include "list.h"
#include "queue.h"
#include "utils.h"
#include <limits.h>

#define NEIGHBOR_NODE_ITERATOR_HAS_NEXT child_node_iterator_has_next
#define NEIGHBOR_NODE_ITERATOR_NEXT child_node_iterator_next

typedef child_node_iterator neighbor_node_iterator;

list* bidirectional_breadth_first_search(void* source_node,
 void* target_node,
 child_node_iterator* child_iterator,
 parent_node_iterator* parent_iterator,
 size_t (*hash_function)(void*),
 int (*equals_function)(void*, void*))

breadth_first_search.c

#include "breadth_first_search.h"
#include "directed_graph_node.h"
#include "queue.h"
#include "list.h"
#include "unordered_map.h"
#include "unordered_set.h"

static list* trace_back_path(void* target_node, unordered_map* parents)

 list* path = list_alloc(10);
 void* node = target_node;

 while (node)
 
 list_push_front(path, node);
 node = unordered_map_get(parents, node);
 

 return path;


list* breadth_first_search(void* source_node, 
 void* target_node,
 child_node_iterator* child_iterator,
 size_t (*hash_function) (void*),
 int (*equals_function) (void*, void*))
 !target_node
 

(The entire repository is here.)