JavaScript percentage calculation functionsCustom JavaScript function queueStructure JavaScript codeCDN Fallback “library”Functional organisation of JavaScript functionsMortgage calculator in JavaScriptAnimated SVG pie chart with custom propertiesTo-do app, as one monster function and as several smaller functionsShuntyard Javascript Calculator with unit testsCondensing a TableJavaScript interest rate calculator
How much character growth crosses the line into breaking the character
How should I respond when I lied about my education and the company finds out through background check?
We have a love-hate relationship
Are lightweight LN wallets vulnerable to transaction withholding?
Could solar power be utilized and substitute coal in the 19th Century
Can I sign legal documents with a smiley face?
If a character with the Alert feat rolls a crit fail on their Perception check, are they surprised?
Should I install hardwood flooring or cabinets first?
Does having a TSA Pre-Check member in your flight reservation increase the chances that everyone gets Pre-Check?
Indicating multiple different modes of speech (fantasy language or telepathy)
Difference between -| and |- in TikZ
Did US corporations pay demonstrators in the German demonstrations against article 13?
Can the Supreme Court overturn an impeachment?
Query about absorption line spectra
A social experiment. What is the worst that can happen?
List of people who lose a child in תנ"ך
Longest common substring in linear time
How to express sadness?
How will losing mobility of one hand affect my career as a programmer?
Do the concepts of IP address and network interface not belong to the same layer?
Flux received by a negative charge
Is a model fitted to data or is data fitted to a model?
When quoting, must I also copy hyphens used to divide words that continue on the next line?
Can somebody explain Brexit in a few child-proof sentences?
JavaScript percentage calculation functions
Custom JavaScript function queueStructure JavaScript codeCDN Fallback “library”Functional organisation of JavaScript functionsMortgage calculator in JavaScriptAnimated SVG pie chart with custom propertiesTo-do app, as one monster function and as several smaller functionsShuntyard Javascript Calculator with unit testsCondensing a TableJavaScript interest rate calculator
$begingroup$
I am building a calculator and I'm aware of what these functions do.
What I basically want feedback on is: Do I need to comment this or is there sufficient information to ascertain its purpose:
function percentOfValue(percentage, of)
return (percentage / 100) * of;
function whatPercentOfValue(small, large)
return (small / large) * 100
javascript
edited 8 mins ago
200_success
130k17155419
asked 4 hours ago
ChrisChris
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I am building a calculator and I'm aware of what these functions do.
What I basically want feedback on is: Do I need to comment this or is there sufficient information to ascertain its purpose:
function percentOfValue(percentage, of)
return (percentage / 100) * of;
function whatPercentOfValue(small, large)
return (small / large) * 100
javascript
edited 8 mins ago
200_success
130k17155419
asked 4 hours ago
ChrisChris
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I am building a calculator and I'm aware of what these functions do.
What I basically want feedback on is: Do I need to comment this or is there sufficient information to ascertain its purpose:
function percentOfValue(percentage, of)
return (percentage / 100) * of;
function whatPercentOfValue(small, large)
return (small / large) * 100
javascript
edited 8 mins ago
200_success
130k17155419
asked 4 hours ago
ChrisChris
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I am building a calculator and I'm aware of what these functions do.
What I basically want feedback on is: Do I need to comment this or is there sufficient information to ascertain its purpose:
function percentOfValue(percentage, of)
return (percentage / 100) * of;
function whatPercentOfValue(small, large)
return (small / large) * 100
javascript
javascript
edited 8 mins ago
200_success
130k17155419
asked 4 hours ago
ChrisChris
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 8 mins ago
200_success
130k17155419
asked 4 hours ago
ChrisChris
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 8 mins ago
200_success
130k17155419
edited 8 mins ago
200_success
130k17155419
edited 8 mins ago
200_success
130k17155419
130k17155419
asked 4 hours ago
ChrisChris
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 4 hours ago
ChrisChris
1042
asked 4 hours ago
ChrisChris
1042
1042
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Chris is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
$begingroup$
Code level comments usually lose their context if not properly maintained. Using self descriptive variable names is a good choice. Appreciate your efforts in keeping the code highly readable.
First method, is trying to get the Percentage value, I would update the method definition to
getPercentOfValue(from, percentage).Second method, is trying to calculate percent rate, I would update the method definition to
getPercentRate(newValue, originalValue)to follow the terminology in formula.
answered 56 mins ago
brightDotbrightDot
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Chris is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216126%2fjavascript-percentage-calculation-functions%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
Code level comments usually lose their context if not properly maintained. Using self descriptive variable names is a good choice. Appreciate your efforts in keeping the code highly readable.
First method, is trying to get the Percentage value, I would update the method definition to
getPercentOfValue(from, percentage).Second method, is trying to calculate percent rate, I would update the method definition to
getPercentRate(newValue, originalValue)to follow the terminology in formula.
answered 56 mins ago
brightDotbrightDot
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Code level comments usually lose their context if not properly maintained. Using self descriptive variable names is a good choice. Appreciate your efforts in keeping the code highly readable.
First method, is trying to get the Percentage value, I would update the method definition to
getPercentOfValue(from, percentage).Second method, is trying to calculate percent rate, I would update the method definition to
getPercentRate(newValue, originalValue)to follow the terminology in formula.
answered 56 mins ago
brightDotbrightDot
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Code level comments usually lose their context if not properly maintained. Using self descriptive variable names is a good choice. Appreciate your efforts in keeping the code highly readable.
First method, is trying to get the Percentage value, I would update the method definition to
getPercentOfValue(from, percentage).Second method, is trying to calculate percent rate, I would update the method definition to
getPercentRate(newValue, originalValue)to follow the terminology in formula.
answered 56 mins ago
brightDotbrightDot
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Code level comments usually lose their context if not properly maintained. Using self descriptive variable names is a good choice. Appreciate your efforts in keeping the code highly readable.
First method, is trying to get the Percentage value, I would update the method definition to
getPercentOfValue(from, percentage).Second method, is trying to calculate percent rate, I would update the method definition to
getPercentRate(newValue, originalValue)to follow the terminology in formula.
answered 56 mins ago
brightDotbrightDot
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
answered 56 mins ago
brightDotbrightDot
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
answered 56 mins ago
brightDotbrightDot
92
answered 56 mins ago
brightDotbrightDot
92
92
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
brightDot is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
Chris is a new contributor. Be nice, and check out our Code of Conduct.
Chris is a new contributor. Be nice, and check out our Code of Conduct.
Chris is a new contributor. Be nice, and check out our Code of Conduct.
Chris is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216126%2fjavascript-percentage-calculation-functions%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
