How to write an efficient code for the following tic-tac-toe game?Tic-Tac-Toe solverMinimax for Tic-Tac-ToeSimple class-oriented Tic Tac Toe game in C++Recursive Tic-Tac-Toe Solver in PythonUltimate Tic Tac Toe A.K.A. Tic TacticsTic Tac Toe game tree generator minimaxDesign Tic tac toe gameModularized Tic Tac Toe in CReproducing the known results for random tic tac toe play using PythonTic-Tac-Toe with React hooks

What does the "remote control" for a QF-4 look like?

Has there ever been an airliner design involving reducing generator load by installing solar panels?

Does an object always see its latest internal state irrespective of thread?

Add text to same line using sed

Is it legal for company to use my work email to pretend I still work there?

Find the result of this dual key cipher

Do infinite dimensional systems make sense?

LWC SFDX source push error TypeError: LWC1009: decl.moveTo is not a function

What is a clear way to write a bar that has an extra beat?

Can a vampire attack twice with their claws using Multiattack?

Convert two switches to a dual stack, and add outlet - possible here?

Why can't I see bouncing of a switch on an oscilloscope?

What do the dots in this tr command do: tr .............A-Z A-ZA-Z <<< "JVPQBOV" (with 13 dots)

dbcc cleantable batch size explanation

Are astronomers waiting to see something in an image from a gravitational lens that they've already seen in an adjacent image?

Can you really stack all of this on an Opportunity Attack?

RSA: Danger of using p to create q

How do I gain back my faith in my PhD degree?

Does detail obscure or enhance action?

Fully-Firstable Anagram Sets

How much of data wrangling is a data scientist's job?

High voltage LED indicator 40-1000 VDC without additional power supply

How is the claim "I am in New York only if I am in America" the same as "If I am in New York, then I am in America?

Replacing matching entries in one column of a file by another column from a different file



How to write an efficient code for the following tic-tac-toe game?


Tic-Tac-Toe solverMinimax for Tic-Tac-ToeSimple class-oriented Tic Tac Toe game in C++Recursive Tic-Tac-Toe Solver in PythonUltimate Tic Tac Toe A.K.A. Tic TacticsTic Tac Toe game tree generator minimaxDesign Tic tac toe gameModularized Tic Tac Toe in CReproducing the known results for random tic tac toe play using PythonTic-Tac-Toe with React hooks






.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



def restart():



num=[0 for i in range(9)]
board=[" " for i in range(9)]
a=2
start(board,a,num)


def wincheck(t):



for i in range(8):
if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
if t[win[i][0]]=="X":
print("Player 1 wins")
else:
print("Player 2 wins")
playa = input("Do you want to play again? Y/N")
if playa.lower() == "y":
restart()
else:
exit(0)


def display_board(t,a,num):



print( " "*3+'|'+" "*3+'|'+" "*3) 
print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
print( " "*3+'|'+" "*3+'|'+" "*3)
wincheck(t)
if 0 not in num:
print("Draw")
restart()
start(t,a,num)


def start(board,a,num):



if a%2==0:
p1n=int(input("Player 1, Enter a number from 1 to 9"))
if p1n not in num:
num[p1n-1]=p1n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p1n-1]="X"
a=a+1
display_board(board,a,num)
else:
p2n=int(input("Player 2, Enter a number from 1 to 9"))
if p2n not in num:
num[p2n-1]=p2n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p2n-1]="O"
a=a+1
display_board(board,a,num)


a=2



board=[" " for i in range(9)]



num=[0 for i in range(9)]



win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



start(board,a,num)









share







New contributor




Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    0












    $begingroup$


    I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



    def restart():



    num=[0 for i in range(9)]
    board=[" " for i in range(9)]
    a=2
    start(board,a,num)


    def wincheck(t):



    for i in range(8):
    if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
    t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
    if t[win[i][0]]=="X":
    print("Player 1 wins")
    else:
    print("Player 2 wins")
    playa = input("Do you want to play again? Y/N")
    if playa.lower() == "y":
    restart()
    else:
    exit(0)


    def display_board(t,a,num):



    print( " "*3+'|'+" "*3+'|'+" "*3) 
    print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("-"*11)
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("-"*11)
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
    print( " "*3+'|'+" "*3+'|'+" "*3)
    wincheck(t)
    if 0 not in num:
    print("Draw")
    restart()
    start(t,a,num)


    def start(board,a,num):



    if a%2==0:
    p1n=int(input("Player 1, Enter a number from 1 to 9"))
    if p1n not in num:
    num[p1n-1]=p1n
    print(num)
    else:
    print("Please enter in a free space")
    start(board,a,num)
    board[p1n-1]="X"
    a=a+1
    display_board(board,a,num)
    else:
    p2n=int(input("Player 2, Enter a number from 1 to 9"))
    if p2n not in num:
    num[p2n-1]=p2n
    print(num)
    else:
    print("Please enter in a free space")
    start(board,a,num)
    board[p2n-1]="O"
    a=a+1
    display_board(board,a,num)


    a=2



    board=[" " for i in range(9)]



    num=[0 for i in range(9)]



    win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



    start(board,a,num)









    share







    New contributor




    Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



      def restart():



      num=[0 for i in range(9)]
      board=[" " for i in range(9)]
      a=2
      start(board,a,num)


      def wincheck(t):



      for i in range(8):
      if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
      t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
      if t[win[i][0]]=="X":
      print("Player 1 wins")
      else:
      print("Player 2 wins")
      playa = input("Do you want to play again? Y/N")
      if playa.lower() == "y":
      restart()
      else:
      exit(0)


      def display_board(t,a,num):



      print( " "*3+'|'+" "*3+'|'+" "*3) 
      print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      wincheck(t)
      if 0 not in num:
      print("Draw")
      restart()
      start(t,a,num)


      def start(board,a,num):



      if a%2==0:
      p1n=int(input("Player 1, Enter a number from 1 to 9"))
      if p1n not in num:
      num[p1n-1]=p1n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p1n-1]="X"
      a=a+1
      display_board(board,a,num)
      else:
      p2n=int(input("Player 2, Enter a number from 1 to 9"))
      if p2n not in num:
      num[p2n-1]=p2n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p2n-1]="O"
      a=a+1
      display_board(board,a,num)


      a=2



      board=[" " for i in range(9)]



      num=[0 for i in range(9)]



      win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



      start(board,a,num)









      share







      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



      def restart():



      num=[0 for i in range(9)]
      board=[" " for i in range(9)]
      a=2
      start(board,a,num)


      def wincheck(t):



      for i in range(8):
      if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
      t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
      if t[win[i][0]]=="X":
      print("Player 1 wins")
      else:
      print("Player 2 wins")
      playa = input("Do you want to play again? Y/N")
      if playa.lower() == "y":
      restart()
      else:
      exit(0)


      def display_board(t,a,num):



      print( " "*3+'|'+" "*3+'|'+" "*3) 
      print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      wincheck(t)
      if 0 not in num:
      print("Draw")
      restart()
      start(t,a,num)


      def start(board,a,num):



      if a%2==0:
      p1n=int(input("Player 1, Enter a number from 1 to 9"))
      if p1n not in num:
      num[p1n-1]=p1n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p1n-1]="X"
      a=a+1
      display_board(board,a,num)
      else:
      p2n=int(input("Player 2, Enter a number from 1 to 9"))
      if p2n not in num:
      num[p2n-1]=p2n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p2n-1]="O"
      a=a+1
      display_board(board,a,num)


      a=2



      board=[" " for i in range(9)]



      num=[0 for i in range(9)]



      win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



      start(board,a,num)







      python-3.x tic-tac-toe





      share







      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 3 mins ago









      IrfanIrfan

      1




      1




      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Irfan is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216967%2fhow-to-write-an-efficient-code-for-the-following-tic-tac-toe-game%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Irfan is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Irfan is a new contributor. Be nice, and check out our Code of Conduct.












          Irfan is a new contributor. Be nice, and check out our Code of Conduct.











          Irfan is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216967%2fhow-to-write-an-efficient-code-for-the-following-tic-tac-toe-game%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

          Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar