how to correctly deal with promisesPyramidal promisesNodeJS and Express with PromisesNodeJS authentication function rewrite with promisesPromises with NodeJS and BlueBirdPerforming data transportations in RxJS with PromisesFetch: how to deal with a json payload in an error response?Guide for Tidying up code with promises and exports (nodejs)ExpressJS with Promises and EthereumNode.JS Promises and Logging inImplementing Passport authentication with promises

What is the best translation for "slot" in the context of multiplayer video games?

What is the opposite of 'gravitas'?

How can a function with a hole (removable discontinuity) equal a function with no hole?

Customer Requests (Sometimes) Drive Me Bonkers!

Sequence of Tenses: Translating the subjunctive

Different result between scanning in Epson's "color negative film" mode and scanning in positive -> invert curve in post?

Why Were Madagascar and New Zealand Discovered So Late?

What happens if you roll doubles 3 times then land on "Go to jail?"

Is this apparent Class Action settlement a spam message?

Do sorcerers' Subtle Spells require a skill check to be unseen?

What is the difference between "behavior" and "behaviour"?

Why not increase contact surface when reentering the atmosphere?

How to run a prison with the smallest amount of guards?

Why are there no referendums in the US?

Purchasing a ticket for someone else in another country?

Is there a korbon needed for conversion?

How to be diplomatic in refusing to write code that breaches the privacy of our users

What does "I’d sit this one out, Cap," imply or mean in the context?

Why does indent disappear in lists?

How can I get through very long and very dry, but also very useful technical documents when learning a new tool?

What does 算不上 mean in 算不上太美好的日子?

How do I rename a Linux host without needing to reboot for the rename to take effect?

Is it appropriate to ask a job candidate if we can record their interview?

Arithmetic mean geometric mean inequality unclear



how to correctly deal with promises


Pyramidal promisesNodeJS and Express with PromisesNodeJS authentication function rewrite with promisesPromises with NodeJS and BlueBirdPerforming data transportations in RxJS with PromisesFetch: how to deal with a json payload in an error response?Guide for Tidying up code with promises and exports (nodejs)ExpressJS with Promises and EthereumNode.JS Promises and Logging inImplementing Passport authentication with promises













0












$begingroup$


The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.



The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.



app.put('/api/v0/note/:id', (req, res) => 
const id = req.params.id;
const uid = req.user ? req.user.uid : null;
return user_can_edit_note(uid, id).then(yes =>
if (yes)
return db.collection('notes').doc(id).update(
title: req.body.title,
text: req.body.text,
author_uid: req.user ? req.user.uid : null,
updated_on: admin.firestore.Timestamp.now()
).then(() =>
return res.json(
ok: "ok"
);
);
else
return res.status(403).json(
error: "Permission Denied",
note_id: id
);

).catch((err) =>
console.error(err);
return res.status(500).json(error: String(err));
);
);









share|improve this question











$endgroup$
















    0












    $begingroup$


    The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.



    The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.



    app.put('/api/v0/note/:id', (req, res) => 
    const id = req.params.id;
    const uid = req.user ? req.user.uid : null;
    return user_can_edit_note(uid, id).then(yes =>
    if (yes)
    return db.collection('notes').doc(id).update(
    title: req.body.title,
    text: req.body.text,
    author_uid: req.user ? req.user.uid : null,
    updated_on: admin.firestore.Timestamp.now()
    ).then(() =>
    return res.json(
    ok: "ok"
    );
    );
    else
    return res.status(403).json(
    error: "Permission Denied",
    note_id: id
    );

    ).catch((err) =>
    console.error(err);
    return res.status(500).json(error: String(err));
    );
    );









    share|improve this question











    $endgroup$














      0












      0








      0





      $begingroup$


      The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.



      The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.



      app.put('/api/v0/note/:id', (req, res) => 
      const id = req.params.id;
      const uid = req.user ? req.user.uid : null;
      return user_can_edit_note(uid, id).then(yes =>
      if (yes)
      return db.collection('notes').doc(id).update(
      title: req.body.title,
      text: req.body.text,
      author_uid: req.user ? req.user.uid : null,
      updated_on: admin.firestore.Timestamp.now()
      ).then(() =>
      return res.json(
      ok: "ok"
      );
      );
      else
      return res.status(403).json(
      error: "Permission Denied",
      note_id: id
      );

      ).catch((err) =>
      console.error(err);
      return res.status(500).json(error: String(err));
      );
      );









      share|improve this question











      $endgroup$




      The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.



      The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.



      app.put('/api/v0/note/:id', (req, res) => 
      const id = req.params.id;
      const uid = req.user ? req.user.uid : null;
      return user_can_edit_note(uid, id).then(yes =>
      if (yes)
      return db.collection('notes').doc(id).update(
      title: req.body.title,
      text: req.body.text,
      author_uid: req.user ? req.user.uid : null,
      updated_on: admin.firestore.Timestamp.now()
      ).then(() =>
      return res.json(
      ok: "ok"
      );
      );
      else
      return res.status(403).json(
      error: "Permission Denied",
      note_id: id
      );

      ).catch((err) =>
      console.error(err);
      return res.status(500).json(error: String(err));
      );
      );






      promise






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 39 secs ago







      Emanuele Paolini

















      asked 14 mins ago









      Emanuele PaoliniEmanuele Paolini

      1,9991712




      1,9991712




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );













          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216388%2fhow-to-correctly-deal-with-promises%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes















          draft saved

          draft discarded
















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216388%2fhow-to-correctly-deal-with-promises%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

          Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar