Ttykuu

Is expanding the research of a group into machine learning as a PhD student risky?

How did Doctor Strange see the winning outcome in Avengers: Infinity War?

Escape a backup date in a file name

What can we do to stop prior company from asking us questions?

How to Reset Passwords on Multiple Websites Easily?

Trouble understanding the speech of overseas colleagues

Why does indent disappear in lists?

Hostile work environment after whistle-blowing on coworker and our boss. What do I do?

Return the Closest Prime Number

What is the best translation for "slot" in the context of multiplayer video games?

Unreliable Magic - Is it worth it?

How to write papers efficiently when English isn't my first language?

Why Were Madagascar and New Zealand Discovered So Late?

Flow chart document symbol

Would a high gravity rocky planet be guaranteed to have an atmosphere?

Integer addition + constant, is it a group?

Is the destination of a commercial flight important for the pilot?

Why not increase contact surface when reentering the atmosphere?

Is there a good way to store credentials outside of a password manager?

Sort a list by elements of another list

Is this apparent Class Action settlement a spam message?

I'm in charge of equipment buying but no one's ever happy with what I choose. How to fix this?

What is the opposite of 'gravitas'?

Is it appropriate to ask a job candidate if we can record their interview?

how to correctly deal with promises

Pyramidal promisesNodeJS and Express with PromisesNodeJS authentication function rewrite with promisesPromises with NodeJS and BlueBirdPerforming data transportations in RxJS with PromisesFetch: how to deal with a json payload in an error response?Guide for Tidying up code with promises and exports (nodejs)ExpressJS with Promises and EthereumNode.JS Promises and Logging inImplementing Passport authentication with promises

1

$begingroup$

The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.

The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.

app.put('/api/v0/note/:id', (req, res) => 
 const id = req.params.id;
 const uid = req.user ? req.user.uid : null;
 return user_can_edit_note(uid, id).then(yes => 
 if (yes) 
 return db.collection('notes').doc(id).update(
 title: req.body.title,
 text: req.body.text,
 author_uid: req.user ? req.user.uid : null,
 updated_on: admin.firestore.Timestamp.now()
 ).then(() => 
 return res.json(
 ok: "ok"
 );
 );
 else 
 return res.status(403).json(
 error: "Permission Denied",
 note_id: id
 );
 
 ).catch((err) => 
 console.error(err);
 return res.status(500).json(error: String(err));
 );
);

promise

share|improve this question

edited 12 mins ago

Emanuele Paolini

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712

$endgroup$

add a comment | 

1

$begingroup$

The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.

The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.

app.put('/api/v0/note/:id', (req, res) => 
 const id = req.params.id;
 const uid = req.user ? req.user.uid : null;
 return user_can_edit_note(uid, id).then(yes => 
 if (yes) 
 return db.collection('notes').doc(id).update(
 title: req.body.title,
 text: req.body.text,
 author_uid: req.user ? req.user.uid : null,
 updated_on: admin.firestore.Timestamp.now()
 ).then(() => 
 return res.json(
 ok: "ok"
 );
 );
 else 
 return res.status(403).json(
 error: "Permission Denied",
 note_id: id
 );
 
 ).catch((err) => 
 console.error(err);
 return res.status(500).json(error: String(err));
 );
);

promise

share|improve this question

edited 12 mins ago

Emanuele Paolini

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712

$endgroup$

add a comment | 

$begingroup$

The following function is accepting PUT connection to a server API, checks authorization to write and then performs write to a database.

The eslint linting tool complains saying "avoid nesting promises" and "Each then() should return a value or throw". I'm new to promises and I am not sure how to improve my code.

app.put('/api/v0/note/:id', (req, res) => 
 const id = req.params.id;
 const uid = req.user ? req.user.uid : null;
 return user_can_edit_note(uid, id).then(yes => 
 if (yes) 
 return db.collection('notes').doc(id).update(
 title: req.body.title,
 text: req.body.text,
 author_uid: req.user ? req.user.uid : null,
 updated_on: admin.firestore.Timestamp.now()
 ).then(() => 
 return res.json(
 ok: "ok"
 );
 );
 else 
 return res.status(403).json(
 error: "Permission Denied",
 note_id: id
 );
 
 ).catch((err) => 
 console.error(err);
 return res.status(500).json(error: String(err));
 );
);

promise

share|improve this question

edited 12 mins ago

Emanuele Paolini

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712

$endgroup$

app.put('/api/v0/note/:id', (req, res) => 
 const id = req.params.id;
 const uid = req.user ? req.user.uid : null;
 return user_can_edit_note(uid, id).then(yes => 
 if (yes) 
 return db.collection('notes').doc(id).update(
 title: req.body.title,
 text: req.body.text,
 author_uid: req.user ? req.user.uid : null,
 updated_on: admin.firestore.Timestamp.now()
 ).then(() => 
 return res.json(
 ok: "ok"
 );
 );
 else 
 return res.status(403).json(
 error: "Permission Denied",
 note_id: id
 );
 
 ).catch((err) => 
 console.error(err);
 return res.status(500).json(error: String(err));
 );
);

share|improve this question

edited 12 mins ago

Emanuele Paolini

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712

share|improve this question

edited 12 mins ago

Emanuele Paolini

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712

asked 26 mins ago

Emanuele PaoliniEmanuele Paolini

2,0041712