Poker Game: Unit testing different poker hands without violating DRY principlesImprove testability of constructorUnit testing IValueConverterUnit testing a CharGridUnit testing a service to return items from a databaseAlgorithms to find various kinds of paths in graphsTesting procedure with several nested yield statements in Unity3DGenerate pieces of an SQL queryOsherove TDD Kata 1: String CalculatorExercise to refactor a class with various credit limit rulesthreaded event loop “interrupt” unit test without deadlocks
Is a roofing delivery truck likely to crack my driveway slab?
Can I Retrieve Email Addresses from BCC?
Failed to fetch jessie backports repository
Is HostGator storing my password in plaintext?
What are the ramifications of creating a homebrew world without an Astral Plane?
What to do with wrong results in talks?
Stereotypical names
(Bedrock Edition) Loading more than six chunks at once
How do I define a right arrow with bar in LaTeX?
What is the intuitive meaning of having a linear relationship between the logs of two variables?
Tiptoe or tiphoof? Adjusting words to better fit fantasy races
Why is `const int& k = i; ++i; ` possible?
Dot above capital letter not centred
Will it be accepted, if there is no ''Main Character" stereotype?
Time travel short story where a man arrives in the late 19th century in a time machine and then sends the machine back into the past
Do there exist finite commutative rings with identity that are not Bézout rings?
Should my PhD thesis be submitted under my legal name?
Is there any easy technique written in Bhagavad GITA to control lust?
Curses work by shouting - How to avoid collateral damage?
How does it work when somebody invests in my business?
Is the destination of a commercial flight important for the pilot?
Is there an Impartial Brexit Deal comparison site?
Hostile work environment after whistle-blowing on coworker and our boss. What do I do?
Is there any reason not to eat food that's been dropped on the surface of the moon?
Poker Game: Unit testing different poker hands without violating DRY principles
Improve testability of constructorUnit testing IValueConverterUnit testing a CharGridUnit testing a service to return items from a databaseAlgorithms to find various kinds of paths in graphsTesting procedure with several nested yield statements in Unity3DGenerate pieces of an SQL queryOsherove TDD Kata 1: String CalculatorExercise to refactor a class with various credit limit rulesthreaded event loop “interrupt” unit test without deadlocks
$begingroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
New contributor
$endgroup$
add a comment |
$begingroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
New contributor
$endgroup$
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
58 mins ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
52 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
2 mins ago
add a comment |
$begingroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
New contributor
$endgroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
SuperCard[] testHand =
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
;
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
c# unit-testing nunit
New contributor
New contributor
edited 1 min ago
t3chb0t
35k753124
35k753124
New contributor
asked 1 hour ago
Asel SAsel S
165
165
New contributor
New contributor
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
58 mins ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
52 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
2 mins ago
add a comment |
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
58 mins ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
52 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
2 mins ago
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
58 mins ago
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
58 mins ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
52 mins ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
52 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
2 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
2 mins ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216313%2fpoker-game-unit-testing-different-poker-hands-without-violating-dry-principles%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216313%2fpoker-game-unit-testing-different-poker-hands-without-violating-dry-principles%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
58 mins ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
52 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
2 mins ago