Ttykuu

Is a roofing delivery truck likely to crack my driveway slab?

Can I Retrieve Email Addresses from BCC?

Failed to fetch jessie backports repository

Is HostGator storing my password in plaintext?

What are the ramifications of creating a homebrew world without an Astral Plane?

What to do with wrong results in talks?

Stereotypical names

(Bedrock Edition) Loading more than six chunks at once

How do I define a right arrow with bar in LaTeX?

What is the intuitive meaning of having a linear relationship between the logs of two variables?

Tiptoe or tiphoof? Adjusting words to better fit fantasy races

Why is `const int& k = i; ++i; ` possible?

Dot above capital letter not centred

Will it be accepted, if there is no ''Main Character" stereotype?

Time travel short story where a man arrives in the late 19th century in a time machine and then sends the machine back into the past

Do there exist finite commutative rings with identity that are not Bézout rings?

Should my PhD thesis be submitted under my legal name?

Is there any easy technique written in Bhagavad GITA to control lust?

Curses work by shouting - How to avoid collateral damage?

How does it work when somebody invests in my business?

Is the destination of a commercial flight important for the pilot?

Is there an Impartial Brexit Deal comparison site?

Hostile work environment after whistle-blowing on coworker and our boss. What do I do?

Is there any reason not to eat food that's been dropped on the surface of the moon?

Poker Game: Unit testing different poker hands without violating DRY principles

Improve testability of constructorUnit testing IValueConverterUnit testing a CharGridUnit testing a service to return items from a databaseAlgorithms to find various kinds of paths in graphsTesting procedure with several nested yield statements in Unity3DGenerate pieces of an SQL queryOsherove TDD Kata 1: String CalculatorExercise to refactor a class with various credit limit rulesthreaded event loop “interrupt” unit test without deadlocks

0

$begingroup$

I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.

I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.

For example, here are the unit tests for a one pair poker hand check:

 [Test]
 public void OnePair_IsLowPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Ace),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Five),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsLowerMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Eight),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHigherMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Queen),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHighPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Deuce),
 new CardDiamond(Rank.Six),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Ace)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

This is what the class diagram (at the project's current stage) looks like:

My question is how I should go about extracting a method (or methods) out of the testHand initialization.

c# unit-testing nunit

share|improve this question

edited 1 min ago

t3chb0t

35k753124

asked 1 hour ago

Asel SAsel S

165

New contributor

Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
  $endgroup$
  – AShelly
  58 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
  $endgroup$
  – Asel S
  52 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  You also need to post the code you are testing. The tests are worthless without it.
  $endgroup$
  – t3chb0t
  2 mins ago
  

  
  
  
  

add a comment | 

0

$begingroup$

I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.

I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.

For example, here are the unit tests for a one pair poker hand check:

 [Test]
 public void OnePair_IsLowPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Ace),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Five),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsLowerMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Eight),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHigherMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Queen),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHighPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Deuce),
 new CardDiamond(Rank.Six),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Ace)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

This is what the class diagram (at the project's current stage) looks like:

My question is how I should go about extracting a method (or methods) out of the testHand initialization.

c# unit-testing nunit

share|improve this question

edited 1 min ago

t3chb0t

35k753124

asked 1 hour ago

Asel SAsel S

165

New contributor

Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
  $endgroup$
  – AShelly
  58 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
  $endgroup$
  – Asel S
  52 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  You also need to post the code you are testing. The tests are worthless without it.
  $endgroup$
  – t3chb0t
  2 mins ago
  

  
  
  
  

add a comment | 

$begingroup$

I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.

I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.

For example, here are the unit tests for a one pair poker hand check:

 [Test]
 public void OnePair_IsLowPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Ace),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Five),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsLowerMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Eight),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHigherMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Queen),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHighPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Deuce),
 new CardDiamond(Rank.Six),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Ace)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

This is what the class diagram (at the project's current stage) looks like:

My question is how I should go about extracting a method (or methods) out of the testHand initialization.

c# unit-testing nunit

share|improve this question

edited 1 min ago

t3chb0t

35k753124

asked 1 hour ago

Asel SAsel S

165

New contributor

Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

 [Test]
 public void OnePair_IsLowPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Ace),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Five),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsLowerMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Eight),
 new CardSpade(Rank.Ace),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Jack),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHigherMiddlePair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Queen),
 new CardDiamond(Rank.Ace),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Three)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

 [Test]
 public void OnePair_IsHighPair_ReturnsTrue()
 
 SuperCard[] testHand =
 
 new CardClub(Rank.Jack),
 new CardSpade(Rank.Deuce),
 new CardDiamond(Rank.Six),
 new CardHeart(Rank.Ace),
 new CardClub(Rank.Ace)
 ;

 bool result = PokerHandEvaluator.OnePair(testHand);

 Assert.That(result == true);

 

share|improve this question

edited 1 min ago

t3chb0t

35k753124

asked 1 hour ago

Asel SAsel S

165

New contributor

Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share|improve this question

edited 1 min ago

t3chb0t

35k753124

asked 1 hour ago

Asel SAsel S

165

New contributor

Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

edited 1 min ago

t3chb0t

35k753124

edited 1 min ago

t3chb0t

35k753124

asked 1 hour ago

Asel SAsel S

165

New contributor

Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked 1 hour ago

Asel SAsel S

165