Project Euler Problem 8 - Largest product in a seriesNumber of maximal PAIRS-valuesProject Euler Problem 11: largest product of 4 adjacent numbersPython IBAN validationProject Euler 11: Largest product in a grid, Python3Solution to Google Code Jam 2008 round 1C problem BGeneral unit tested solution to Project Euler Problem 8: Largest product in a seriesChecking if the whole number is prime, and if all its digits are tooPython Find the N adjacent digits in the 1000-digit number that have the greatest productSearch father (x) of the number D(x) and measure time and memory consumedProject Euler 378: Count ordered triplets whose triangular numbers have decreasing number of factors

There is only s̶i̶x̶t̶y one place he can be

quarter to five p.m

What to do with wrong results in talks?

Will it be accepted, if there is no ''Main Character" stereotype?

Was the picture area of a CRT a parallelogram (instead of a true rectangle)?

Is exact Kanji stroke length important?

How will losing mobility of one hand affect my career as a programmer?

Have I saved too much for retirement so far?

Hostile work environment after whistle-blowing on coworker and our boss. What do I do?

What would be the benefits of having both a state and local currencies?

How can I use the arrow sign in my bash prompt?

At which point does a character regain all their Hit Dice?

Why Were Madagascar and New Zealand Discovered So Late?

What's the purpose of "true" in bash "if sudo true; then"

voltage of sounds of mp3files

How to be diplomatic in refusing to write code that breaches the privacy of our users

Is there a problem with hiding "forgot password" until it's needed?

Tiptoe or tiphoof? Adjusting words to better fit fantasy races

Finding all intervals that match predicate in vector

Opposite of a diet

How could Frankenstein get the parts for his _second_ creature?

Everything Bob says is false. How does he get people to trust him?

I'm in charge of equipment buying but no one's ever happy with what I choose. How to fix this?

Efficiently merge handle parallel feature branches in SFDX



Project Euler Problem 8 - Largest product in a series


Number of maximal PAIRS-valuesProject Euler Problem 11: largest product of 4 adjacent numbersPython IBAN validationProject Euler 11: Largest product in a grid, Python3Solution to Google Code Jam 2008 round 1C problem BGeneral unit tested solution to Project Euler Problem 8: Largest product in a seriesChecking if the whole number is prime, and if all its digits are tooPython Find the N adjacent digits in the 1000-digit number that have the greatest productSearch father (x) of the number D(x) and measure time and memory consumedProject Euler 378: Count ordered triplets whose triangular numbers have decreasing number of factors













0












$begingroup$


I am new to python3 and tried to solve the task in a very basic way. Please critique my code. I appriciate any suggestions for improvement.



Here is the question:




The four adjacent digits in the 1000-digit number that have the
greatest product are 9 × 9 × 8 × 9 = 5832.



73167176531330624919225119674426574742355349194934
96983520312774506326239578318016984801869478851843
85861560789112949495459501737958331952853208805511
12540698747158523863050715693290963295227443043557
66896648950445244523161731856403098711121722383113
62229893423380308135336276614282806444486645238749
30358907296290491560440772390713810515859307960866
70172427121883998797908792274921901699720888093776
65727333001053367881220235421809751254540594752243
52584907711670556013604839586446706324415722155397
53697817977846174064955149290862569321978468622482
83972241375657056057490261407972968652414535100474
82166370484403199890008895243450658541227588666881
16427171479924442928230863465674813919123162824586
17866458359124566529476545682848912883142607690042
24219022671055626321111109370544217506941658960408
07198403850962455444362981230987879927244284909188
84580156166097919133875499200524063689912560717606
05886116467109405077541002256983155200055935729725
71636269561882670428252483600823257530420752963450



Find the thirteen adjacent digits in the 1000-digit number that have
the greatest product. What is the value of this product?




My Code:



s = '7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450'

listem = []
listem2 = []
highest = 1
pp = 13
sonuc = 1

for i in range(1001 - pp + 1):
listem.append(s[i: i+pp])
for digit in listem[i]:
listem2.append(digit)
listem2 = [int(k) for k in listem2]
for q in listem2:
sonuc *= q
if highest < sonuc:
highest = sonuc
sonuc = 1
listem2 = []

print(highest)









share|improve this question









New contributor




Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    I am new to python3 and tried to solve the task in a very basic way. Please critique my code. I appriciate any suggestions for improvement.



    Here is the question:




    The four adjacent digits in the 1000-digit number that have the
    greatest product are 9 × 9 × 8 × 9 = 5832.



    73167176531330624919225119674426574742355349194934
    96983520312774506326239578318016984801869478851843
    85861560789112949495459501737958331952853208805511
    12540698747158523863050715693290963295227443043557
    66896648950445244523161731856403098711121722383113
    62229893423380308135336276614282806444486645238749
    30358907296290491560440772390713810515859307960866
    70172427121883998797908792274921901699720888093776
    65727333001053367881220235421809751254540594752243
    52584907711670556013604839586446706324415722155397
    53697817977846174064955149290862569321978468622482
    83972241375657056057490261407972968652414535100474
    82166370484403199890008895243450658541227588666881
    16427171479924442928230863465674813919123162824586
    17866458359124566529476545682848912883142607690042
    24219022671055626321111109370544217506941658960408
    07198403850962455444362981230987879927244284909188
    84580156166097919133875499200524063689912560717606
    05886116467109405077541002256983155200055935729725
    71636269561882670428252483600823257530420752963450



    Find the thirteen adjacent digits in the 1000-digit number that have
    the greatest product. What is the value of this product?




    My Code:



    s = '7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450'

    listem = []
    listem2 = []
    highest = 1
    pp = 13
    sonuc = 1

    for i in range(1001 - pp + 1):
    listem.append(s[i: i+pp])
    for digit in listem[i]:
    listem2.append(digit)
    listem2 = [int(k) for k in listem2]
    for q in listem2:
    sonuc *= q
    if highest < sonuc:
    highest = sonuc
    sonuc = 1
    listem2 = []

    print(highest)









    share|improve this question









    New contributor




    Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I am new to python3 and tried to solve the task in a very basic way. Please critique my code. I appriciate any suggestions for improvement.



      Here is the question:




      The four adjacent digits in the 1000-digit number that have the
      greatest product are 9 × 9 × 8 × 9 = 5832.



      73167176531330624919225119674426574742355349194934
      96983520312774506326239578318016984801869478851843
      85861560789112949495459501737958331952853208805511
      12540698747158523863050715693290963295227443043557
      66896648950445244523161731856403098711121722383113
      62229893423380308135336276614282806444486645238749
      30358907296290491560440772390713810515859307960866
      70172427121883998797908792274921901699720888093776
      65727333001053367881220235421809751254540594752243
      52584907711670556013604839586446706324415722155397
      53697817977846174064955149290862569321978468622482
      83972241375657056057490261407972968652414535100474
      82166370484403199890008895243450658541227588666881
      16427171479924442928230863465674813919123162824586
      17866458359124566529476545682848912883142607690042
      24219022671055626321111109370544217506941658960408
      07198403850962455444362981230987879927244284909188
      84580156166097919133875499200524063689912560717606
      05886116467109405077541002256983155200055935729725
      71636269561882670428252483600823257530420752963450



      Find the thirteen adjacent digits in the 1000-digit number that have
      the greatest product. What is the value of this product?




      My Code:



      s = '7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450'

      listem = []
      listem2 = []
      highest = 1
      pp = 13
      sonuc = 1

      for i in range(1001 - pp + 1):
      listem.append(s[i: i+pp])
      for digit in listem[i]:
      listem2.append(digit)
      listem2 = [int(k) for k in listem2]
      for q in listem2:
      sonuc *= q
      if highest < sonuc:
      highest = sonuc
      sonuc = 1
      listem2 = []

      print(highest)









      share|improve this question









      New contributor




      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am new to python3 and tried to solve the task in a very basic way. Please critique my code. I appriciate any suggestions for improvement.



      Here is the question:




      The four adjacent digits in the 1000-digit number that have the
      greatest product are 9 × 9 × 8 × 9 = 5832.



      73167176531330624919225119674426574742355349194934
      96983520312774506326239578318016984801869478851843
      85861560789112949495459501737958331952853208805511
      12540698747158523863050715693290963295227443043557
      66896648950445244523161731856403098711121722383113
      62229893423380308135336276614282806444486645238749
      30358907296290491560440772390713810515859307960866
      70172427121883998797908792274921901699720888093776
      65727333001053367881220235421809751254540594752243
      52584907711670556013604839586446706324415722155397
      53697817977846174064955149290862569321978468622482
      83972241375657056057490261407972968652414535100474
      82166370484403199890008895243450658541227588666881
      16427171479924442928230863465674813919123162824586
      17866458359124566529476545682848912883142607690042
      24219022671055626321111109370544217506941658960408
      07198403850962455444362981230987879927244284909188
      84580156166097919133875499200524063689912560717606
      05886116467109405077541002256983155200055935729725
      71636269561882670428252483600823257530420752963450



      Find the thirteen adjacent digits in the 1000-digit number that have
      the greatest product. What is the value of this product?




      My Code:



      s = '7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450'

      listem = []
      listem2 = []
      highest = 1
      pp = 13
      sonuc = 1

      for i in range(1001 - pp + 1):
      listem.append(s[i: i+pp])
      for digit in listem[i]:
      listem2.append(digit)
      listem2 = [int(k) for k in listem2]
      for q in listem2:
      sonuc *= q
      if highest < sonuc:
      highest = sonuc
      sonuc = 1
      listem2 = []

      print(highest)






      python beginner python-3.x programming-challenge






      share|improve this question









      New contributor




      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 18 mins ago









      Alex

      856316




      856316






      New contributor




      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 1 hour ago









      Güray SurGüray Sur

      62




      62




      New contributor




      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Güray Sur is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Güray Sur is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216289%2fproject-euler-problem-8-largest-product-in-a-series%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Güray Sur is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Güray Sur is a new contributor. Be nice, and check out our Code of Conduct.












          Güray Sur is a new contributor. Be nice, and check out our Code of Conduct.











          Güray Sur is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216289%2fproject-euler-problem-8-largest-product-in-a-series%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

          Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar