Retrieving information about a vendor using MySQLMake this C# code more DRYIn need of some aid in regards to making my code more efficientHow can I make this piece of code more secure?Making adding to a dictionary more efficient?FormBuilder Code Make More GenereicMaking operations more dynamicFlexible socket frameworkMaking generic code when using large EnumsFlexible TCP socket frameworkMaking TypeNameHandling in json.net more convenient

Go Pregnant or Go Home

Products and sum of cubes in Fibonacci

Applicability of Single Responsibility Principle

Are there any comparative studies done between Ashtavakra Gita and Buddhim?

when is out of tune ok?

Generic lambda vs generic function give different behaviour

There is only s̶i̶x̶t̶y one place he can be

What's a natural way to say that someone works somewhere (for a job)?

Teaching indefinite integrals that require special-casing

The plural of 'stomach"

Print name if parameter passed to function

Everything Bob says is false. How does he get people to trust him?

How do I define a right arrow with bar in LaTeX?

Finding all intervals that match predicate in vector

Do there exist finite commutative rings with identity that are not Bézout rings?

Where in the Bible does the greeting ("Dominus Vobiscum") used at Mass come from?

Ways to speed up user implemented RK4

Can a monster with multiattack use this ability if they are missing a limb?

Why are on-board computers allowed to change controls without notifying the pilots?

What is difference between behavior and behaviour

Why is delta-v is the most useful quantity for planning space travel?

Will it be accepted, if there is no ''Main Character" stereotype?

apt-get update is failing in debian

Why does John Bercow say “unlock” after reading out the results of a vote?



Retrieving information about a vendor using MySQL


Make this C# code more DRYIn need of some aid in regards to making my code more efficientHow can I make this piece of code more secure?Making adding to a dictionary more efficient?FormBuilder Code Make More GenereicMaking operations more dynamicFlexible socket frameworkMaking generic code when using large EnumsFlexible TCP socket frameworkMaking TypeNameHandling in json.net more convenient













0












$begingroup$


I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



P.S. The vendorCrud object is a database helper.



 private List<string> GetVendorInformation(string vendorId)

crud vendorCrud = new crud();
List<string> columnData = new List<string>();

string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
"LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
"WHERE vendor.vendor_id = 0 ORDER BY contact_default DESC LIMIT 1", vendorId);

vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

foreach (DataRow item in vendorCrud.table.Rows)

columnData.Add(item["tin"].ToString());
columnData.Add(item["email_add"].ToString());
columnData.Add(item["fax_no"].ToString());
columnData.Add(item["tel_no"].ToString());
columnData.Add(item["contact_person"].ToString());


return columnData;


private void SetVendorInformation(List<string> colData)

txtVendorTin.EditValue = colData[0];
txtEmail.EditValue = colData[1];
txtFaxNo.EditValue = colData[2];
txtTelNo.EditValue = colData[3];
txtAttention.EditValue = colData[4];


private void txtSupplier_EditValueChanged(object sender, EventArgs e)

SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));










share|improve this question









New contributor




Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



    P.S. The vendorCrud object is a database helper.



     private List<string> GetVendorInformation(string vendorId)

    crud vendorCrud = new crud();
    List<string> columnData = new List<string>();

    string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
    "LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
    "WHERE vendor.vendor_id = 0 ORDER BY contact_default DESC LIMIT 1", vendorId);

    vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

    foreach (DataRow item in vendorCrud.table.Rows)

    columnData.Add(item["tin"].ToString());
    columnData.Add(item["email_add"].ToString());
    columnData.Add(item["fax_no"].ToString());
    columnData.Add(item["tel_no"].ToString());
    columnData.Add(item["contact_person"].ToString());


    return columnData;


    private void SetVendorInformation(List<string> colData)

    txtVendorTin.EditValue = colData[0];
    txtEmail.EditValue = colData[1];
    txtFaxNo.EditValue = colData[2];
    txtTelNo.EditValue = colData[3];
    txtAttention.EditValue = colData[4];


    private void txtSupplier_EditValueChanged(object sender, EventArgs e)

    SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));










    share|improve this question









    New contributor




    Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



      P.S. The vendorCrud object is a database helper.



       private List<string> GetVendorInformation(string vendorId)

      crud vendorCrud = new crud();
      List<string> columnData = new List<string>();

      string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
      "LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
      "WHERE vendor.vendor_id = 0 ORDER BY contact_default DESC LIMIT 1", vendorId);

      vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

      foreach (DataRow item in vendorCrud.table.Rows)

      columnData.Add(item["tin"].ToString());
      columnData.Add(item["email_add"].ToString());
      columnData.Add(item["fax_no"].ToString());
      columnData.Add(item["tel_no"].ToString());
      columnData.Add(item["contact_person"].ToString());


      return columnData;


      private void SetVendorInformation(List<string> colData)

      txtVendorTin.EditValue = colData[0];
      txtEmail.EditValue = colData[1];
      txtFaxNo.EditValue = colData[2];
      txtTelNo.EditValue = colData[3];
      txtAttention.EditValue = colData[4];


      private void txtSupplier_EditValueChanged(object sender, EventArgs e)

      SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));










      share|improve this question









      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am loading some information about the selected vendor using mysql query. I made a method with a List as return type, then created another method to assign values coming from a list. I am wondering if there is a better way of doing things.



      P.S. The vendorCrud object is a database helper.



       private List<string> GetVendorInformation(string vendorId)

      crud vendorCrud = new crud();
      List<string> columnData = new List<string>();

      string query = String.Format("SELECT tin, email_add, fax_no, tel_no, contact.contact_person FROM lib_inv_vendor vendor " +
      "LEFT JOIN lib_inv_vendor_contact_person contact ON vendor.vendor_id = contact.vendor_id " +
      "WHERE vendor.vendor_id = 0 ORDER BY contact_default DESC LIMIT 1", vendorId);

      vendorCrud.load_data(query, Modules.connection.filesetupDB1, CommandType.Text);

      foreach (DataRow item in vendorCrud.table.Rows)

      columnData.Add(item["tin"].ToString());
      columnData.Add(item["email_add"].ToString());
      columnData.Add(item["fax_no"].ToString());
      columnData.Add(item["tel_no"].ToString());
      columnData.Add(item["contact_person"].ToString());


      return columnData;


      private void SetVendorInformation(List<string> colData)

      txtVendorTin.EditValue = colData[0];
      txtEmail.EditValue = colData[1];
      txtFaxNo.EditValue = colData[2];
      txtTelNo.EditValue = colData[3];
      txtAttention.EditValue = colData[4];


      private void txtSupplier_EditValueChanged(object sender, EventArgs e)

      SetVendorInformation(GetVendorInformation(txtSupplier.EditValue.ToString()));







      c# mysql






      share|improve this question









      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 6 mins ago









      200_success

      130k17155419




      130k17155419






      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 48 mins ago









      Vish GuerreroVish Guerrero

      12




      12




      New contributor




      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Vish Guerrero is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216306%2fretrieving-information-about-a-vendor-using-mysql%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.












          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.











          Vish Guerrero is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216306%2fretrieving-information-about-a-vendor-using-mysql%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

          Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar