Simple Rock, Paper, Scissors Python GameRock, Paper, Scissors game assignmentSimple Rock, Paper, Scissors in PythonPython rock paper scissorsSimple Rock Paper Scissors GameRock, Paper, Scissors - Python gameRock, Paper Scissors game in PythonProcedural style Rock Paper Scissors game using Python 3Python 3.6 Rock-Paper-Scissors gameRock, Paper, Scissors game made in python“Rock, Paper, Scissors” game

Help with identifying unique aircraft over NE Pennsylvania

Did Nintendo change its mind about 68000 SNES?

Error in master's thesis, I do not know what to do

Does the Shadow Magic sorcerer's Eyes of the Dark feature work on all Darkness spells or just his/her own?

Hackerrank All Women's Codesprint 2019: Name the Product

pipe commands inside find -exec?

Why is participating in the European Parliamentary elections used as a threat?

Print last inputted byte

Imaginary part of expression too difficult to calculate

Nested Dynamic SOQL Query

If I cast the Enlarge/Reduce spell on an arrow, what weapon could it count as?

What is it called when someone votes for an option that's not their first choice?

Would this string work as string?

Exit shell with shortcut (not typing exit) that closes session properly

Difficulty understanding group delay concept

Is "inadequate referencing" a euphemism for plagiarism?

Why is this tree refusing to shed its dead leaves?

Logic with "co-relations" - sources?

How can an organ that provides biological immortality be unable to regenerate?

How to remove space in section title at KOMA-Script

Pre-Employment Background Check With Consent For Future Checks

The English Debate

How can I create URL shortcuts/redirects for task/diff IDs in Phabricator?

What are the rules for concealing thieves' tools (or items in general)?



Simple Rock, Paper, Scissors Python Game


Rock, Paper, Scissors game assignmentSimple Rock, Paper, Scissors in PythonPython rock paper scissorsSimple Rock Paper Scissors GameRock, Paper, Scissors - Python gameRock, Paper Scissors game in PythonProcedural style Rock Paper Scissors game using Python 3Python 3.6 Rock-Paper-Scissors gameRock, Paper, Scissors game made in python“Rock, Paper, Scissors” game













0












$begingroup$


I tried to learn Python during the weekend and after getting some knowledge, decided to make a small rock, paper, scissors game. I would be grateful for your inputs on how I could improve my code. All feedback is highly appreciated c:



import random


def round_winner(choice):
ai_chosen = str(random.randint(1, 3))
print(f'AI chose ai_chosen')

if choice == '1' and ai_chosen == '2':
return 'ai'
elif choice == '2' and ai_chosen == '3':
return 'ai'
elif choice == '3' and ai_chosen == '1':
return 'ai'
elif choice == ai_chosen:
return 'tie'
else:
return 'player'


def display_round_winner(winner):
if winner == 'tie':
print('This round is tied!')
else:
print(f'The winner this round is the winner.upper()')

print(f'''
Current points as follows:
Player: counter['player']
AI: counter['ai']
Rounds Tied: counter['tie']
''')


def score_checker():
global game_ongoing
for key, value in counter.items():
if value == 2:
print(f'key.upper() wins the game!')
game_ongoing = False


def initializer():
global counter
message = '''
Please choose one of the following:
1: Rock
2: Paper
3: Scissors
'''

print(message)

choice_of_obj = input('What will it be: ')
if choice_of_obj in ['1', '2', '3']:
winner = round_winner(choice_of_obj)
counter[winner] += 1
display_round_winner(winner)
score_checker()
else:
print('Out of bounds')


counter =
'player': 0,
'ai': 0,
'tie': 0


game_ongoing = True

while game_ongoing:
initializer()








share







New contributor




aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    I tried to learn Python during the weekend and after getting some knowledge, decided to make a small rock, paper, scissors game. I would be grateful for your inputs on how I could improve my code. All feedback is highly appreciated c:



    import random


    def round_winner(choice):
    ai_chosen = str(random.randint(1, 3))
    print(f'AI chose ai_chosen')

    if choice == '1' and ai_chosen == '2':
    return 'ai'
    elif choice == '2' and ai_chosen == '3':
    return 'ai'
    elif choice == '3' and ai_chosen == '1':
    return 'ai'
    elif choice == ai_chosen:
    return 'tie'
    else:
    return 'player'


    def display_round_winner(winner):
    if winner == 'tie':
    print('This round is tied!')
    else:
    print(f'The winner this round is the winner.upper()')

    print(f'''
    Current points as follows:
    Player: counter['player']
    AI: counter['ai']
    Rounds Tied: counter['tie']
    ''')


    def score_checker():
    global game_ongoing
    for key, value in counter.items():
    if value == 2:
    print(f'key.upper() wins the game!')
    game_ongoing = False


    def initializer():
    global counter
    message = '''
    Please choose one of the following:
    1: Rock
    2: Paper
    3: Scissors
    '''

    print(message)

    choice_of_obj = input('What will it be: ')
    if choice_of_obj in ['1', '2', '3']:
    winner = round_winner(choice_of_obj)
    counter[winner] += 1
    display_round_winner(winner)
    score_checker()
    else:
    print('Out of bounds')


    counter =
    'player': 0,
    'ai': 0,
    'tie': 0


    game_ongoing = True

    while game_ongoing:
    initializer()








    share







    New contributor




    aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I tried to learn Python during the weekend and after getting some knowledge, decided to make a small rock, paper, scissors game. I would be grateful for your inputs on how I could improve my code. All feedback is highly appreciated c:



      import random


      def round_winner(choice):
      ai_chosen = str(random.randint(1, 3))
      print(f'AI chose ai_chosen')

      if choice == '1' and ai_chosen == '2':
      return 'ai'
      elif choice == '2' and ai_chosen == '3':
      return 'ai'
      elif choice == '3' and ai_chosen == '1':
      return 'ai'
      elif choice == ai_chosen:
      return 'tie'
      else:
      return 'player'


      def display_round_winner(winner):
      if winner == 'tie':
      print('This round is tied!')
      else:
      print(f'The winner this round is the winner.upper()')

      print(f'''
      Current points as follows:
      Player: counter['player']
      AI: counter['ai']
      Rounds Tied: counter['tie']
      ''')


      def score_checker():
      global game_ongoing
      for key, value in counter.items():
      if value == 2:
      print(f'key.upper() wins the game!')
      game_ongoing = False


      def initializer():
      global counter
      message = '''
      Please choose one of the following:
      1: Rock
      2: Paper
      3: Scissors
      '''

      print(message)

      choice_of_obj = input('What will it be: ')
      if choice_of_obj in ['1', '2', '3']:
      winner = round_winner(choice_of_obj)
      counter[winner] += 1
      display_round_winner(winner)
      score_checker()
      else:
      print('Out of bounds')


      counter =
      'player': 0,
      'ai': 0,
      'tie': 0


      game_ongoing = True

      while game_ongoing:
      initializer()








      share







      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I tried to learn Python during the weekend and after getting some knowledge, decided to make a small rock, paper, scissors game. I would be grateful for your inputs on how I could improve my code. All feedback is highly appreciated c:



      import random


      def round_winner(choice):
      ai_chosen = str(random.randint(1, 3))
      print(f'AI chose ai_chosen')

      if choice == '1' and ai_chosen == '2':
      return 'ai'
      elif choice == '2' and ai_chosen == '3':
      return 'ai'
      elif choice == '3' and ai_chosen == '1':
      return 'ai'
      elif choice == ai_chosen:
      return 'tie'
      else:
      return 'player'


      def display_round_winner(winner):
      if winner == 'tie':
      print('This round is tied!')
      else:
      print(f'The winner this round is the winner.upper()')

      print(f'''
      Current points as follows:
      Player: counter['player']
      AI: counter['ai']
      Rounds Tied: counter['tie']
      ''')


      def score_checker():
      global game_ongoing
      for key, value in counter.items():
      if value == 2:
      print(f'key.upper() wins the game!')
      game_ongoing = False


      def initializer():
      global counter
      message = '''
      Please choose one of the following:
      1: Rock
      2: Paper
      3: Scissors
      '''

      print(message)

      choice_of_obj = input('What will it be: ')
      if choice_of_obj in ['1', '2', '3']:
      winner = round_winner(choice_of_obj)
      counter[winner] += 1
      display_round_winner(winner)
      score_checker()
      else:
      print('Out of bounds')


      counter =
      'player': 0,
      'ai': 0,
      'tie': 0


      game_ongoing = True

      while game_ongoing:
      initializer()






      python





      share







      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 3 mins ago









      aleisleyaleisley

      1




      1




      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          aleisley is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215714%2fsimple-rock-paper-scissors-python-game%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          aleisley is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          aleisley is a new contributor. Be nice, and check out our Code of Conduct.












          aleisley is a new contributor. Be nice, and check out our Code of Conduct.











          aleisley is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215714%2fsimple-rock-paper-scissors-python-game%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

          Prove that NP is closed under karp reduction?Space(n) not closed under Karp reductions - what about NTime(n)?Class P is closed under rotation?Prove or disprove that $NL$ is closed under polynomial many-one reductions$mathbfNC_2$ is closed under log-space reductionOn Karp reductionwhen can I know if a class (complexity) is closed under reduction (cook/karp)Check if class $PSPACE$ is closed under polyonomially space reductionIs NPSPACE also closed under polynomial-time reduction and under log-space reduction?Prove PSPACE is closed under complement?Prove PSPACE is closed under union?

          Is my guitar’s action too high? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern)Strings too stiff on a recently purchased acoustic guitar | Cort AD880CEIs the action of my guitar really high?Μy little finger is too weak to play guitarWith guitar, how long should I give my fingers to strengthen / callous?When playing a fret the guitar sounds mutedPlaying (Barre) chords up the guitar neckI think my guitar strings are wound too tight and I can't play barre chordsF barre chord on an SG guitarHow to find to the right strings of a barre chord by feel?High action on higher fret on my steel acoustic guitar