Correctness of C++14 static initialization ordering technique?Static Multilevel Inheritance with CRTP (Fast Intrusive Pointers)Instance depth ordering systemSingleton as static instanceA classy wine collection - Construction vs. InitializationAn implementation of a static any typeA polymorphic callable wrapper for any callableArray whose first element is arbitralily indexed – writing a container wrapperStatic Batch file AnalyserGenerators and Distributions 2.0Recursive data-types, binary tree, list-initialization

dbcc cleantable batch size explanation

How to source a part of a file

If human space travel is limited by the G force vulnerability, is there a way to counter G forces?

Is it possible to run Internet Explorer on OS X El Capitan?

Replacing matching entries in one column of a file by another column from a different file

What's the point of deactivating Num Lock on login screens?

Alternative to sending password over mail?

Roll the carpet

How to move a thin line with the black arrow in Illustrator?

Does detail obscure or enhance action?

What typically incentivizes a professor to change jobs to a lower ranking university?

Maximum likelihood parameters deviate from posterior distributions

Horror movie about a virus at the prom; beginning and end are stylized as a cartoon

Why is 150k or 200k jobs considered good when there's 300k+ births a month?

Why are electrically insulating heatsinks so rare? Is it just cost?

How is the claim "I am in New York only if I am in America" the same as "If I am in New York, then I am in America?

I'm flying to France today and my passport expires in less than 2 months

What's that red-plus icon near a text?

expand `ifthenelse` immediately

Approximately how much travel time was saved by the opening of the Suez Canal in 1869?

RSA: Danger of using p to create q

Is it unprofessional to ask if a job posting on GlassDoor is real?

Today is the Center

How to regain access to running applications after accidentally zapping X.org?



Correctness of C++14 static initialization ordering technique?


Static Multilevel Inheritance with CRTP (Fast Intrusive Pointers)Instance depth ordering systemSingleton as static instanceA classy wine collection - Construction vs. InitializationAn implementation of a static any typeA polymorphic callable wrapper for any callableArray whose first element is arbitralily indexed – writing a container wrapperStatic Batch file AnalyserGenerators and Distributions 2.0Recursive data-types, binary tree, list-initialization






.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


I have inherited legacy code containing static initialization order problems:



// A.hpp
class A
public:
static A A1;
A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;


This fails when MY_FAVORITE_A is initialized before A::A1.



I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?



// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();

;

namespace
int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

static A::Initializer initializer;
return 0;


A::Initializer::Initializer()

A::A1 = A(...);



B.cpp is unchanged.










share|improve this question











$endgroup$







  • 1




    $begingroup$
    This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
    $endgroup$
    – pacmaninbw
    21 mins ago










  • $begingroup$
    From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
    $endgroup$
    – kevin cline
    7 mins ago


















0












$begingroup$


I have inherited legacy code containing static initialization order problems:



// A.hpp
class A
public:
static A A1;
A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;


This fails when MY_FAVORITE_A is initialized before A::A1.



I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?



// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();

;

namespace
int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

static A::Initializer initializer;
return 0;


A::Initializer::Initializer()

A::A1 = A(...);



B.cpp is unchanged.










share|improve this question











$endgroup$







  • 1




    $begingroup$
    This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
    $endgroup$
    – pacmaninbw
    21 mins ago










  • $begingroup$
    From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
    $endgroup$
    – kevin cline
    7 mins ago














0












0








0





$begingroup$


I have inherited legacy code containing static initialization order problems:



// A.hpp
class A
public:
static A A1;
A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;


This fails when MY_FAVORITE_A is initialized before A::A1.



I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?



// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();

;

namespace
int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

static A::Initializer initializer;
return 0;


A::Initializer::Initializer()

A::A1 = A(...);



B.cpp is unchanged.










share|improve this question











$endgroup$




I have inherited legacy code containing static initialization order problems:



// A.hpp
class A
public:
static A A1;
A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;


This fails when MY_FAVORITE_A is initialized before A::A1.



I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?



// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();

;

namespace
int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

static A::Initializer initializer;
return 0;


A::Initializer::Initializer()

A::A1 = A(...);



B.cpp is unchanged.







c++ c++14






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 1 min ago







kevin cline

















asked 56 mins ago









kevin clinekevin cline

32516




32516







  • 1




    $begingroup$
    This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
    $endgroup$
    – pacmaninbw
    21 mins ago










  • $begingroup$
    From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
    $endgroup$
    – kevin cline
    7 mins ago













  • 1




    $begingroup$
    This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
    $endgroup$
    – pacmaninbw
    21 mins ago










  • $begingroup$
    From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
    $endgroup$
    – kevin cline
    7 mins ago








1




1




$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago




$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago












$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago





$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago











0






active

oldest

votes












Your Answer





StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);













draft saved

draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216951%2fcorrectness-of-c14-static-initialization-ordering-technique%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes















draft saved

draft discarded
















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216951%2fcorrectness-of-c14-static-initialization-ordering-technique%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

名間水力發電廠 目录 沿革 設施 鄰近設施 註釋 外部連結 导航菜单23°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.7113923°50′10″N 120°42′41″E / 23.83611°N 120.71139°E / 23.83611; 120.71139計畫概要原始内容臺灣第一座BOT 模式開發的水力發電廠-名間水力電廠名間水力發電廠 水利署首件BOT案原始内容《小檔案》名間電廠 首座BOT水力發電廠原始内容名間電廠BOT - 經濟部水利署中區水資源局

格濟夫卡 參考資料 导航菜单51°3′40″N 34°2′21″E / 51.06111°N 34.03917°E / 51.06111; 34.03917ГезівкаПогода в селі 编辑或修订