Correctness of C++14 static initialization ordering technique?Static Multilevel Inheritance with CRTP (Fast Intrusive Pointers)Instance depth ordering systemSingleton as static instanceA classy wine collection - Construction vs. InitializationAn implementation of a static any typeA polymorphic callable wrapper for any callableArray whose first element is arbitralily indexed – writing a container wrapperStatic Batch file AnalyserGenerators and Distributions 2.0Recursive data-types, binary tree, list-initialization
dbcc cleantable batch size explanation
How to source a part of a file
If human space travel is limited by the G force vulnerability, is there a way to counter G forces?
Is it possible to run Internet Explorer on OS X El Capitan?
Replacing matching entries in one column of a file by another column from a different file
What's the point of deactivating Num Lock on login screens?
Alternative to sending password over mail?
Roll the carpet
How to move a thin line with the black arrow in Illustrator?
Does detail obscure or enhance action?
What typically incentivizes a professor to change jobs to a lower ranking university?
Maximum likelihood parameters deviate from posterior distributions
Horror movie about a virus at the prom; beginning and end are stylized as a cartoon
Why is 150k or 200k jobs considered good when there's 300k+ births a month?
Why are electrically insulating heatsinks so rare? Is it just cost?
How is the claim "I am in New York only if I am in America" the same as "If I am in New York, then I am in America?
I'm flying to France today and my passport expires in less than 2 months
What's that red-plus icon near a text?
expand `ifthenelse` immediately
Approximately how much travel time was saved by the opening of the Suez Canal in 1869?
RSA: Danger of using p to create q
Is it unprofessional to ask if a job posting on GlassDoor is real?
Today is the Center
How to regain access to running applications after accidentally zapping X.org?
Correctness of C++14 static initialization ordering technique?
Static Multilevel Inheritance with CRTP (Fast Intrusive Pointers)Instance depth ordering systemSingleton as static instanceA classy wine collection - Construction vs. InitializationAn implementation of a static any typeA polymorphic callable wrapper for any callableArray whose first element is arbitralily indexed – writing a container wrapperStatic Batch file AnalyserGenerators and Distributions 2.0Recursive data-types, binary tree, list-initialization
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
$begingroup$
I have inherited legacy code containing static initialization order problems:
// A.hpp
class A
public:
static A A1;
A(...);
;
// A.cpp
A A::A1(...);
// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;
This fails when MY_FAVORITE_A is initialized before A::A1.
I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?
// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();
;
namespace
int a_initializer = A::initialize_statics();
// A.cpp
A MY_FAVORITE_A;
A::initialize_statics()
static A::Initializer initializer;
return 0;
A::Initializer::Initializer()
A::A1 = A(...);
B.cpp is unchanged.
c++ c++14
$endgroup$
add a comment |
$begingroup$
I have inherited legacy code containing static initialization order problems:
// A.hpp
class A
public:
static A A1;
A(...);
;
// A.cpp
A A::A1(...);
// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;
This fails when MY_FAVORITE_A is initialized before A::A1.
I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?
// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();
;
namespace
int a_initializer = A::initialize_statics();
// A.cpp
A MY_FAVORITE_A;
A::initialize_statics()
static A::Initializer initializer;
return 0;
A::Initializer::Initializer()
A::A1 = A(...);
B.cpp is unchanged.
c++ c++14
$endgroup$
1
$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago
$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago
add a comment |
$begingroup$
I have inherited legacy code containing static initialization order problems:
// A.hpp
class A
public:
static A A1;
A(...);
;
// A.cpp
A A::A1(...);
// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;
This fails when MY_FAVORITE_A is initialized before A::A1.
I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?
// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();
;
namespace
int a_initializer = A::initialize_statics();
// A.cpp
A MY_FAVORITE_A;
A::initialize_statics()
static A::Initializer initializer;
return 0;
A::Initializer::Initializer()
A::A1 = A(...);
B.cpp is unchanged.
c++ c++14
$endgroup$
I have inherited legacy code containing static initialization order problems:
// A.hpp
class A
public:
static A A1;
A(...);
;
// A.cpp
A A::A1(...);
// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;
This fails when MY_FAVORITE_A is initialized before A::A1.
I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?
// A.h
class A
public:
static A A1;
A(...);
private:
class Initializer
public:
Initializer();
;
namespace
int a_initializer = A::initialize_statics();
// A.cpp
A MY_FAVORITE_A;
A::initialize_statics()
static A::Initializer initializer;
return 0;
A::Initializer::Initializer()
A::A1 = A(...);
B.cpp is unchanged.
c++ c++14
c++ c++14
edited 1 min ago
kevin cline
asked 56 mins ago
kevin clinekevin cline
32516
32516
1
$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago
$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago
add a comment |
1
$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago
$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago
1
1
$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago
$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago
$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago
$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216951%2fcorrectness-of-c14-static-initialization-ordering-technique%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216951%2fcorrectness-of-c14-static-initialization-ordering-technique%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
var $window = $(window),
onScroll = function(e)
var $elem = $('.new-login-left'),
docViewTop = $window.scrollTop(),
docViewBottom = docViewTop + $window.height(),
elemTop = $elem.offset().top,
elemBottom = elemTop + $elem.height();
if ((docViewTop elemBottom))
StackExchange.using('gps', function() StackExchange.gps.track('embedded_signup_form.view', location: 'question_page' ); );
$window.unbind('scroll', onScroll);
;
$window.on('scroll', onScroll);
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
$begingroup$
This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
$endgroup$
– pacmaninbw
21 mins ago
$begingroup$
From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
$endgroup$
– kevin cline
7 mins ago